-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggest using unsigned_abs
in abs
documentation
#124184
Merged
bors
merged 1 commit into
rust-lang:master
from
gurry:124152-suggest-unsigned-abs-in-abs-doc
Apr 21, 2024
Merged
Suggest using unsigned_abs
in abs
documentation
#124184
bors
merged 1 commit into
rust-lang:master
from
gurry:124152-suggest-unsigned-abs-in-abs-doc
Apr 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
labels
Apr 20, 2024
This comment has been minimized.
This comment has been minimized.
gurry
force-pushed
the
124152-suggest-unsigned-abs-in-abs-doc
branch
from
April 20, 2024 04:54
a0d37d4
to
02ac46c
Compare
@bors r+ rollup |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 20, 2024
RalfJung
reviewed
Apr 21, 2024
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 21, 2024
…llaumeGomez Rollup of 4 pull requests Successful merges: - rust-lang#124069 (enable clippy for bootstrap on CI PRs (in `mingw-check` image)) - rust-lang#124089 (Fix watchOS and visionOS for pread64 and pwrite64 calls) - rust-lang#124184 (Suggest using `unsigned_abs` in `abs` documentation) - rust-lang#124198 (Flip spans for precise capturing syntax not capturing a ty/const param, and for implicit captures of lifetime params) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 21, 2024
Rollup merge of rust-lang#124184 - gurry:124152-suggest-unsigned-abs-in-abs-doc, r=jhpratt Suggest using `unsigned_abs` in `abs` documentation Fixes rust-lang#124152
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Apr 22, 2024
Add comma at one place in `abs()` documentation As suggested by `@RalfJung` here: rust-lang#124184 (comment)
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Apr 22, 2024
Add comma at one place in `abs()` documentation As suggested by ``@RalfJung`` here: rust-lang#124184 (comment)
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 22, 2024
Rollup merge of rust-lang#124246 - gurry:add-comma-in-abs-doc, r=jhpratt Add comma at one place in `abs()` documentation As suggested by ``@RalfJung`` here: rust-lang#124184 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #124152