Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest using unsigned_abs in abs documentation #124184

Merged
merged 1 commit into from
Apr 21, 2024

Conversation

gurry
Copy link
Contributor

@gurry gurry commented Apr 20, 2024

Fixes #124152

@rustbot
Copy link
Collaborator

rustbot commented Apr 20, 2024

r? @joboet

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 20, 2024
@rust-log-analyzer

This comment has been minimized.

@gurry gurry force-pushed the 124152-suggest-unsigned-abs-in-abs-doc branch from a0d37d4 to 02ac46c Compare April 20, 2024 04:54
@jhpratt
Copy link
Member

jhpratt commented Apr 20, 2024

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 20, 2024

📌 Commit 02ac46c has been approved by jhpratt

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 20, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 21, 2024
…llaumeGomez

Rollup of 4 pull requests

Successful merges:

 - rust-lang#124069 (enable clippy for bootstrap on CI PRs (in `mingw-check` image))
 - rust-lang#124089 (Fix watchOS and visionOS for pread64 and pwrite64 calls)
 - rust-lang#124184 (Suggest using `unsigned_abs` in `abs` documentation)
 - rust-lang#124198 (Flip spans for precise capturing syntax not capturing a ty/const param, and for implicit captures of lifetime params)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 24b8c54 into rust-lang:master Apr 21, 2024
12 checks passed
@rustbot rustbot added this to the 1.79.0 milestone Apr 21, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 21, 2024
Rollup merge of rust-lang#124184 - gurry:124152-suggest-unsigned-abs-in-abs-doc, r=jhpratt

Suggest using `unsigned_abs` in `abs` documentation

Fixes rust-lang#124152
@gurry gurry deleted the 124152-suggest-unsigned-abs-in-abs-doc branch April 22, 2024 01:54
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 22, 2024
Add comma at one place in `abs()` documentation

As suggested  by `@RalfJung` here: rust-lang#124184 (comment)
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 22, 2024
Add comma at one place in `abs()` documentation

As suggested  by ``@RalfJung`` here: rust-lang#124184 (comment)
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 22, 2024
Rollup merge of rust-lang#124246 - gurry:add-comma-in-abs-doc, r=jhpratt

Add comma at one place in `abs()` documentation

As suggested  by ``@RalfJung`` here: rust-lang#124184 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation for abs() on signed integers doesn't mention unsigned_abs()
7 participants