Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak consts_may_unify #124610

Merged
merged 1 commit into from
May 3, 2024
Merged

Tweak consts_may_unify #124610

merged 1 commit into from
May 3, 2024

Conversation

nnethercote
Copy link
Contributor

@nnethercote nnethercote commented May 2, 2024 •
edited
Loading

r? @lcnr

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 2, 2024
@nnethercote
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 2, 2024
@bors
Copy link
Contributor

bors commented May 2, 2024

⌛ Trying commit e0fd8dd with merge 1e6d65e...

bors added a commit to rust-lang-ci/rust that referenced this pull request May 2, 2024
@bors
Auto merge of rust-lang#124610 - nnethercote:typenum, r=<try>
1e6d65e 
Speed up fast rejection

r? `@ghost`
@bors
Copy link
Contributor

bors commented May 2, 2024

☀️ Try build successful - checks-actions
Build commit: 1e6d65e (1e6d65e2c049b264915cd4c7075d2b43547f6536)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (1e6d65e): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.8% [-0.8%, -0.8%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 671.059s -> 673.653s (0.39%)
Artifact size: 315.99 MiB -> 316.00 MiB (0.00%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 2, 2024
@nnethercote
Copy link
Contributor Author

Interesting: this was a win locally on typenum and bitmaps, but maybe PGO already does this inlining for us.

@nnethercote nnethercote closed this May 2, 2024
@nnethercote nnethercote reopened this May 2, 2024
@nnethercote
Copy link
Contributor Author

I was hoping for a speed win, which didn't happen. But this small cleanup is probably still worth merging.

@nnethercote
Copy link
Contributor Author

@bors rollup

@nnethercote nnethercote changed the title Speed up fast rejection Tweak consts_may_unify May 2, 2024
@nnethercote
Tweak consts_may_unify.
3722eb0 
`ConstKind::Value` is the only variant where control flow leaves the
first match on `impl_ct.kind()`, so there is no need for a second match
on the same expression later on.
@lcnr
Copy link
Contributor

lcnr commented May 2, 2024

yeah, it's an improvement even when ignoring perf 👍

@bors r+

@bors
Copy link
Contributor

bors commented May 2, 2024

📌 Commit 3722eb0 has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 2, 2024
fmease added a commit to fmease/rust that referenced this pull request May 3, 2024
@fmease
Rollup merge of rust-lang#124610 - nnethercote:typenum, r=lcnr
de2572d 
Tweak `consts_may_unify`

r? `@lcnr`
@fmease fmease mentioned this pull request May 3, 2024
Closed
fmease added a commit to fmease/rust that referenced this pull request May 3, 2024
@fmease
Rollup merge of rust-lang#124610 - nnethercote:typenum, r=lcnr
dc76e67 
Tweak `consts_may_unify`

r? ``@lcnr``
@fmease fmease mentioned this pull request May 3, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request May 3, 2024
@bors
Auto merge of rust-lang#124643 - fmease:rollup-esmkgxo, r=fmease
1d64561 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#124412 (io safety: update Unix explanation to use `Arc`)
 - rust-lang#124441 (String.truncate comment microfix (greater or equal))
 - rust-lang#124594 (run-make-support: preserve tooks.mk behavior for EXTRACXXFLAGS)
 - rust-lang#124604 (library/std: Remove unused `gimli-symbolize` feature)
 - rust-lang#124607 (`rustc_expand` cleanups)
 - rust-lang#124609 (variable-precision float operations can differ depending on optimization levels)
 - rust-lang#124610 (Tweak `consts_may_unify`)
 - rust-lang#124612 (Add support for inputing via stdin with run-make-support)

r? `@ghost`
`@rustbot` modify labels: rollup
fmease added a commit to fmease/rust that referenced this pull request May 3, 2024
@fmease
Rollup merge of rust-lang#124610 - nnethercote:typenum, r=lcnr
e1a172e 
Tweak `consts_may_unify`

r? ```@lcnr```
@fmease fmease mentioned this pull request May 3, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request May 3, 2024
@bors
Auto merge of rust-lang#124645 - fmease:rollup-cp1aaaj, r=fmease
13c92e5 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#124441 (String.truncate comment microfix (greater or equal))
 - rust-lang#124594 (run-make-support: preserve tooks.mk behavior for EXTRACXXFLAGS)
 - rust-lang#124604 (library/std: Remove unused `gimli-symbolize` feature)
 - rust-lang#124607 (`rustc_expand` cleanups)
 - rust-lang#124609 (variable-precision float operations can differ depending on optimization levels)
 - rust-lang#124610 (Tweak `consts_may_unify`)
 - rust-lang#124637 (AST pretty: Use `builtin_syntax` for type ascription)

Failed merges:

 - rust-lang#124638 (Move some tests from `rustc_expand` to `rustc_parse`.)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr matthiaskrgr mentioned this pull request May 3, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 3, 2024
@bors
Auto merge of rust-lang#124646 - matthiaskrgr:rollup-crlsvg5, r=matth…
561b5de 
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#123480 (deref patterns: impl `DerefPure` for more std types)
 - rust-lang#124412 (io safety: update Unix explanation to use `Arc`)
 - rust-lang#124441 (String.truncate comment microfix (greater or equal))
 - rust-lang#124594 (run-make-support: preserve tooks.mk behavior for EXTRACXXFLAGS)
 - rust-lang#124604 (library/std: Remove unused `gimli-symbolize` feature)
 - rust-lang#124607 (`rustc_expand` cleanups)
 - rust-lang#124609 (variable-precision float operations can differ depending on optimization levels)
 - rust-lang#124610 (Tweak `consts_may_unify`)
 - rust-lang#124626 (const_eval_select: add tracking issue)
 - rust-lang#124637 (AST pretty: Use `builtin_syntax` for type ascription)

Failed merges:

 - rust-lang#124638 (Move some tests from `rustc_expand` to `rustc_parse`.)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a9edd38 into rust-lang:master May 3, 2024
6 checks passed
@rustbot rustbot added this to the 1.80.0 milestone May 3, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 3, 2024
@rust-timer
Unrolled build for rust-lang#124610
98060df 
Rollup merge of rust-lang#124610 - nnethercote:typenum, r=lcnr

Tweak `consts_may_unify`

r? ````@lcnr````
@nnethercote nnethercote deleted the typenum branch May 5, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lcnr lcnr

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.80.0
Development

Successfully merging this pull request may close these issues.
5 participants
@nnethercote @rust-timer @bors @lcnr @rustbot