Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move some tests from rustc_expand to rustc_parse. #124638

Merged
merged 1 commit into from
May 6, 2024

Commits on May 5, 2024

  1. Move some tests from rustc_expand to rustc_parse.

    There are some test cases involving `parse` and `tokenstream` and
    `mut_visit` that are located in `rustc_expand`. Because it used to be
    the case that constructing a `ParseSess` required the involvement of
    `rustc_expand`. However, since rust-lang#64197 merged (a long time ago)
    `rust_expand` no longer needs to be involved.
    
    This commit moves the tests into `rustc_parse`. This is the optimal
    place for the `parse` tests. It's not ideal for the `tokenstream` and
    `mut_visit` tests -- they would be better in `rustc_ast` -- but they
    still rely on parsing, which is not available in `rustc_ast`. But
    `rustc_parse` is lower down in the crate graph and closer to `rustc_ast`
    than `rust_expand`, so it's still an improvement for them.
    
    The exact renaming is as follows:
    
    - rustc_expand/src/mut_visit/tests.rs -> rustc_parse/src/parser/mut_visit/tests.rs
    - rustc_expand/src/tokenstream/tests.rs -> rustc_parse/src/parser/tokenstream/tests.rs
    - rustc_expand/src/tests.rs + rustc_expand/src/parse/tests.rs ->
      compiler/rustc_parse/src/parser/tests.rs
    
    The latter two test files are combined because there's no need for them
    to be separate, and having a `rustc_parse::parser::parse` module would
    be weird. This also means some `pub(crate)`s can be removed.
    nnethercote committed May 5, 2024
    Configuration menu
    Copy the full SHA
    2acbe9c View commit details
    Browse the repository at this point in the history