-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: enable arbitrary try builds, take two #124743
Conversation
@bors treeclosed- |
@@ -136,7 +136,7 @@ def calculate_jobs(run_type: WorkflowRunType, job_data: Dict[str, Any]) -> List[ | |||
raise Exception(f"Custom job(s) `{unknown_jobs}` not found in auto jobs") | |||
|
|||
return add_base_env(name_jobs(jobs, "try"), job_data["envs"]["try"]) | |||
elif run_type is AutoRunType: | |||
elif isinstance(run_type, AutoRunType): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the bug that caused the PR to run no jobs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops.
@bors r+ rollup=never |
βοΈ Test successful - checks-actions |
Finished benchmarking commit (6f7e00a): comparison URL. Overall result: ββ regressions and improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 673.974s -> 673.446s (-0.08%) |
Fixed version of #124631, which hopefully won't completely break our CI this time π€¦ββοΈ Sorry once again. Only the last commit is new.
r? @pietroalbini