Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in ManuallyDrop's documentation #124991

Merged
merged 1 commit into from
May 11, 2024
Merged

Fix typo in ManuallyDrop's documentation #124991

merged 1 commit into from
May 11, 2024

Conversation

Infinixius
Copy link
Contributor 

- /// A wrapper to inhibit compiler from automatically calling `T`’s destructor.
+ /// A wrapper to inhibit the compiler from automatically calling `T`’s destructor.

@rustbot
Copy link
Collaborator

rustbot commented May 10, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Nilstrieb (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 10, 2024
@Noratrieb
Copy link
Member

I think the entire first sentence can be reworded to something easier to understand but this is good, you can create a new PR if you want to do more changes.
@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 11, 2024

📌 Commit 781d737 has been approved by Nilstrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 11, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request May 11, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 11, 2024
@bors
Auto merge of rust-lang#125000 - matthiaskrgr:rollup-cc9lc2y, r=matth…
be7549f 
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#124766 (std::rand: adding solaris/illumos for getrandom support.)
 - rust-lang#124818 (Update ena to 0.14.3)
 - rust-lang#124991 (Fix typo in ManuallyDrop's documentation)
 - rust-lang#124994 (Add `@saethlin` to some triagebot groups)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 0997891 into rust-lang:master May 11, 2024
6 checks passed
@rustbot rustbot added this to the 1.80.0 milestone May 11, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 11, 2024
@rust-timer
Unrolled build for rust-lang#124991
cfd6d32 
Rollup merge of rust-lang#124991 - Infinixius:patch-1, r=Nilstrieb

Fix typo in ManuallyDrop's documentation

```diff
- /// A wrapper to inhibit compiler from automatically calling `T`’s destructor.
+ /// A wrapper to inhibit the compiler from automatically calling `T`’s destructor.
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Noratrieb Noratrieb

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.80.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Infinixius @rustbot @Noratrieb @bors