Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 8 pull requests #125563

Closed
wants to merge 17 commits into from
Closed

Rollup of 8 pull requests #125563

wants to merge 17 commits into from

Commits on May 13, 2024

  1. Panic if PathBuf::set_extension would add a path separator

    This is likely never intended and potentially a security vulnerability
    if it happens.
    
    I'd guess that it's mostly literal strings that are passed to this
    function in practice, so I'm guessing this doesn't break anyone.
    
    CC rust-lang#125060
    tbu- committed May 13, 2024
    Configuration menu
    Copy the full SHA
    700b3ea View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. Configuration menu
    Copy the full SHA
    c773deb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d0b45a9 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. Add a comment

    Kobzol committed May 22, 2024
    Configuration menu
    Copy the full SHA
    ab73bb2 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2024

  1. Configuration menu
    Copy the full SHA
    09c8e39 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    24b5466 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2024

  1. Configuration menu
    Copy the full SHA
    2782123 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d7248d7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bebcb4e View commit details
    Browse the repository at this point in the history

Commits on May 26, 2024

  1. Rollup merge of rust-lang#125070 - tbu-:pr_set_extension_panic, r=jhp…

    …ratt
    
    Panic if `PathBuf::set_extension` would add a path separator
    
    This is likely never intended and potentially a security vulnerability if it happens.
    
    I'd guess that it's mostly literal strings that are passed to this function in practice, so I'm guessing this doesn't break anyone.
    
    CC rust-lang#125060
    fmease authored May 26, 2024
    Configuration menu
    Copy the full SHA
    f6e46b4 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#125307 - workingjubilee:uproot-entry-limit,…

    … r=Mark-Simulacrum
    
    tidy: stop special-casing tests/ui entry limit
    
    It is genuinely more annoying to have this error, now that this value is below the general `ENTRY_LIMIT` cap, when one is trying to clean out tests from tests/ui! This code has served its purpose well, let it rest now rather than force it to continue haunting us.
    fmease authored May 26, 2024
    Configuration menu
    Copy the full SHA
    6f729a3 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#125375 - Kobzol:triagebot-rfl-ping-group, r…

    …=Mark-Simulacrum
    
    Create a triagebot ping group for Rust for Linux
    
    Corresponding rustc-dev-guide PR [here](rust-lang/rustc-dev-guide#1984). Discussed on [Zulip](https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/Testing.20Rust.20for.20Linux.20in.20our.20CI).
    fmease authored May 26, 2024
    Configuration menu
    Copy the full SHA
    3160e75 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#125413 - lcnr:ambig-drop-region-constraints…

    …, r=compiler-errors
    
    drop region constraints for ambiguous goals
    
    See the comment in `compute_external_query_constraints`. While the underlying issue is preexisting, this fixes a bug introduced by rust-lang#125343.
    
    It slightly weakens the leak chec, even if we didn't have any test which was affected. I want to write such a test before merging this PR.
    
    r? ``@compiler-errors``
    fmease authored May 26, 2024
    Configuration menu
    Copy the full SHA
    836e30d View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#125433 - surechen:fix_125189, r=Urgau

    A small diagnostic improvement for dropping_copy_types
    
    For a value `m`  which implements `Copy` trait, `drop(m);` does nothing.
    We now suggest user to ignore it by a abstract and general note: `let _ = ...`.
    I think we can give a clearer note here: `let _ = m;`
    
    fixes rust-lang#125189
    
    <!--
    If this PR is related to an unstable feature or an otherwise tracked effort,
    please link to the relevant tracking issue here. If you don't know of a related
    tracking issue or there are none, feel free to ignore this.
    
    This PR will get automatically assigned to a reviewer. In case you would like
    a specific user to review your work, you can assign it to them by using
    
        r​? <reviewer name>
    -->
    fmease authored May 26, 2024
    Configuration menu
    Copy the full SHA
    e776f47 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#125508 - scottmcm:fix-125506, r=Nilstrieb

    Stop SRoA'ing `DynMetadata` in MIR
    
    Fixes rust-lang#125506
    fmease authored May 26, 2024
    Configuration menu
    Copy the full SHA
    54c18c3 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#125530 - SparrowLii:expand2, r=petrochenkov

    cleanup dependence of `ExtCtxt` in transcribe when macro expansion
    
    part of rust-lang#125356
    We can remove `transcribe`’s dependence on `ExtCtxt` to facilitate subsequent work (such as moving macro expansion into the incremental compilation system)
    
    r? ``@petrochenkov``
    Thanks for the reviewing!
    fmease authored May 26, 2024
    Configuration menu
    Copy the full SHA
    7e2393e View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#125544 - Urgau:check-cfg-mention-cargo-spec…

    …ific, r=Mark-Simulacrum
    
    Also mention my-self for other check-cfg docs changes
    
    This PR adds a mention for my-self for the recently added `src/doc/rustc/src/check-cfg` directory.
    
    *I had to add a second mention just for the directory since [`Path::starts_with`](https://doc.rust-lang.org/std/path/struct.Path.html#method.starts_with) as used by [triagebot](https://github.com/rust-lang/triagebot/blob/48f29f351cae774caa90f555fbbc6d0df7dce80e/src/handlers/mentions.rs#L69), matches on path components and so can never return true for a file and directory at the same time.*
    fmease authored May 26, 2024
    Configuration menu
    Copy the full SHA
    e4a79c6 View commit details
    Browse the repository at this point in the history