Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BETA] revert leak check changes #125629

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented May 27, 2024

reverts the behavior changes from #119820 to give sqlx and other affected projects another 6 weeks.

Fixes #125194 #126006

@rustbot
Copy link
Collaborator

rustbot commented May 27, 2024

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented May 27, 2024

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 27, 2024
@lcnr
Copy link
Contributor Author

lcnr commented May 27, 2024

r? @rust-lang/types

@rustbot rustbot assigned compiler-errors and unassigned jieyouxu May 27, 2024
@matthiaskrgr matthiaskrgr added the beta-nominated Nominated for backporting to the compiler in the beta channel. label May 27, 2024
@rust-log-analyzer

This comment has been minimized.

reverts the behavior changes of rust-lang#119820 to give some
additional time to `sqlx` as it is affected by this change.
@rust-cloud-vms rust-cloud-vms bot force-pushed the undo-leak-check-changes branch from 788e8fb to 62a7694 Compare May 27, 2024 19:45
@compiler-errors
Copy link
Member

compiler-errors commented May 27, 2024

r=me when it's approved, unless you think my approval is fine on its own.

@lcnr
Copy link
Contributor Author

lcnr commented May 28, 2024

cc @davidtwco @wesleywiser not sure how to handle types team backports? should we just land them without any additional input or should we also let them go through the compiler team meeting?

@wesleywiser
Copy link
Member

We typically review T-types backports during the weekly compiler team triage meeting so we can sign off on it on Thursday (unless there's some reason to approve it sooner than that).

@jackh726
Copy link
Member

(FWIW, I think the last thing we decided was that T-types can make their own backport decisions, but usually just delegate it back to T-compiler)

That being said, I don't care either way about waiting a couple days for this, or just landed this now. This is a pretty cut and dry decision imo.

@lcnr lcnr added the beta-accepted Accepted for backporting to the compiler in the beta channel. label May 31, 2024
@lcnr
Copy link
Contributor Author

lcnr commented May 31, 2024

backport approved https://rust-lang.zulipchat.com/#narrow/stream/238009-t-compiler.2Fmeetings/topic/.5Bweekly.5D.202024-05-30/near/441466538

can I just use r=compiler-errors on beta PRs 😅 haven't filed one in a while

@cuviper
Copy link
Member

cuviper commented Jun 3, 2024

can I just use r=compiler-errors on beta PRs 😅 haven't filed one in a while

Usually beta PRs are backports from master, and someone on the release team will do a pseudo-rollup of several backports at once. But if you're targeting beta only then I think it's fine for you to go ahead with a direct reviewer.

(cc @rust-lang/release in case others feel differently)

@compiler-errors
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jun 4, 2024

📌 Commit 62a7694 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 4, 2024
@cuviper
Copy link
Member

cuviper commented Jun 4, 2024

@bors rollup=never

@bors
Copy link
Contributor

bors commented Jun 4, 2024

⌛ Testing commit 62a7694 with merge 81ed1ce...

@bors
Copy link
Contributor

bors commented Jun 4, 2024

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 81ed1ce to beta...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 4, 2024
@bors bors merged commit 81ed1ce into rust-lang:beta Jun 4, 2024
11 checks passed
@rustbot rustbot added this to the 1.79.0 milestone Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants