Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove an unloaded file with syntax errors. #12564

Closed

Conversation

chris-morgan
Copy link
Member

“If it’s not in use, kill it.”

I was just going and feeding everything through rustc --pretty normal, and I guess this file isn't in use:

src/librustc/middle/typeck/infer/test.rs:104:23: 104:27 error: found `self` in ident position
src/librustc/middle/typeck/infer/test.rs:104         fn search_mod(self: &Env,
                                                                   ^~~~
src/librustc/middle/typeck/infer/test.rs:117:19: 117:23 error: found `self` in ident position
src/librustc/middle/typeck/infer/test.rs:117         fn search(self: &Env,
                                                               ^~~~
src/librustc/middle/typeck/infer/test.rs:182:45: 182:46 error: expected one of `;`, `}` but found `:`
src/librustc/middle/typeck/infer/test.rs:182         let inputs = input_tys.map(|t| {mode: ast::expl(ast::by_copy),
                                                                                         ^

cc @nikomatsakis

“If it’s not in use, kill it.”
@nikomatsakis
Copy link
Contributor

On Tue, Feb 25, 2014 at 11:05:03PM -0800, Chris Morgan wrote:

“If it’s not in use, kill it.”

That...used to work. I guess it somehow never got linked into the
module! I'd rather fix it than remove it. @pnkfelix did you encounter
this? :)

@chris-morgan
Copy link
Member Author

Certainly fixing it is a reasonable choice, and preferable if the file is salvageable. I just submitted this PR as a convenient way of reporting it—removing it is nice and easy and it let me get on with my test of pretty printing all the Rust code from the Rust repository to find and fix bugs in the pretty printer.

(The Travis CI build failure is spurious, by the way.)

@pnkfelix
Copy link
Member

@nikomatsakis yeah I tried using it, found it didn't work, and said "oh well, niko must have been using this while the code was under development."

I can probably fix it.

@alexcrichton
Copy link
Member

Sounds like this file needs to be salvaged. I have opened #12585 on this topic.

bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 25, 2022
internal: Collapse completion ctx path `qualifier` and `is_absolute_path` into enum
flip1995 pushed a commit to flip1995/rust that referenced this pull request Apr 18, 2024
…-12564, r=dswij

[`manual_unwrap_or_default`]: Check for Default trait implementation in initial condition when linting and use `IfLetOrMatch`

Fixes rust-lang#12564

changelog: Fix [`manual_unwrap_or_default`] false positive when initial `match`/`if let` condition doesn't implement `Default` but the return type does.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants