Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 4 pull requests #125644

Closed
wants to merge 25 commits into from

Commits on May 23, 2024

  1. create libcxx-version tool for getting currently used libcxx version

    Signed-off-by: onur-ozkan <work@onurozkan.dev>
    onur-ozkan committed May 23, 2024
    Configuration menu
    Copy the full SHA
    3dc4fff View commit details
    Browse the repository at this point in the history
  2. check host's libstdc++ version when using ci llvm

    Signed-off-by: onur-ozkan <work@onurozkan.dev>
    onur-ozkan committed May 23, 2024
    Configuration menu
    Copy the full SHA
    c5755fa View commit details
    Browse the repository at this point in the history
  3. register libcxx-version in triagebot

    Signed-off-by: onur-ozkan <work@onurozkan.dev>
    onur-ozkan committed May 23, 2024
    Configuration menu
    Copy the full SHA
    52d9f85 View commit details
    Browse the repository at this point in the history
  4. skip src/tools/libcxx-version from tidy

    Signed-off-by: onur-ozkan <work@onurozkan.dev>
    onur-ozkan committed May 23, 2024
    Configuration menu
    Copy the full SHA
    480670e View commit details
    Browse the repository at this point in the history

Commits on May 25, 2024

  1. Stabilise ip_bits feature

    clarfonthey committed May 25, 2024
    Configuration menu
    Copy the full SHA
    0d42cf7 View commit details
    Browse the repository at this point in the history

Commits on May 27, 2024

  1. Configuration menu
    Copy the full SHA
    5ad4ad7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    06c6a2d View commit details
    Browse the repository at this point in the history
  3. non_local_defs: improve some notes around trait, bounds, consts

     - Restrict const-anon exception diag to relevant places
     - Invoke bounds (and type-inference) in non_local_defs
     - Specialize diagnostic for impl without Trait
    Urgau committed May 27, 2024
    Configuration menu
    Copy the full SHA
    de1c122 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    26b873d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    22095fb View commit details
    Browse the repository at this point in the history
  6. non_local_defs: improve exception note for impl and macro_rules!

     - Remove wrong exception text for non-local macro_rules!
     - Simplify anonymous const exception note
    Urgau committed May 27, 2024
    Configuration menu
    Copy the full SHA
    402580b View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    d3dfe14 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    ab23fd8 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    b719529 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    98273ec View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    c7d3004 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2024

  1. add debug_assert to alias-relate

    lcnr committed May 28, 2024
    Configuration menu
    Copy the full SHA
    87599dd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4d5a9bc View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    13ce229 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    98bfd54 View commit details
    Browse the repository at this point in the history
  5. add FIXME on libcxx check

    Signed-off-by: onur-ozkan <work@onurozkan.dev>
    onur-ozkan committed May 28, 2024
    Configuration menu
    Copy the full SHA
    dd24a11 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#125089 - Urgau:non_local_def-suggestions, r…

    …=estebank
    
    Improve diagnostic output the `non_local_definitions` lint
    
    This PR improves (or at least tries to improve) the diagnostic output the `non_local_definitions` lint, by simplifying the wording, by adding a "sort of" explanation of bounds interaction that leak the impl...
    
    This PR is best reviewed commit by commit and is voluntarily made a bit vague as to have a starting point to improve on.
    
    Related to https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/non_local_defs.20wording.20improvements
    
    Fixes rust-lang#125068
    Fixes rust-lang#124396
    cc ``@workingjubilee``
    r? ``@estebank``
    workingjubilee authored May 28, 2024
    Configuration menu
    Copy the full SHA
    636b26e View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#125343 - lcnr:eagerly-normalize-added-goals…

    …, r=compiler-errors
    
    `-Znext-solver`: eagerly normalize when adding goals
    
    fixes rust-lang#125269. I am not totally with this fix and going to keep this open until we have a more general discussion about how to handle hangs caused by lazy norm in the new solver.
    workingjubilee authored May 28, 2024
    Configuration menu
    Copy the full SHA
    d0b4316 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#125411 - onur-ozkan:sanity-check-libstdc++,…

    … r=Mark-Simulacrum
    
    check host's libstdc++ version when using ci llvm
    
    If the host's libstdc++ version is too old using ci-llvm may result in an ABI mismatch between the local libstdc++ and libLLVM.so. This PR adds a sanity check to immediately fail at the beginning of the bootstrap before starting the actual build. I am not sure if '8' is the best threshold, but it should be a good start and we can increase it anytime if needed.
    
    Fixes rust-lang#123037
    workingjubilee authored May 28, 2024
    Configuration menu
    Copy the full SHA
    0e1aaa0 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#125551 - clarfonthey:ip-bits, r=jhpratt

    Stabilise `IpvNAddr::{BITS, to_bits, from_bits}` (`ip_bits`)
    
    This completed FCP in rust-lang#113744. (Closes rust-lang#113744.)
    
    Stabilises the following APIs:
    
    ```rust
    impl Ipv4Addr {
        pub const BITS: u32 = 32;
        pub const fn from_bits(bits: u32) -> Ipv4Addr;
        pub const fn to_bits(self) -> u32;
    }
    
    impl Ipv6Addr {
        pub const BITS: u32 = 128;
        pub const fn from_bits(bits: u128) -> Ipv4Addr;
        pub const fn to_bits(self) -> u128;
    }
    ```
    workingjubilee authored May 28, 2024
    Configuration menu
    Copy the full SHA
    6ba7807 View commit details
    Browse the repository at this point in the history