-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 5 pull requests #125665
Rollup of 5 pull requests #125665
Commits on May 10, 2024
-
NVPTX: Avoid PassMode::Direct for args in C abi
Kjetil Kjeka committedMay 10, 2024 Configuration menu - View commit details
-
Copy full SHA for ead02ba - Browse repository at this point
Copy the full SHA ead02baView commit details
Commits on May 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f63931b - Browse repository at this point
Copy the full SHA f63931bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 19cfe8d - Browse repository at this point
Copy the full SHA 19cfe8dView commit details
Commits on May 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f931290 - Browse repository at this point
Copy the full SHA f931290View commit details
Commits on May 28, 2024
-
This comment -- "by default we ignore everything in the repository" -- was added in rust-lang#65939 when rustfmt was first being introduced for this repository and (briefly) every directory was ignored. Since then lots of directories have opted in to formatting, so it is no longer true.
Configuration menu - View commit details
-
Copy full SHA for bcfa67d - Browse repository at this point
Copy the full SHA bcfa67dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5673337 - Browse repository at this point
Copy the full SHA 5673337View commit details -
Configuration menu - View commit details
-
Copy full SHA for 404d47e - Browse repository at this point
Copy the full SHA 404d47eView commit details -
Some are too long, some aren't complete sentences, some are complete sentences but don't bother with an upper case letter at the start. All annoying and hurt readability.
Configuration menu - View commit details
-
Copy full SHA for 4702a1c - Browse repository at this point
Copy the full SHA 4702a1cView commit details -
Don't format
tests/run-make/*/rmake.rs
.It's reasonable to want to, but in the current implementation this causes multiple problems. - All the `rmake.rs` files are formatted every time even when they haven't changed. This is because they get whitelisted unconditionally in the `OverrideBuilder`, before the changed files get added. - The way `OverrideBuilder` works, if any files gets whitelisted then no unmentioned files will get traversed. This is surprising, and means that the `rmake.rs` entries broke the use of explicit paths to `x fmt`, and also broke `GITHUB_ACTIONS=true git check --fmt`. The commit removes the `rmake.rs` entries, fixes the formatting of a couple of files that were misformatted (not previously caught due to the `GITHUB_ACTIONS` breakage), and bans `!`-prefixed entries in `rustfmt.toml` because they cause all these problems.
Configuration menu - View commit details
-
Copy full SHA for f1b0ca0 - Browse repository at this point
Copy the full SHA f1b0ca0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 50a5da1 - Browse repository at this point
Copy the full SHA 50a5da1View commit details -
Configuration menu - View commit details
-
Copy full SHA for f494036 - Browse repository at this point
Copy the full SHA f494036View commit details -
Rollup merge of rust-lang#117671 - kjetilkjeka:nvptx_c_abi_avoid_dire…
…ct, r=davidtwco NVPTX: Avoid PassMode::Direct for args in C abi Fixes rust-lang#117480 I must admit that I'm confused about `PassMode` altogether, is there a good sum-up threads for this anywhere? I'm especially confused about how "indirect" and "byval" goes together. To me it seems like "indirect" basically means "use a indirection through a pointer", while "byval" basically means "do not use indirection through a pointer". The return used to keep `PassMode::Direct` for small aggregates. It turns out that `make_indirect` messes up the tests and one way to fix it is to keep `PassMode::Direct` for all aggregates. I have mostly seen this PassMode mentioned for args. Is it also a problem for returns? When experimenting with `byval` as an alternative i ran into [this assert](https://github.com/rust-lang/rust/blob/61a3eea8043cc1c7a09c2adda884e27ffa8a1172/compiler/rustc_codegen_llvm/src/abi.rs#L463C22-L463C22) I have added tests for the same kind of types that is already tested for the "ptx-kernel" abi. The tests cannot be enabled until something like rust-lang#117458 is completed and merged. CC: ``@RalfJung`` since you seem to be the expert on this and have already helped me out tremendously CC: ``@RDambrosio016`` in case this influence your work on `rustc_codegen_nvvm` ``@rustbot`` label +O-NVPTX
Configuration menu - View commit details
-
Copy full SHA for 713c852 - Browse repository at this point
Copy the full SHA 713c852View commit details -
Rollup merge of rust-lang#125573 - GuillaumeGomez:migrate-allow-warni…
…ngs-cmdline-stability, r=jieyouxu Migrate `run-make/allow-warnings-cmdline-stability` to `rmake.rs` Part of rust-lang#121876. r? ``@jieyouxu``
Configuration menu - View commit details
-
Copy full SHA for 78b4caf - Browse repository at this point
Copy the full SHA 78b4cafView commit details -
Rollup merge of rust-lang#125590 - ChrisDenton:mingw-ci-3, r=Kobzol
Add a "Setup Python" action for github-hosted runners and remove unnecessary `CUSTOM_MINGW` environment variable The Setup Python action isn't strictly necessary ([even on Windows](rust-lang#125584)) but it is [recommend by GitHub](https://docs.github.com/en/actions/automating-builds-and-tests/building-and-testing-python#specifying-a-python-version). The `CUSTOM_MINGW` environment variable is redundant now as it's always set for mingw and always unset otherwise. try-job: x86_64-mingw try-job: x86_64-mingw try-job: dist-x86_64-msvc try-job: dist-x86_64-mingw
Configuration menu - View commit details
-
Copy full SHA for 86f6fae - Browse repository at this point
Copy the full SHA 86f6faeView commit details -
Rollup merge of rust-lang#125598 - compiler-errors:proof-tree-builder…
…, r=lcnr Make `ProofTreeBuilder` actually generic over `Interner` Self-explanatory. Also renamed `ecx.tcx()` to `ecx.interner()`. r? lcnr
Configuration menu - View commit details
-
Copy full SHA for de2bf36 - Browse repository at this point
Copy the full SHA de2bf36View commit details -
Rollup merge of rust-lang#125637 - nnethercote:rustfmt-fixes, r=Guill…
…aumeGomez rustfmt fixes The `rmake.rs` entries in `rustfmt.toml` are causing major problems for `x fmt`. This PR removes them and does some minor related cleanups. r? ``@GuillaumeGomez``
Configuration menu - View commit details
-
Copy full SHA for faabc74 - Browse repository at this point
Copy the full SHA faabc74View commit details