Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 5 pull requests #125812

Closed
wants to merge 12 commits into from

Commits on May 28, 2024

  1. Configuration menu
    Copy the full SHA
    077a821 View commit details
    Browse the repository at this point in the history
  2. Make drop-use fact collection simpler for polonius

    This shunts all the complexity of siphoning off the drop-use facts
    into `LivenessResults::add_extra_drop_facts()`, which may or may
    not be a good approach.
    amandasystems committed May 28, 2024
    Configuration menu
    Copy the full SHA
    e155646 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8066ebc View commit details
    Browse the repository at this point in the history

Commits on May 30, 2024

  1. Configuration menu
    Copy the full SHA
    dabd05b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fa563c1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    20174e6 View commit details
    Browse the repository at this point in the history
  4. coverage: Instrument the RHS value of lazy logical operators

    When a lazy logical operator (`&&` or `||`) occurs outside of an `if`
    condition, it normally doesn't have any associated control-flow branch, so we
    don't have an existing way to track whether it was true or false.
    
    This patch adds special code to handle this case, by inserting extra MIR blocks
    in a diamond shape after evaluating the RHS. This gives us a place to insert
    the appropriate marker statements, which can then be given their own counters.
    Zalathar committed May 30, 2024
    Configuration menu
    Copy the full SHA
    35a8746 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2024

  1. Also InstSimplify &raw*

    We do this for `&*` and `&mut*` already; might as well do it for raw pointers too.
    scottmcm committed May 31, 2024
    Configuration menu
    Copy the full SHA
    4b96e44 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#125652 - amandasystems:you-dropped-somethin…

    …g, r=oli-obk
    
    Revert propagation of drop-live information from Polonius
    
    rust-lang#64749 introduced a flow of drop-use data from Polonius to `LivenessResults::add_extra_drop_facts()`, which makes `LivenessResults` agree with Polonius on liveness in the presence of free regions that may be dropped. Later changes accidentally removed this flow. This PR restores it.
    matthiaskrgr authored May 31, 2024
    Configuration menu
    Copy the full SHA
    e4c4d67 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#125730 - mu001999-contrib:clippy-fix, r=oli…

    …-obk
    
    Apply `x clippy --fix` and `x fmt` on Rustc
    
    <!--
    If this PR is related to an unstable feature or an otherwise tracked effort,
    please link to the relevant tracking issue here. If you don't know of a related
    tracking issue or there are none, feel free to ignore this.
    
    This PR will get automatically assigned to a reviewer. In case you would like
    a specific user to review your work, you can assign it to them by using
    
        r​? <reviewer name>
    -->
    
    Just run `x clippy --fix` and `x fmt`, and remove some changes like `impl Default`.
    matthiaskrgr authored May 31, 2024
    Configuration menu
    Copy the full SHA
    ceb4227 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#125756 - Zalathar:branch-on-bool, r=oli-obk

    coverage: Optionally instrument the RHS of lazy logical operators
    
    (This is an updated version of rust-lang#124644 and rust-lang#124402. Fixes rust-lang#124120.)
    
    When `||` or `&&` is used outside of a branching context (such as the condition of an `if`), the rightmost value does not directly influence any branching decision, so branch coverage instrumentation does not treat it as its own true-or-false branch.
    
    That is a correct and useful interpretation of “branch coverage”, but might be undesirable in some contexts, as described at rust-lang#124120. This PR therefore adds a new coverage level `-Zcoverage-options=condition` that behaves like branch coverage, but also adds additional branch instrumentation to the right-hand-side of lazy boolean operators.
    
    ---
    
    As discussed at rust-lang#124120 (comment), this is mainly intended as an intermediate step towards fully-featured MC/DC instrumentation. It's likely that we'll eventually want to remove this coverage level (rather than stabilize it), either because it has been incorporated into MC/DC instrumentation, or because it's getting in the way of future MC/DC work. The main appeal of landing it now is so that work on tracking conditions can proceed concurrently with other MC/DC-related work.
    
    `@rustbot` label +A-code-coverage
    matthiaskrgr authored May 31, 2024
    Configuration menu
    Copy the full SHA
    a71494c View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#125796 - scottmcm:more-inst-simplify, r=oli…

    …-obk
    
    Also InstSimplify `&raw*`
    
    We do this for `&*` and `&mut*` already; might as well do it for raw pointers too.
    
    r? mir-opt
    matthiaskrgr authored May 31, 2024
    Configuration menu
    Copy the full SHA
    87e49c0 View commit details
    Browse the repository at this point in the history