-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustc_span: Add conveniences for working with span formats #125829
Conversation
rustbot has assigned @michaelwoerister. Use |
This code is hot so if |
This comment has been minimized.
This comment has been minimized.
rustc_span: Add conveniences for working with span formats Also - Centralize span ctxt updates in `Span::update_ctxt` - Stop requiring inline and interned ctxts in partially interned format to be synchronized. This is the refactoring part of rust-lang#125017.
cc @nnethercote |
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (0218d5e): comparison URL. Overall result: ❌ regressions - ACTION NEEDEDBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @bors rollup=never Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)Results (primary -1.3%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (primary -0.1%, secondary 2.7%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 672.771s -> 665.847s (-1.03%) |
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
rustc_span: Add conveniences for working with span formats Also - Centralize span ctxt updates in `Span::update_ctxt` - Stop requiring inline and interned ctxts in partially interned format to be synchronized. This is the refactoring part of rust-lang#125017.
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (225796f): comparison URL. Overall result: ❌ regressions - ACTION NEEDEDBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @bors rollup=never Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)Results (primary -2.0%, secondary 3.9%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (primary 1.2%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 667.702s -> 670.737s (0.45%) |
The job Click to see the possible cause of the failure (guessed by this bot)
|
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (cf4be1f): comparison URL. Overall result: ❌ regressions - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)Results (primary -0.5%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (primary 2.2%, secondary 2.9%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 671.147s -> 671.409s (0.04%) |
Hmm, the tt-muncher improvement from the previous run (#125829 (comment)) is gone, but at least it's neutral overall. |
@bors r+ |
@bors rollup=maybe |
…rister rustc_span: Add conveniences for working with span formats This is the refactoring part of rust-lang#125017.
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#125722 (Indicate in `non_local_defs` lint that the macro needs to change) - rust-lang#125829 (rustc_span: Add conveniences for working with span formats) - rust-lang#126128 (Consistently use subtyping in method resolution) - rust-lang#126192 (Various Redox OS fixes and add i686 Redox OS target) - rust-lang#126352 (ci: Update centos:7 to use vault repos) - rust-lang#126354 (Use `Variance` glob imported variants everywhere) - rust-lang#126469 (MIR Shl/Shr: the offset can be computed with rem_euclid) - rust-lang#126472 (build `libcxx-version` only when it doesn't exist) r? `@ghost` `@rustbot` modify labels: rollup
…rister rustc_span: Add conveniences for working with span formats This is the refactoring part of rust-lang#125017.
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#125722 (Indicate in `non_local_defs` lint that the macro needs to change) - rust-lang#125829 (rustc_span: Add conveniences for working with span formats) - rust-lang#126192 (Various Redox OS fixes and add i686 Redox OS target) - rust-lang#126352 (ci: Update centos:7 to use vault repos) - rust-lang#126354 (Use `Variance` glob imported variants everywhere) - rust-lang#126469 (MIR Shl/Shr: the offset can be computed with rem_euclid) - rust-lang#126472 (build `libcxx-version` only when it doesn't exist) - rust-lang#126476 (Fix running bootstrap tests with a local Rust toolchain as the stage0) r? `@ghost` `@rustbot` modify labels: rollup
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#125722 (Indicate in `non_local_defs` lint that the macro needs to change) - rust-lang#125829 (rustc_span: Add conveniences for working with span formats) - rust-lang#126192 (Various Redox OS fixes and add i686 Redox OS target) - rust-lang#126352 (ci: Update centos:7 to use vault repos) - rust-lang#126354 (Use `Variance` glob imported variants everywhere) - rust-lang#126469 (MIR Shl/Shr: the offset can be computed with rem_euclid) - rust-lang#126472 (build `libcxx-version` only when it doesn't exist) - rust-lang#126476 (Fix running bootstrap tests with a local Rust toolchain as the stage0) r? `@ghost` `@rustbot` modify labels: rollup
…rister rustc_span: Add conveniences for working with span formats This is the refactoring part of rust-lang#125017.
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#125722 (Indicate in `non_local_defs` lint that the macro needs to change) - rust-lang#125829 (rustc_span: Add conveniences for working with span formats) - rust-lang#126192 (Various Redox OS fixes and add i686 Redox OS target) - rust-lang#126352 (ci: Update centos:7 to use vault repos) - rust-lang#126354 (Use `Variance` glob imported variants everywhere) - rust-lang#126469 (MIR Shl/Shr: the offset can be computed with rem_euclid) - rust-lang#126472 (build `libcxx-version` only when it doesn't exist) r? `@ghost` `@rustbot` modify labels: rollup
…rister rustc_span: Add conveniences for working with span formats This is the refactoring part of rust-lang#125017.
…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#125829 (rustc_span: Add conveniences for working with span formats) - rust-lang#126279 (Migrate `inaccessible-temp-dir`, `output-with-hyphens` and `issue-10971-temps-dir` `run-make` tests to `rmake`) - rust-lang#126361 (Unify intrinsics body handling in StableMIR) - rust-lang#126417 (Add `f16` and `f128` inline ASM support for `x86` and `x86-64`) - rust-lang#126424 ( Also sort `crt-static` in `--print target-features` output) - rust-lang#126428 (Polish `std::path::absolute` documentation.) - rust-lang#126429 (Add `f16` and `f128` const eval for binary and unary operationations) - rust-lang#126448 (End support for Python 3.8 in tidy) - rust-lang#126488 (Use `std::path::absolute` in bootstrap) - rust-lang#126511 (.mailmap: Associate both my work and my private email with me) r? `@ghost` `@rustbot` modify labels: rollup
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#125829 (rustc_span: Add conveniences for working with span formats) - rust-lang#126361 (Unify intrinsics body handling in StableMIR) - rust-lang#126417 (Add `f16` and `f128` inline ASM support for `x86` and `x86-64`) - rust-lang#126424 ( Also sort `crt-static` in `--print target-features` output) - rust-lang#126428 (Polish `std::path::absolute` documentation.) - rust-lang#126429 (Add `f16` and `f128` const eval for binary and unary operationations) - rust-lang#126448 (End support for Python 3.8 in tidy) - rust-lang#126488 (Use `std::path::absolute` in bootstrap) - rust-lang#126511 (.mailmap: Associate both my work and my private email with me) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#125829 - petrochenkov:upctxt2, r=michaelwoerister rustc_span: Add conveniences for working with span formats This is the refactoring part of rust-lang#125017.
rustc_span: Inline some hot functions Found while benchmarking rust-lang/rust#125829.
This is the refactoring part of #125017.