-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 6 pull requests #125857
Closed
Closed
Rollup of 6 pull requests #125857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test confirms that when val < base, we do not divide or multiply.
Locking 15 packages to latest compatible versions Updating cc v1.0.97 -> v1.0.98 Updating crc32fast v1.4.0 -> v1.4.2 Updating crossbeam-channel v0.5.12 -> v0.5.13 Updating crossbeam-utils v0.8.19 -> v0.8.20 Updating getrandom v0.2.14 -> v0.2.15 Updating libz-sys v1.1.16 -> v1.1.18 Updating nu-ansi-term v0.49.0 -> v0.50.0 Updating parking_lot v0.12.2 -> v0.12.3 Updating proc-macro2 v1.0.82 -> v1.0.84 Updating r-efi v4.4.0 -> v4.5.0 Updating serde v1.0.202 -> v1.0.203 Updating serde_derive v1.0.202 -> v1.0.203 Updating spanned v0.2.0 -> v0.2.1 Updating syn v2.0.64 -> v2.0.66 Updating tracing-tree v0.3.0 -> v0.3.1 note: pass `--verbose` to see 80 unchanged dependencies behind latest
Wrap overly long ones, etc.
It has a clumsy type, with repeated `&'a [LintId]`, and sometimes requires an empty string that isn't used in the `Err`+`None` case. This commit splits it into two variants.
As of rust-lang#125408 PR, rustbook now relies on dependencies from the "src/doc/book" submodule. However, bootstrap does not automatically sync this submodule before reading metadata informations. And if the submodule is not present, reading metadata will fail because rustbook's dependencies will be missing. This change makes "src/doc/book" to be fetched/synced automatically before trying to read metadata. Signed-off-by: onur-ozkan <work@onurozkan.dev>
Unroll first iteration of checked_ilog loop This follows the optimization of rust-lang#115913. As shown in rust-lang#115913 (comment), the performance was improved in all important cases, but some regressions were introduced for the benchmarks `u32_log_random_small`, `u8_log_random` and `u8_log_random_small`. Basically, rust-lang#115913 changed the implementation from one division per iteration to one multiplication per iteration plus one division. When there are zero iterations, this is a regression from zero divisions to one division. This PR avoids this by avoiding the division if we need zero iterations by returning `Some(0)` early. It also reduces the number of multiplications by one in all other cases.
…=cjgillot `rustc_lint` cleanups Minor improvements I found while looking through this code. r? `@cjgillot`
…ulacrum Weekly `cargo update` Automation to keep dependencies in `Cargo.lock` current. The following is the output from `cargo update`: ```txt Locking 15 packages to latest compatible versions Updating cc v1.0.97 -> v1.0.98 Updating crc32fast v1.4.0 -> v1.4.2 Updating crossbeam-channel v0.5.12 -> v0.5.13 Updating crossbeam-utils v0.8.19 -> v0.8.20 Updating getrandom v0.2.14 -> v0.2.15 Updating libz-sys v1.1.16 -> v1.1.18 Updating nu-ansi-term v0.49.0 -> v0.50.0 Updating parking_lot v0.12.2 -> v0.12.3 Updating proc-macro2 v1.0.82 -> v1.0.84 Updating r-efi v4.4.0 -> v4.5.0 Updating serde v1.0.202 -> v1.0.203 Updating serde_derive v1.0.202 -> v1.0.203 Updating spanned v0.2.0 -> v0.2.1 Updating syn v2.0.64 -> v2.0.66 Updating tracing-tree v0.3.0 -> v0.3.1 note: pass `--verbose` to see 80 unchanged dependencies behind latest ```
…s, r=lcnr Uplift `{Closure,Coroutine,CoroutineClosure}Args` and friends to `rustc_type_ir` Part of converting the new solver's `structural_traits.rs` to be interner-agnostic. I decided against aliasing `ClosureArgs<TyCtxt<'tcx>>` to `ClosureArgs<'tcx>` because it seemed so rare. I could do so if desired, though. r? lcnr
…t, r=jieyouxu Refactor `--print=check-cfg` test *as asked in rust-lang#125818 (comment) r? ````@jieyouxu````
…fix, r=onur-ozkan include missing submodule on bootstrap As of rust-lang#125408 PR, rustbook now relies on dependencies from the "src/doc/book" submodule. However, bootstrap does not automatically sync this submodule before reading metadata informations. And if the submodule is not present, reading metadata will fail because rustbook's dependencies will be missing. This change makes "src/doc/book" to be fetched/synced automatically before trying to read metadata. cc `@Zalathar`
rustbot
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
WG-trait-system-refactor
The Rustc Trait System Refactor Initiative (-Znext-solver)
rollup
A PR which is a rollup
labels
Jun 1, 2024
@bors r+ rollup=never p=6 |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jun 1, 2024
The job Click to see the possible cause of the failure (guessed by this bot)
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
rollup
A PR which is a rollup
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
WG-trait-system-refactor
The Rustc Trait System Refactor Initiative (-Znext-solver)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
rustc_lint
cleanups #125057 (rustc_lint
cleanups)cargo update
#125562 (Weeklycargo update
){Closure,Coroutine,CoroutineClosure}Args
and friends torustc_type_ir
#125775 (Uplift{Closure,Coroutine,CoroutineClosure}Args
and friends torustc_type_ir
)--print=check-cfg
test #125822 (Refactor--print=check-cfg
test)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup