Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coverage: Carve out hole spans in a separate early pass #125921

Merged
merged 6 commits into from
Jun 5, 2024
Merged

coverage: Carve out hole spans in a separate early pass #125921

merged 6 commits into from
Jun 5, 2024

Commits on Jun 4, 2024

  1. Add unit tests for Span::trim_start

    @Zalathar
    Zalathar committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    e609c9b View commit details
    Browse the repository at this point in the history

  2. Add Span::trim_end 

    This is the counterpart of `Span::trim_start`.
    @Zalathar
    Zalathar committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    df96cba View commit details
    Browse the repository at this point in the history

  3. coverage: Return a nested vector from initial span extraction 

    This will allow the span extractor to produce multiple separate buckets,
instead of just one flat list of spans.
    @Zalathar
    Zalathar committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    9c931c0 View commit details
    Browse the repository at this point in the history

  4. coverage: Build up initial spans by appending to a vector 

    This is less elegant than returning an iterator, but more flexible.
    @Zalathar
    Zalathar committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    464dee2 View commit details
    Browse the repository at this point in the history

  5. coverage: Use hole spans to carve up coverage spans into separate buc… 

    …kets

This performs the same task as the hole-carving code in the main span refiner,
but in a separate earlier pass.
    @Zalathar
    Zalathar committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    6d1557f View commit details
    Browse the repository at this point in the history

  6. coverage: Remove hole-carving code from the main span refiner 

    Now that hole spans are handled by a separate earlier pass, this code never
sees hole spans, and therefore doesn't need to deal with them.
    @Zalathar
    Zalathar committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    c57a1d1 View commit details
    Browse the repository at this point in the history