Stabilize order of MonoItems in CGUs and disallow query_instability lint for rustc_monomorphize

[michaelwoerister]

The HashStable impl for CodegenUnit was incorrect as described in MCP 533. This PR removes any indeterminism from the way codegen units are built. The changes are pretty straightforward.

Part of #84447 and MCP 533.

[rustbot]

r? @oli-obk

rustbot has assigned @oli-obk.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[michaelwoerister]

Let's see if anything gets slower.
@bors try @rust-timer queue

[bors]

⌛ Trying commit 6cfdc57 with merge 75cb8cd...

[bors]

☀️ Try build successful - checks-actions
Build commit: 75cb8cd (75cb8cd6107a8bc46eed7723934bad007bda03a3)

[rust-timer]

Finished benchmarking commit (75cb8cd): comparison URL.

Overall result: ❌ regressions - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.2%	[0.2%, 0.2%]	2
Regressions ❌ (secondary)	1.3%	[1.3%, 1.3%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.2%	[0.2%, 0.2%]	2

Max RSS (memory usage)

Results (primary 2.2%, secondary -3.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.2%	[0.8%, 3.6%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.5%	[-3.5%, -3.5%]	1
All ❌✅ (primary)	2.2%	[0.8%, 3.6%]	2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 667.912s -> 667.91s (-0.00%)
Artifact size: 318.98 MiB -> 318.94 MiB (-0.01%)

[oli-obk]

@bors r+

[bors]

📌 Commit 6cfdc57 has been approved by oli-obk

It is now in the queue for this repository.

[bors]

⌛ Testing commit 6cfdc57 with merge b74702f...

[bors]

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing b74702f to master...

[rust-timer]

Finished benchmarking commit (b74702f): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.2%	[0.2%, 0.2%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.3%	[-0.4%, -0.3%]	3
All ❌✅ (primary)	0.2%	[0.2%, 0.2%]	1

Max RSS (memory usage)

Results (primary -0.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.7%	[0.7%, 0.7%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.3%	[-1.3%, -1.3%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.3%	[-1.3%, 0.7%]	2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: missing data
Artifact size: 319.45 MiB -> 319.39 MiB (-0.02%)