Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 9 pull requests #125975

Closed

Commits on May 27, 2024

  1. Configuration menu
    Copy the full SHA
    d6d2ff0 View commit details
    Browse the repository at this point in the history
  2. Use let chains in pretty_printing_compatibility_hack.

    To reduce indentation and improve readability.
    nnethercote committed May 27, 2024
    Configuration menu
    Copy the full SHA
    3607cee View commit details
    Browse the repository at this point in the history
  3. Convert proc_macro_back_compat lint to an unconditional error.

    We still check for the `rental`/`allsorts-rental` crates. But now if
    they are detected we just emit a fatal error, instead of emitting a
    warning and providing alternative behaviour.
    
    The original "hack" implementing alternative behaviour was added
    in rust-lang#73345.
    
    The lint was added in rust-lang#83127.
    
    The tracking issue is rust-lang#83125.
    
    The direct motivation for the change is that providing the alternative
    behaviour is interfering with rust-lang#125174 and follow-on work.
    nnethercote committed May 27, 2024
    Configuration menu
    Copy the full SHA
    cf0c2c7 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2024

  1. Manual rustfmt

    oli-obk committed May 28, 2024
    Configuration menu
    Copy the full SHA
    6cc4b22 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b6a8863 View commit details
    Browse the repository at this point in the history
  3. Turn a delayed bug back into a normal bug by winnowing private method…

    … candidates instead of assuming any candidate of the right name will apply.
    oli-obk committed May 28, 2024
    Configuration menu
    Copy the full SHA
    7253f07 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2ba0330 View commit details
    Browse the repository at this point in the history
  5. Give test a more useful name

    oli-obk committed May 28, 2024
    Configuration menu
    Copy the full SHA
    5dfabd1 View commit details
    Browse the repository at this point in the history
  6. Add test description

    oli-obk committed May 28, 2024
    Configuration menu
    Copy the full SHA
    575c86f View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2024

  1. Configuration menu
    Copy the full SHA
    d392c50 View commit details
    Browse the repository at this point in the history
  2. chore: update src/tools/rustc-perf

    This is needed for fixing the missing license issue.
    
    See rust-lang#125465.
    weihanglo committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    e9c4eb3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9436fbe View commit details
    Browse the repository at this point in the history
  4. Update books

    rustbot committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    47053d1 View commit details
    Browse the repository at this point in the history
  5. Update fuchsia maintainers

    P1n3appl3 committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    832b8b8 View commit details
    Browse the repository at this point in the history
  6. feat(opt-dist): new flag --benchmark-cargo-config

    The flag propagates cargo configs to `rustc-perf --cargo-config`,
    which is particularly useful when the environment is air-gapped,
    and you want to use the default set of training crates vendored
    in the rustc-src tarball.
    weihanglo committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    0a11dcf View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2024

  1. bootstrap: implement new feature bootstrap-self-test

    Some of the bootstrap logics should be ignored during unit tests because they either
    make the tests take longer or cause them to fail. Therefore we need to be able to exclude
    them from the bootstrap when it's called by unit tests. This change introduces a new feature
    called `bootstrap-self-test`, which is enabled on bootstrap unit tests by default. This allows
    us to keep the logic separate between compiler builds and bootstrap tests without needing messy
    workarounds (like checking if target names match those in the unit tests).
    
    Signed-off-by: onur-ozkan <work@onurozkan.dev>
    onur-ozkan committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    8f677e8 View commit details
    Browse the repository at this point in the history
  2. Add function core::iter::chain

    The addition of `core::iter::zip` (rust-lang#82917) set a precedent for adding
    plain functions for iterator adaptors. Adding `chain` makes it a little
    easier to `chain` two iterators.
    
    ```
    for (x, y) in chain(xs, ys) {}
    // vs.
    for (x, y) in xs.into_iter().chain(ys) {}
    ```
    rossmacarthur committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    6a84995 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#106186 - rossmacarthur:ft/iter-chain, r=Ama…

    …nieu
    
    Add function `core::iter::chain`
    
    The addition of `core::iter::zip` (rust-lang#82917) set a precedent for adding plain functions for iterator adaptors. Adding `chain` makes it a little easier to `chain` two iterators.
    
    ```rust
    for (x, y) in chain(xs, ys) {}
    // vs.
    for (x, y) in xs.into_iter().chain(ys) {}
    ```
    
    There is prior art for the utility of this in [`itertools::chain`](https://docs.rs/itertools/latest/itertools/fn.chain.html).
    
    Approved ACP rust-lang/libs-team#154
    compiler-errors authored Jun 4, 2024
    Configuration menu
    Copy the full SHA
    fab2536 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#125273 - onur-ozkan:bootstrap-self-test, r=…

    …albertlarsan68
    
    bootstrap: implement new feature `bootstrap-self-test`
    
    Some of the bootstrap logics should be ignored during unit tests because they either make the tests take longer or cause them to fail. Therefore we need to be able to exclude them from the bootstrap when it's called by unit tests. This change introduces a new feature called `bootstrap-self-test`, which is enabled on bootstrap unit tests by default. This allows us to keep the logic separate between compiler builds and bootstrap tests without needing messy workarounds (like checking if target names match those in the unit tests).
    
    Also, resolves rust-lang#122090 (without having to create separate modules)
    compiler-errors authored Jun 4, 2024
    Configuration menu
    Copy the full SHA
    7525590 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#125596 - nnethercote:rental-hard-error, r=e…

    …stebank
    
    Convert `proc_macro_back_compat` lint to an unconditional error.
    
    We still check for the `rental`/`allsorts-rental` crates. But now if they are detected we just emit a fatal error, instead of emitting a warning and providing alternative behaviour.
    
    The original "hack" implementing alternative behaviour was added in rust-lang#73345.
    
    The lint was added in rust-lang#83127.
    
    The tracking issue is rust-lang#83125.
    
    The direct motivation for the change is that providing the alternative behaviour is interfering with rust-lang#125174 and follow-on work.
    
    r? `@estebank`
    compiler-errors authored Jun 4, 2024
    Configuration menu
    Copy the full SHA
    e7cbcd3 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#125622 - oli-obk:define_opaque_types15, r=c…

    …ompiler-errors
    
    Winnow private method candidates instead of assuming any candidate of the right name will apply
    
    partially reverts rust-lang#60721
    
    My original motivation was just to avoid the `delay_span_bug` (by attempting to thread the `ErrorGuaranteed` through to here). But then I realized that the error message is wrong. It refers to the `Foo<A>::foo` instead of `Foo<B>::foo`. This is almost invisible, because both functions are the same, but on different lines, so `-Zui-testing` makes it so the test is the same no matter which of these two functions is referenced.
    
    But there's a much more obvious bug: If `Foo<B>` does not have a `foo` method at all, but `Foo<A>` has a private `foo` method, then we'll refer to that one. This has now been fixed, and we report a normal `method not found` error.
    
    The way this is done is by creating a list of all possible private functions (just like we create a list of the public functions that can actually be called), and then winnowing it by analyzing where bounds and `Self` types to see if any of the found methods can actually apply (again, just like with the list of public functions).
    
    I wonder if there is room for doing the same thing with unstable functions instead of running all of method resolution twice.
    
    r? `@compiler-errors` for method resolution stuff
    compiler-errors authored Jun 4, 2024
    Configuration menu
    Copy the full SHA
    d0f37fa View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#125927 - ferrocene:lw-alloc-unwind-test, r=…

    …pietroalbini
    
    Ignore `vec_deque_alloc_error::test_shrink_to_unwind` test on non-unwind targets
    
    rust-lang#123803 added this test which requires unwinding to succeed. This conditionally ignores the test on non-unwind targets (as is the case with other tests using `catch_unwind`).
    compiler-errors authored Jun 4, 2024
    Configuration menu
    Copy the full SHA
    061c7ff View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#125930 - weihanglo:opt-dist-respect-cargo-c…

    …onfig, r=Kobzol
    
    feat(opt-dist): new flag `--benchmark-cargo-config`
    
    This should be the last piece toward self-contained `opt-dist` (I believe).
    
    The flag propagates cargo configs to `rustc-perf --cargo-config`,
    which is particularly useful when the environment is air-gapped,
    and you want to use the default set of training crates vendored
    in the rustc-src tarball.
    
    It fixes the issue described in rust-lang#125465
    
    > * The current pinned rustc-perf uses `tempfile::Tempdir` as the working
      directory when collecting profiles from some of these packages.
      This "tmp" working directory usage make it impossible for Cargo to pick
      up the correct vendor sources setting in `.cargo/config.toml` bundled
      in the rustc-src tarball. [^1]
    > [^1]: https://github.com/rust-lang/rustc-perf/blob/4f313add609f43e928e98132358e8426ed3969ae/collector/src/compile/benchmark/mod.rs#L164-L173
    
    See also
    
    * <rust-lang/rustc-perf#1913>
    * <rust-lang#125465>
    * https://rust-lang.zulipchat.com/#narrow/stream/247081-t-compiler.2Fperformance/topic/tempfile.20in.20rustc-perf.20make.20it.20hard.20to.20configure.20vendor
    
    r​? Kobzol
    compiler-errors authored Jun 4, 2024
    Configuration menu
    Copy the full SHA
    4e82d47 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#125932 - schvv31n:patch-1, r=lqd

    Fix typo in the docs of `HashMap::raw_entry_mut`
    
    <!--
    If this PR is related to an unstable feature or an otherwise tracked effort,
    please link to the relevant tracking issue here. If you don't know of a related
    tracking issue or there are none, feel free to ignore this.
    
    This PR will get automatically assigned to a reviewer. In case you would like
    a specific user to review your work, you can assign it to them by using
    
        r​? <reviewer name>
    -->
    compiler-errors authored Jun 4, 2024
    Configuration menu
    Copy the full SHA
    e5c4ee3 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#125933 - rustbot:docs-update, r=ehuss

    Update books
    
    ## rust-lang/book
    
    6 commits in 85442a608426d3667f1c9458ad457b241a36b569..5228bfac8267ad24659a81b92ec5417976b5edbc
    2024-05-29 20:55:49 UTC to 2024-05-27 17:22:03 UTC
    
    - Fix typo in ch10-03 (rust-lang/book#3539)
    - Backport changes to ch 9 and 10 (rust-lang/book#3946)
    - infra: correctly support preprocessors for nostarch (rust-lang/book#3944)
    - Use `<kbd>` instead of `<span class="keystroke">` (rust-lang/book#3945)
    - infra: Fix clippy warning in remove_markup (rust-lang/book#3943)
    - fix: ch10-03 - misleading use of expect on .split (rust-lang/book#3939)
    
    ## rust-lang/edition-guide
    
    2 commits in 0c68e90acaae5a611f8f5098a3c2980de9845ab2..bbaabbe088e21a81a0d9ae6757705020d5d7b416
    2024-05-24 19:07:18 UTC to 2024-05-21 22:40:52 UTC
    
    - 2024: Document reserving `gen` keyword (rust-lang/edition-guide#300)
    - 2024: Document cargo changes (rust-lang/edition-guide#301)
    
    ## rust-embedded/book
    
    1 commits in dd962bb82865a5284f2404e5234f1e3222b9c022..b10c6acaf0f43481f6600e95d4b5013446e29f7a
    2024-05-31 08:51:50 UTC to 2024-05-31 08:51:50 UTC
    
    - Add some explanations as to why exception re-entrancy may still be an issue in a multicore-environment. (rust-embedded/book#367)
    
    ## rust-lang/reference
    
    6 commits in e356977fceaa8591c762312d8d446769166d4b3e..6019b76f5b28938565b251bbba0bf5cc5c43d863
    2024-06-03 15:58:57 UTC to 2024-05-25 18:35:54 UTC
    
    - Add Apple `target_abi` values to the example values (rust-lang/reference#1507)
    - this needs a space (rust-lang/reference#1506)
    - Mention Variadics With No Fixed Parameter (rust-lang/reference#1494)
    - Add "scopes" chapter. (rust-lang/reference#1040)
    - update patterns.md for const pattern RFC (rust-lang/reference#1456)
    - document guarantee about evaluation of associated consts and const blocks (rust-lang/reference#1497)
    
    ## rust-lang/rust-by-example
    
    3 commits in 20482893d1a502df72f76762c97aed88854cdf81..4840dca06cadf48b305d3ce0aeafde7f80933f80
    2024-05-28 13:56:12 UTC to 2024-05-27 11:51:10 UTC
    
    - Update mdbook-i18n-helpers to 0.3.3 (rust-lang/rust-by-example#1857)
    - Fix CI failure (rust-lang/rust-by-example#1856)
    - Add precision on From/Into asymmetry to from_into.md (rust-lang/rust-by-example#1855)
    
    ## rust-lang/rustc-dev-guide
    
    4 commits in b6d4a4940bab85cc91eec70cc2e3096dd48da62d..6a7374bd87cbac0f8be4fd4877d8186d9c313985
    2024-05-31 00:27:28 UTC to 2024-05-21 09:56:12 UTC
    
    - Flesh out the "representing types" chapter (rust-lang/rustc-dev-guide#1985)
    - sync the stage0 filename (rust-lang/rustc-dev-guide#1979)
    - Add Rust for Linux notification group entry (rust-lang/rustc-dev-guide#1984)
    - fix some typos (rust-lang/rustc-dev-guide#1983)
    compiler-errors authored Jun 4, 2024
    Configuration menu
    Copy the full SHA
    c94a2fa View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#125944 - P1n3appl3:fuchsia, r=lqd

    Update fuchsia maintainers
    
    This makes the maintainers list in the docs line up with the current [fuchsia team](https://github.com/rust-lang/team/blob/master/teams/fuchsia.toml).
    compiler-errors authored Jun 4, 2024
    Configuration menu
    Copy the full SHA
    cee5d8e View commit details
    Browse the repository at this point in the history