Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autolabel run-make tests, remind to update tracking issue #126190

Merged
merged 1 commit into from
Jun 9, 2024
Merged

Autolabel run-make tests, remind to update tracking issue #126190

merged 1 commit into from
Jun 9, 2024

Conversation

jieyouxu
Copy link
Member

@jieyouxu jieyouxu commented Jun 9, 2024 •
edited
Loading

r? @Kobzol

@rustbot
Copy link
Collaborator

rustbot commented Jun 9, 2024

triagebot.toml has been modified, there may have been changes to the review queue.

cc @davidtwco, @wesleywiser

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 9, 2024
@jieyouxu jieyouxu added the A-run-make Area: port run-make Makefiles to rmake.rs label Jun 9, 2024
@Kobzol
Copy link
Contributor

Kobzol commented Jun 9, 2024

LGTM for the triagebot changes, but I'd like to ask other people if adding the new X- label is fine. @apiraino Is there any existing label template for tracking "initiatives"? Would you suggest to use a different label for this?

@jieyouxu
Copy link
Member Author

jieyouxu commented Jun 9, 2024 •
edited
Loading

FWIW, my reason for adding a X-* label (I was thinking that this could mean initiative/experimental) was that it doesn't really cleanly fit into an "area" like the A-* labels, nor is it an "official" PG/WG "initiative", nor is it an "official" T-compiler initiative/project, so it's kinda weird.

@Noratrieb
Copy link
Member

i think I'd just throw an A- at it

@jieyouxu
Copy link
Member Author

jieyouxu commented Jun 9, 2024 •
edited
Loading

Sure, I'll change the label name to just A-run-make.
EDIT: updated the autolabel to A-run-make instead of X-run-make.

@jieyouxu
Autolabel run-make tests, remind to update tracking issue
d3b1367 
- Autolabel PRs modifying `tests/run-make/` and
  `src/tools/run-make-support/` with `X-run-make` label.
- Add reminder to update the tracking issue
  <rust-lang#121876>
  if applicable when `tests/run-make/` is modified by a PR.
@apiraino
Copy link
Contributor

apiraino commented Jun 9, 2024

yeah, I agree that a A- sounds more coherent with what we have right now

thanks @jieyouxu 👍

@Noratrieb
Copy link
Member

🧙‍♀️ @bors, I hereby command you to r+. ✨

@Noratrieb
Copy link
Member

looks like bors didn't pick up on this spell.
@bors r=Nilstrieb,Kobzol

@bors
Copy link
Contributor

bors commented Jun 9, 2024

📌 Commit d3b1367 has been approved by Nilstrieb,Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 9, 2024
@jieyouxu jieyouxu mentioned this pull request Jun 9, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 9, 2024
@bors
Auto merge of rust-lang#126205 - jieyouxu:rollup-s64z5ng, r=jieyouxu
a70b2ae 
Rollup of 4 pull requests

Successful merges:

 - rust-lang#126172 (Weekly `cargo update`)
 - rust-lang#126176 (rustdoc-search: use lowercase, non-normalized name for type search)
 - rust-lang#126190 (Autolabel run-make tests, remind to update tracking issue)
 - rust-lang#126194 (Migrate more things to `WinError`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7e64393 into rust-lang:master Jun 9, 2024
6 checks passed
@rustbot rustbot added this to the 1.81.0 milestone Jun 9, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jun 9, 2024
@rust-timer
Unrolled build for rust-lang#126190
7d98394 
Rollup merge of rust-lang#126190 - jieyouxu:run-make-triagebot, r=Nilstrieb,Kobzol

Autolabel run-make tests, remind to update tracking issue

- Autolabel PRs modifying `tests/run-make/` and `src/tools/run-make-support/` with `A-run-make` label.
- Add reminder to update the tracking issue <rust-lang#121876> if applicable when `tests/run-make/` is modified by a PR.

r? `@Kobzol`
@jieyouxu jieyouxu deleted the run-make-triagebot branch June 10, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Kobzol Kobzol

Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
Oxidizing run-make tests
Status: Done
Milestone
1.81.0
Development

Successfully merging this pull request may close these issues.
6 participants
@jieyouxu @rustbot @Kobzol @Noratrieb @apiraino @bors