Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rustc-perf as a stage0 tool #126306

Closed
wants to merge 3 commits into from
Closed

Add rustc-perf as a stage0 tool #126306

wants to merge 3 commits into from

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Jun 12, 2024 •
edited
Loading

This is a first step towards integrating rustc-perf into bootstrap, to make it easier for contributors to profile and benchmark the compiler using our benchmark suite, without having to interact with rustc-perf manually (which is not exactly user friendly at the moment).

This PR just adds rustc-perf as a boostrap stage0 tool, so that it can be easily compiled with bootstrap using x build rustc-perf. After that, you can run rustc-perf from ./build/<target>/stage0-bootstrap-tools/<target>/release/collector (yes, this is annoying, hence this being just a first step :) ).

r? @onur-ozkan

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jun 12, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Kobzol Kobzol force-pushed the rustc-perf-stage0 branch from 57c8d35 to 8cf5d51 Compare June 12, 2024 08:11
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@onur-ozkan onur-ozkan added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 12, 2024
This was referenced Jun 12, 2024
Merged
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jun 12, 2024
@GuillaumeGomez
Rollup merge of rust-lang#126312 - Kobzol:update-rustc-perf, r=onur-o…
d285297 
…zkan

Update `rustc-perf` submodule

To integrate rust-lang/rustc-perf#1926, required for rust-lang#126306.

`@bors` rollup

r? `@onur-ozkan`
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jun 12, 2024
@rust-timer
Unrolled build for rust-lang#126312
5a50ec4 
Rollup merge of rust-lang#126312 - Kobzol:update-rustc-perf, r=onur-ozkan

Update `rustc-perf` submodule

To integrate rust-lang/rustc-perf#1926, required for rust-lang#126306.

`@bors` rollup

r? `@onur-ozkan`
@Kobzol Kobzol force-pushed the rustc-perf-stage0 branch from 8cf5d51 to fd44aca Compare June 12, 2024 18:25
@Kobzol Kobzol marked this pull request as ready for review June 12, 2024 18:26
@Kobzol
Copy link
Contributor Author

Kobzol commented Jun 12, 2024

Rebased on top of #126312 and fixed the Clippy error.

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 12, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Kobzol
Copy link
Contributor Author

Kobzol commented Jun 12, 2024

fmt check
fmt: checked 5061 files
tidy check
tidy: Skipping binary file check, read-only filesystem
removing old virtual environment
creating virtual environment at '/checkout/obj/build/venv' using 'python3.10'
tidy error: failed to create venv at '/checkout/obj/build/venv' using python3.10
some tidy checks failed

the heck is this

@rustbot rustbot added the A-testsuite Area: The testsuite used to check the correctness of rustc label Jun 12, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Kobzol Kobzol force-pushed the rustc-perf-stage0 branch from 3b41a98 to fd44aca Compare June 12, 2024 18:52
@Kobzol
Copy link
Contributor Author

Kobzol commented Jun 12, 2024

Ok, intermittent CI issues aside, this is now ready for a review.

@onur-ozkan
Copy link
Member

This PR alone doesn't have any purpose, isn't that right? I think we can close this in favor of #126318?

@Kobzol
Copy link
Contributor Author

Kobzol commented Jun 12, 2024 •
edited
Loading

Well, it is a pre-requisite. It has some value on its own, because it adds a command to build rustc-perf for developers, who could then use it manually. But if you want to review #126318 directly, I'll close this one and we can continue there.

@onur-ozkan
Copy link
Member

I think it's not really going to be used without the complete implementation. Let's continue on the other PR. It's easier for me to review as I will be able to see all the rustc-perf related changes together.

@Kobzol
Copy link
Contributor Author

Kobzol commented Jun 12, 2024

Ok!

@Kobzol Kobzol closed this Jun 12, 2024
@Kobzol Kobzol deleted the rustc-perf-stage0 branch June 12, 2024 19:05
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Jun 13, 2024
@GuillaumeGomez
Rollup merge of #126312 - Kobzol:update-rustc-perf, r=onur-ozkan
faed2c3 
Update `rustc-perf` submodule

To integrate rust-lang/rustc-perf#1926, required for rust-lang/rust#126306.

`@bors` rollup

r? `@onur-ozkan`
@onur-ozkan onur-ozkan removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbstj fbstj fbstj left review comments

Assignees

@onur-ozkan onur-ozkan

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Kobzol @rust-log-analyzer @onur-ozkan @fbstj @rustbot