[DO NOT MERGE] llvm-wrapper: adapt for LLVM 19 API change

[krasimirgg]

No functional changes intended.

The instrprof_mcdc_condbitmap_update intrinsic was dropped recently:

• llvm/llvm-project@85a7bba

@rustbot label: +llvm-main

[rustbot]

r? @cuviper

rustbot has assigned @cuviper.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[krasimirgg]

r? @durin42

[nikic]

Does LLVMRustGetInstrProfMCDCCondBitmapIntrinsic not get called on LLVM 19?

[durin42]

The test suite passes with this applied, so if it's a problem on LLVM 19 there's some missing test coverage I guess?

I couldn't easily prove to myself this function won't get called on LLVM 19 tho...

[nikic]

cc @ZhuUx @Zalathar who worked on MC/DC in Rust.

@durin42 Is that based on a full local test run, or the buildkite integration? Because I don't think that one runs coverage tests.

[durin42]

A full local run

…

On Tue, Jun 18, 2024, 04:24 Nikita Popov ***@***.***> wrote: cc @ZhuUx <https://github.com/ZhuUx> @Zalathar <https://github.com/Zalathar> who worked on MC/DC in Rust. @durin42 <https://github.com/durin42> Is that based on a full local test run, or the buildkite integration? Because I don't think that one runs coverage tests. — Reply to this email directly, view it on GitHub <#126582 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAE6LMDACLHFLNX3MX7R4DZH7VDJAVCNFSM6AAAAABJNUZUC6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZVGUYDKNJQGM> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[ZhuUx]

The test suite passes with this applied, so if it's a problem on LLVM 19 there's some missing test coverage I guess?

I couldn't easily prove to myself this function won't get called on LLVM 19 tho...

Which llvm commit the tests based on? I failed to compile rustc with the latest llvm 19. It breaks when compiling compiler-builtins.

We do should fix something if we're going to upgrade llvm to 19, which not only includes this api change. But I'm confused about why this patch does not panic when testing tests/coverage/mcdc_if.rs.

[ZhuUx]

Considering there are something to do on mcdc with llvm-19, if it's urgent for us to upgrade llvm-19, we can temporarily disable mcdc functions:

1. Add something like max-llvm-version to tests/coverage/mcdc_if.rs, tests/coverage/mcdc_nested_if.rs and all tests under tests/coverage/mcdc (All tests are going to move into test/coverage/mcdc but that pr is under progress)
2. Wrap all related functions in RustWrapper.cpp with LLVM_VERSION_GE(18, 0) && LLVM_VERSION_LT(19, 0).

Otherwise if there is still some time to wait I would draft a pr to fix them tomorrow.

[nikic]

@ZhuUx It's not urgent.

[krasimirgg]

OK, so this is incomplete. Filed #126672 to track the proper fix.

[bors]

☔ The latest upstream changes (presumably #123918) made this pull request unmergeable. Please resolve the merge conflicts.

[zmodem]

@krasimirgg any chance of getting a rebased version of this?

[krasimirgg]

Recreated as a fresh PR #127025

…

On Mon, Jul 1, 2024, 2:12 PM Hans ***@***.***> wrote: @krasimirgg <https://github.com/krasimirgg> any chance of getting a rebased version of this? — Reply to this email directly, view it on GitHub <#126582 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AG7S2ZWPDTYM726C5RMQRB3ZKFBS7AVCNFSM6AAAAABJNUZUC6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJZHE4DENBYGQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>