Uplift `clippy::double_neg` lint as `double_negations` #126604

kadiwa4 · 2024-06-17T18:13:33Z

Warns about cases like this:

fn main() {
    let x = 1;
    let _b = --x; //~ WARN use of a double negation
}

The intent is to keep people from thinking that --x is a prefix decrement operator. ++x, x++ and x-- are invalid expressions and already have a helpful diagnostic.

I didn't add a machine-applicable suggestion to the lint because it's not entirely clear what the programmer was trying to achieve with the --x operation. The code that triggers the lint should always be reviewed manually.

Closes #82987

rustbot · 2024-06-17T18:13:40Z

r? @nnethercote

rustbot has assigned @nnethercote.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2024-06-17T18:13:42Z

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

compiler/rustc_lint/src/builtin.rs

kadiwa4 · 2024-06-18T13:49:55Z

@rustbot author

nnethercote · 2024-06-19T05:54:51Z

This needs T-lang approval. The appropriate labels have been applied to summon them.

bors · 2024-06-30T22:27:12Z

☔ The latest upstream changes (presumably #127174) made this pull request unmergeable. Please resolve the merge conflicts.

kadiwa4 · 2024-09-01T19:37:24Z

@rustbot ready

nnethercote · 2024-09-01T22:15:32Z

Still waiting on T-lang, AFAICT.

kadiwa4 · 2024-09-30T11:07:05Z

@rustbot label: -S-waiting-on-review +S-waiting-on-team

bors · 2024-10-29T03:52:36Z

☔ The latest upstream changes (presumably #128985) made this pull request unmergeable. Please resolve the merge conflicts.

scottmcm · 2025-01-14T03:25:17Z

Makes sense to me! It's not something that people would normally write, so worth linting since x = --y won't trip unused.

(I guess they could use it as a really obscure way to debug_assert!(y != MIN), but how about no.)

@rfcbot reviewed

kadiwa4 · 2025-01-23T12:41:04Z

src/tools/clippy/clippy_dev/src/new_lint.rs

-    while let Some(LintDeclSearchResult { content, .. }) = iter.find(|result| result.token == TokenKind::Ident) {
+    while let Some(LintDeclSearchResult { content, .. }) = iter.find(|result| result.token_kind == TokenKind::Ident) {


These changes were necessary to get the clippy dev tool to compile

kadiwa4 · 2025-01-23T12:45:00Z

src/tools/clippy/tests/ui/rename.rs

-#![allow(clippy::manual_find_map)]
 #![allow(clippy::manual_filter_map)]
-#![allow(unpredictable_function_pointer_comparisons)]
+#![allow(clippy::manual_find_map)]


This file is supposed to be auto-generated (it has a comment at the top saying so), but most people seem to edit it manually. I used the generator though, that's why so many lines are changed in this file.

rfcbot · 2025-01-23T14:15:48Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

bors · 2025-01-26T03:54:11Z

☔ The latest upstream changes (presumably #136070) made this pull request unmergeable. Please resolve the merge conflicts.

kadiwa4 · 2025-01-26T11:22:29Z

@rustbot label: -S-waiting-on-team +S-waiting-on-review -I-lang-nominated

nnethercote · 2025-01-26T21:59:01Z

Updated code looks fine to me. I think/hope this has gone through all the appropriate hoops and is ready to be merged.

@bors r+

bors · 2025-01-26T21:59:04Z

📌 Commit c1dcbeb has been approved by nnethercote

It is now in the queue for this repository.

Rollup of 8 pull requests Successful merges: - rust-lang#126604 (Uplift `clippy::double_neg` lint as `double_negations`) - rust-lang#135158 (Add `TooGeneric` variant to `LayoutError` and emit `Unknown`) - rust-lang#135635 (Move `std::io::pipe` code into its own file) - rust-lang#136072 (add two old crash tests) - rust-lang#136079 (compiler_fence: fix example) - rust-lang#136091 (Add some tracing to core bootstrap logic) - rust-lang#136097 (rustc_ast: replace some len-checks + indexing with slice patterns etc.) - rust-lang#136101 (triagebot: set myself on vacation) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#126604 - kadiwa4:uplift_double_negation, r=nnethercote Uplift `clippy::double_neg` lint as `double_negations` Warns about cases like this: ```rust fn main() { let x = 1; let _b = --x; //~ WARN use of a double negation } ``` The intent is to keep people from thinking that `--x` is a prefix decrement operator. `++x`, `x++` and `x--` are invalid expressions and already have a helpful diagnostic. I didn't add a machine-applicable suggestion to the lint because it's not entirely clear what the programmer was trying to achieve with the `--x` operation. The code that triggers the lint should always be reviewed manually. Closes rust-lang#82987

…nnethercote Uplift `clippy::double_neg` lint as `double_negations` Warns about cases like this: ```rust fn main() { let x = 1; let _b = --x; //~ WARN use of a double negation } ``` The intent is to keep people from thinking that `--x` is a prefix decrement operator. `++x`, `x++` and `x--` are invalid expressions and already have a helpful diagnostic. I didn't add a machine-applicable suggestion to the lint because it's not entirely clear what the programmer was trying to achieve with the `--x` operation. The code that triggers the lint should always be reviewed manually. Closes rust-lang#82987

fmease · 2025-02-02T01:59:52Z

@bors r- ('fixing' desync)

rustbot assigned nnethercote Jun 17, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 17, 2024

This comment has been minimized.

Sign in to view

kadiwa4 force-pushed the uplift_double_negation branch from af85271 to a745a8d Compare June 17, 2024 18:22

nnethercote reviewed Jun 18, 2024

View reviewed changes

compiler/rustc_lint/src/builtin.rs Show resolved Hide resolved

flip1995 reviewed Jun 18, 2024

View reviewed changes

compiler/rustc_lint/src/builtin.rs Outdated Show resolved Hide resolved

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 18, 2024

compiler-errors added T-lang Relevant to the language team, which will review and decide on the PR/issue. I-lang-nominated Nominated for discussion during a lang team meeting. and removed T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 18, 2024

kadiwa4 force-pushed the uplift_double_negation branch from a745a8d to 8f3387c Compare September 1, 2024 17:25

kadiwa4 changed the title ~~Uplift clippy::double_neg lint as double_negation~~ Uplift clippy::double_neg lint as double_negations Sep 1, 2024

This comment has been minimized.

Sign in to view

kadiwa4 force-pushed the uplift_double_negation branch from 8f3387c to 9862f05 Compare September 1, 2024 18:01

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 1, 2024

rustbot added S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 30, 2024

kadiwa4 force-pushed the uplift_double_negation branch from 9862f05 to beb1dd2 Compare October 29, 2024 19:54

kadiwa4 commented Jan 23, 2025

View reviewed changes

rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Jan 23, 2025

rfcbot added the to-announce Announce this issue on triage meeting label Jan 23, 2025

rustbot mentioned this pull request Jan 23, 2025

Tracking issue for release notes of #126604: Uplift clippy::double_neg lint as double_negations #135932

Open

3 tasks

kadiwa4 added 3 commits January 26, 2025 12:15

unrelated cleanup

d810d42

remove clippy::double_neg

9e316f3

implement lint double_negations

c1dcbeb

kadiwa4 force-pushed the uplift_double_negation branch from d3cbf72 to c1dcbeb Compare January 26, 2025 11:18

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 26, 2025

fmease mentioned this pull request Jan 27, 2025

Rollup of 8 pull requests #136116

Merged

bors merged commit 3c58b2f into rust-lang:master Jan 27, 2025
6 checks passed

rustbot added this to the 1.86.0 milestone Jan 27, 2025

kadiwa4 deleted the uplift_double_negation branch January 27, 2025 09:43

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 2, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uplift `clippy::double_neg` lint as `double_negations` #126604

Uplift `clippy::double_neg` lint as `double_negations` #126604

kadiwa4 commented Jun 17, 2024 •

edited

Loading

rustbot commented Jun 17, 2024

rustbot commented Jun 17, 2024

This comment has been minimized.

kadiwa4 commented Jun 18, 2024

nnethercote commented Jun 19, 2024

bors commented Jun 30, 2024

This comment has been minimized.

kadiwa4 commented Sep 1, 2024

nnethercote commented Sep 1, 2024

kadiwa4 commented Sep 30, 2024

bors commented Oct 29, 2024

scottmcm commented Jan 14, 2025

kadiwa4 Jan 23, 2025

kadiwa4 Jan 23, 2025

rfcbot commented Jan 23, 2025

bors commented Jan 26, 2025

kadiwa4 commented Jan 26, 2025

nnethercote commented Jan 26, 2025

bors commented Jan 26, 2025

fmease commented Feb 2, 2025

		while let Some(LintDeclSearchResult { content, .. }) = iter.find(\|result\| result.token == TokenKind::Ident) {
		while let Some(LintDeclSearchResult { content, .. }) = iter.find(\|result\| result.token_kind == TokenKind::Ident) {

Uplift clippy::double_neg lint as double_negations #126604

Uplift clippy::double_neg lint as double_negations #126604

Conversation

kadiwa4 commented Jun 17, 2024 • edited Loading

rustbot commented Jun 17, 2024

rustbot commented Jun 17, 2024

This comment has been minimized.

kadiwa4 commented Jun 18, 2024

nnethercote commented Jun 19, 2024

bors commented Jun 30, 2024

This comment has been minimized.

kadiwa4 commented Sep 1, 2024

nnethercote commented Sep 1, 2024

kadiwa4 commented Sep 30, 2024

bors commented Oct 29, 2024

scottmcm commented Jan 14, 2025

kadiwa4 Jan 23, 2025

Choose a reason for hiding this comment

kadiwa4 Jan 23, 2025

Choose a reason for hiding this comment

rfcbot commented Jan 23, 2025

bors commented Jan 26, 2025

kadiwa4 commented Jan 26, 2025

nnethercote commented Jan 26, 2025

bors commented Jan 26, 2025

fmease commented Feb 2, 2025

Uplift `clippy::double_neg` lint as `double_negations` #126604

Uplift `clippy::double_neg` lint as `double_negations` #126604

kadiwa4 commented Jun 17, 2024 •

edited

Loading