Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate unknown-mod-stdin, issue-68794-textrel-on-minimal-lib, raw-dylib-cross-compilation and used-cdylib-macos run-make tests to rmake #126698

Merged
merged 4 commits into from
Jun 29, 2024
Merged

Migrate unknown-mod-stdin, issue-68794-textrel-on-minimal-lib, raw-dylib-cross-compilation and used-cdylib-macos run-make tests to rmake #126698

merged 4 commits into from
Jun 29, 2024

Conversation

Oneirical
Copy link
Contributor

@Oneirical Oneirical commented Jun 19, 2024 •
edited
Loading

Part of #121876 and the associated Google Summer of Code project.

Seriously needs OSX/Windows try-jobs. If it fails, restore only-linux in textrel-on-minimal-lib and try again.

try-job: x86_64-mingw
try-job: x86_64-msvc

@rustbot
Copy link
Collaborator

rustbot commented Jun 19, 2024

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jun 19, 2024
@rustbot
Copy link
Collaborator

rustbot commented Jun 19, 2024

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

@jieyouxu
Copy link
Member

@bors delegate+ (for try jobs, don't r+ just yet)

@bors
Copy link
Contributor

bors commented Jun 19, 2024

✌️ @Oneirical, you can now approve this pull request!

If @jieyouxu told you to "r=me" after making some further change, please make that change, then do @bors r=@jieyouxu

@jieyouxu jieyouxu mentioned this pull request Jun 19, 2024
Open
@jieyouxu
Copy link
Member

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 19, 2024
@bors
Auto merge of rust-lang#126698 - Oneirical:tessteract, r=<try>
725d340 
Migrate `unknown-mod-stdin`, `issue-68794-textrel-on-minimal-lib`, `raw-dylib-cross-compilation` and `used-cdylib-macos` `run-make` tests to rmake

Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html).

Seriously needs OSX/Windows try-jobs. If it fails, restore `only-linux` in `textrel-on-minimal-lib` and try again.

try-job: dist-x86_64-apple
try-job: x86_64-msvc
@bors
Copy link
Contributor

bors commented Jun 19, 2024

⌛ Trying commit 06c0270 with merge 725d340...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Jun 19, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 19, 2024
@Oneirical
Copy link
Contributor Author

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 19, 2024
@bors
Auto merge of rust-lang#126698 - Oneirical:tessteract, r=<try>
c76d79b 
Migrate `unknown-mod-stdin`, `issue-68794-textrel-on-minimal-lib`, `raw-dylib-cross-compilation` and `used-cdylib-macos` `run-make` tests to rmake

Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html).

Seriously needs OSX/Windows try-jobs. If it fails, restore `only-linux` in `textrel-on-minimal-lib` and try again.

try-job: dist-x86_64-apple
try-job: x86_64-msvc
@bors
Copy link
Contributor

bors commented Jun 19, 2024

⌛ Trying commit 445eb08 with merge c76d79b...

@bors
Copy link
Contributor

bors commented Jun 19, 2024

☀️ Try build successful - checks-actions
Build commit: c76d79b (c76d79bf9e48bcad09c7f0b8524dd7e9006e1785)

@Oneirical
Copy link
Contributor Author

Hey, that's pretty neat.
@rustbot review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 19, 2024
jieyouxu
jieyouxu approved these changes Jun 19, 2024
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, tests look good, r=me if the new try-jobs come back green.

@jieyouxu
Copy link
Member

@bors try

@bors
Copy link
Contributor

bors commented Jun 19, 2024

⌛ Trying commit 445eb08 with merge 1746499...

bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 19, 2024
@bors
Auto merge of rust-lang#126698 - Oneirical:tessteract, r=<try>
1746499 
Migrate `unknown-mod-stdin`, `issue-68794-textrel-on-minimal-lib`, `raw-dylib-cross-compilation` and `used-cdylib-macos` `run-make` tests to rmake

Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html).

Seriously needs OSX/Windows try-jobs. If it fails, restore `only-linux` in `textrel-on-minimal-lib` and try again.

try-job: armhf-gnu
try-job: test-various
@bors
Copy link
Contributor

bors commented Jun 19, 2024

☀️ Try build successful - checks-actions
Build commit: 1746499 (1746499b2f90e96974341684e851da29294a87be)

@Kobzol
Copy link
Contributor

Kobzol commented Jun 28, 2024

r? @Kobzol

@bors delegate+

@bors rollup=iffy

Feel free to r=me after a rebase.

@bors
Copy link
Contributor

bors commented Jun 28, 2024

✌️ @Oneirical, you can now approve this pull request!

If @Kobzol told you to "r=me" after making some further change, please make that change, then do @bors r=@Kobzol

@Oneirical
Copy link
Contributor Author

@bors r=@Kobzol

@bors
Copy link
Contributor

bors commented Jun 28, 2024

📌 Commit 4c9eeda has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 28, 2024
@bors
Copy link
Contributor

bors commented Jun 29, 2024

⌛ Testing commit 4c9eeda with merge 1c53c0a...

bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 29, 2024
@bors
Auto merge of rust-lang#126698 - Oneirical:tessteract, r=Kobzol
1c53c0a 
Migrate `unknown-mod-stdin`, `issue-68794-textrel-on-minimal-lib`, `raw-dylib-cross-compilation` and `used-cdylib-macos` `run-make` tests to rmake

Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html).

Seriously needs OSX/Windows try-jobs. If it fails, restore `only-linux` in `textrel-on-minimal-lib` and try again.

try-job: x86_64-mingw
try-job: x86_64-msvc
@rust-log-analyzer
Copy link
Collaborator

The job x86_64-msvc-ext failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
[RUSTC-TIMING] miri test:false 60.962
[RUSTC-TIMING] miri test:false 2.947
    Finished `release` profile [optimized] target(s) in 0.38s
thread 'main' panicked at src/lib.rs:1712:17:
failed to copy `C:\a\rust\rust\build\x86_64-pc-windows-msvc\stage1-tools\x86_64-pc-windows-msvc\release\miri.exe` to `C:\a\rust\rust\build\x86_64-pc-windows-msvc\stage1-tools-bin\miri.exe`: The process cannot access the file because it is being used by another process. (os error 32)
##[endgroup]
Build completed unsuccessfully in 0:00:13
  local time: Sat, Jun 29, 2024  4:58:15 AM
  network time: Sat, 29 Jun 2024 04:58:16 GMT

@bors
Copy link
Contributor

bors commented Jun 29, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 29, 2024
@Kobzol
Copy link
Contributor

Kobzol commented Jun 29, 2024

Hmm, that looks spurious.

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 29, 2024
@bors
Copy link
Contributor

bors commented Jun 29, 2024

⌛ Testing commit 4c9eeda with merge 38d0f87...

@bors
Copy link
Contributor

bors commented Jun 29, 2024

☀️ Test successful - checks-actions
Approved by: Kobzol
Pushing 38d0f87 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 29, 2024
@bors bors merged commit 38d0f87 into rust-lang:master Jun 29, 2024
7 checks passed
@rustbot rustbot added this to the 1.81.0 milestone Jun 29, 2024
@bors bors mentioned this pull request Jun 29, 2024
Merged
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (38d0f87): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 694.857s -> 693.672s (-0.17%)
Artifact size: 324.45 MiB -> 324.46 MiB (0.00%)

@Oneirical Oneirical deleted the tessteract branch June 29, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisDenton ChrisDenton ChrisDenton left review comments

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@Kobzol Kobzol

Labels
A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
Oxidizing run-make tests
Status: Done
Milestone
1.81.0
Development

Successfully merging this pull request may close these issues.
8 participants
@Oneirical @rustbot @jieyouxu @bors @rust-log-analyzer @Kobzol @rust-timer @ChrisDenton