-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unstable support for outputting file checksums for use in cargo #126930
base: master
Are you sure you want to change the base?
Conversation
Given that this PR adds a new concept and a new flag it requires a minimum of discussion within the team. |
These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
This now has an MCP rust-lang/compiler-team#765 |
Waiting for rust-lang/compiler-team#765 FCP to complete. That is 2024-07-11 07:23h UTC. |
The MCP has been accepted @rustbot ready |
ee53f79
to
21c2e87
Compare
The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging. |
Correct, blake3 has been added as it was mentioned during the MCP review as being desirable. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
21c2e87
to
d80d73e
Compare
@Urgau conflicts resolved. |
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
Add unstable support for outputting file checksums for use in cargo Adds an unstable option that appends file checksums and expected lengths to the end of the dep-info file such that `cargo` can read and use these values as an alternative to file mtimes. This PR powers the changes made in this cargo PR rust-lang/cargo#14137 Here's the tracking issue for the cargo feature rust-lang/cargo#14136.
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (c5ac80a): comparison URL. Overall result: ❌✅ regressions and improvements - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 768.642s -> 770.102s (0.19%) |
d80d73e
to
b20ba82
Compare
Merge conflicts resolved, this is ready for review. |
b20ba82
to
c370d41
Compare
☔ The latest upstream changes (presumably #125443) made this pull request unmergeable. Please resolve the merge conflicts. |
81ac250
to
4f7c919
Compare
Merge conflicts resolved. |
☔ The latest upstream changes (presumably #128534) made this pull request unmergeable. Please resolve the merge conflicts. |
hm. r? compiler |
r? compiler |
} | ||
|
||
impl SourceFileHashAlgorithm { | ||
pub fn supported_in_cargo(&self) -> bool { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels like inverting the dependency relationship. The Cargo team and the compiler team can agree on a set of algorithms, though in compiler code we don't need to mention what is supported in Cargo. Cargo can choose whatever algorithm it uses.
Adds an unstable option that appends file checksums and expected lengths to the end of the dep-info file such that
cargo
can read and use these values as an alternative to file mtimes.This PR powers the changes made in this cargo PR rust-lang/cargo#14137
Here's the tracking issue for the cargo feature rust-lang/cargo#14136.