Migrate `run-make/llvm-ident` to `rmake.rs` #126941

GuillaumeGomez · 2024-06-25T10:39:55Z

try-job: armhf-gnu

rustbot · 2024-06-25T10:40:05Z

The run-make-support library was changed

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

Kobzol

LGTM, feel free to r=me with or without the described helper functions.

tests/run-make/llvm-ident/rmake.rs

GuillaumeGomez · 2024-06-25T14:39:40Z

Noting that to myself for next PR. :)

@bors r=Kobzol rollup

bors · 2024-06-25T14:39:43Z

📌 Commit 221dd30 has been approved by Kobzol

It is now in the queue for this repository.

…vm-ident, r=Kobzol Migrate `run-make/llvm-ident` to `rmake.rs` Part of rust-lang#121876. r? `@Kobzol`

…kingjubilee Rollup of 14 pull requests Successful merges: - rust-lang#126618 (Mark assoc tys live only if the corresponding trait is live) - rust-lang#126746 (Deny `use<>` for RPITITs) - rust-lang#126868 (not use offset when there is not ends with brace) - rust-lang#126884 (Do not ICE when suggesting dereferencing closure arg) - rust-lang#126885 (Remove internal `PathBuf::as_mut_vec`) - rust-lang#126893 (Eliminate the distinction between PREC_POSTFIX and PREC_PAREN precedence level) - rust-lang#126915 (Don't suggest awaiting in closure patterns) - rust-lang#126916 (Specify target specific linker for `riscv64gc-gnu` job) - rust-lang#126926 (Tweak a confusing comment in `create_match_candidates`) - rust-lang#126927 (core: VaArgSafe is an unsafe trait) - rust-lang#126932 (Tweak `FlatPat::new` to avoid a temporarily-invalid state) - rust-lang#126941 (Migrate `run-make/llvm-ident` to `rmake.rs`) - rust-lang#126946 (Add missing slash in `const_eval_select` doc comment) - rust-lang#126947 (Delegation: ast lowering refactor) r? `@ghost` `@rustbot` modify labels: rollup

…vm-ident, r=Kobzol Migrate `run-make/llvm-ident` to `rmake.rs` Part of rust-lang#121876. r? ``@Kobzol``

…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#126158 (Disallow setting some built-in cfg via set the command-line) - rust-lang#126724 (Fix a span in `parse_ty_bare_fn`.) - rust-lang#126812 (Rename `tcx` to `cx` in new solver generic code) - rust-lang#126879 (fix Drop items getting leaked in Filter::next_chunk) - rust-lang#126941 (Migrate `run-make/llvm-ident` to `rmake.rs`) - rust-lang#126954 (resolve: Tweak some naming around import ambiguities) - rust-lang#126968 (Don't ICE during RPITIT refinement checking for resolution errors after normalization) - rust-lang#126973 (Fix bad replacement for unsafe extern block suggestion) r? `@ghost` `@rustbot` modify labels: rollup

…vm-ident, r=Kobzol Migrate `run-make/llvm-ident` to `rmake.rs` Part of rust-lang#121876. r? ```@Kobzol```

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#125016 (Update compiler_builtins to 0.1.113) - rust-lang#126571 (Less `maybe_whole_expr`, take 2) - rust-lang#126721 (coverage: Make `#[coverage(..)]` apply recursively to nested functions) - rust-lang#126928 (Some `Nonterminal` removal precursors) - rust-lang#126929 (Remove `__rust_force_expr`.) - rust-lang#126941 (Migrate `run-make/llvm-ident` to `rmake.rs`) - rust-lang#126970 (Simplify `str::clone_into`) - rust-lang#126980 (set self.is_known_utf8 to false in extend_from_slice) - rust-lang#126983 (Remove `f16` and `f128` ICE paths from smir) r? `@ghost` `@rustbot` modify labels: rollup

matthiaskrgr · 2024-06-26T20:03:39Z

@bors r-
#126998 (comment)

GuillaumeGomez · 2024-07-01T13:13:33Z

@bors try

bors · 2024-07-01T13:14:43Z

⌛ Trying commit 7276499 with merge c3bc540...

…-ident, r=<try> Migrate `run-make/llvm-ident` to `rmake.rs` Part of rust-lang#121876. r? `@Kobzol` try-job: armhf-gnu

bors · 2024-07-01T14:14:37Z

☀️ Try build successful - checks-actions
Build commit: c3bc540 (c3bc540ae26bb24d59e5b7fef194b6c80130f577)

GuillaumeGomez · 2024-07-01T14:16:04Z

Seems like it's ok?

@bors rollup=iffy r=Kobzol

bors · 2024-07-01T14:16:06Z

📌 Commit 7276499 has been approved by Kobzol

It is now in the queue for this repository.

…vm-ident, r=Kobzol Migrate `run-make/llvm-ident` to `rmake.rs` Part of rust-lang#121876. r? `@Kobzol` try-job: armhf-gnu

…llaumeGomez Rollup of 7 pull requests Successful merges: - rust-lang#126753 (Add nightly style guide section for `precise_capturing` `use<>` syntax) - rust-lang#126880 (Migrate `volatile-intrinsics`, `weird-output-filenames`, `wasm-override-linker`, `wasm-exceptions-nostd` to `rmake`) - rust-lang#126941 (Migrate `run-make/llvm-ident` to `rmake.rs`) - rust-lang#127128 (Stabilize `duration_abs_diff`) - rust-lang#127129 (Use full expr span for return suggestion on type error/ambiguity) - rust-lang#127188 ( improve the way bootstrap handles rustlib components) - rust-lang#127201 (Improve run-make-support API) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2024-07-01T17:56:37Z

⌛ Testing commit 7276499 with merge 4de9c7b...

…-ident, r=Kobzol Migrate `run-make/llvm-ident` to `rmake.rs` Part of rust-lang#121876. r? `@Kobzol` try-job: armhf-gnu

rust-log-analyzer · 2024-07-01T19:31:28Z

The job x86_64-msvc-ext failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[RUSTC-TIMING] miri test:false 66.120
[RUSTC-TIMING] miri test:false 3.089
    Finished `release` profile [optimized] target(s) in 0.41s
thread 'main' panicked at src/lib.rs:1668:17:
failed to copy `C:\a\rust\rust\build\x86_64-pc-windows-msvc\stage1-tools\x86_64-pc-windows-msvc\release\miri.exe` to `C:\a\rust\rust\build\x86_64-pc-windows-msvc\stage1-tools-bin\miri.exe`: The process cannot access the file because it is being used by another process. (os error 32)
##[endgroup]
Build completed unsuccessfully in 0:00:09
  local time: Mon, Jul  1, 2024  7:31:13 PM
  network time: Mon, 01 Jul 2024 19:31:13 GMT

bors · 2024-07-01T19:32:07Z

💔 Test failed - checks-actions

GuillaumeGomez · 2024-07-01T19:44:09Z

@bors retry

bors · 2024-07-01T21:55:44Z

⌛ Testing commit 7276499 with merge 7d97c59...

bors · 2024-07-02T00:11:48Z

☀️ Test successful - checks-actions
Approved by: Kobzol
Pushing 7d97c59 to master...

rust-timer · 2024-07-02T01:26:25Z

Finished benchmarking commit (7d97c59): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (secondary -4.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-4.3%	[-5.8%, -2.7%]	2
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 694.524s -> 695.108s (0.08%)
Artifact size: 327.56 MiB -> 327.55 MiB (-0.00%)

…vm-ident, r=Kobzol Improve code of `run-make/llvm-ident` Follow-up of rust-lang#126941. r? `@Kobzol`

Rollup merge of rust-lang#127237 - GuillaumeGomez:improve-run-make-llvm-ident, r=Kobzol Improve code of `run-make/llvm-ident` Follow-up of rust-lang#126941. r? `@Kobzol`

rustbot assigned Kobzol Jun 25, 2024

Kobzol mentioned this pull request Jun 25, 2024

Tracking Issue for porting run-make tests to use Rust #121876

Open

Kobzol approved these changes Jun 25, 2024

View reviewed changes

tests/run-make/llvm-ident/rmake.rs Show resolved Hide resolved

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 25, 2024

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Jun 25, 2024

Rollup merge of rust-lang#126941 - GuillaumeGomez:migrate-run-make-ll…

1626e24

…vm-ident, r=Kobzol Migrate `run-make/llvm-ident` to `rmake.rs` Part of rust-lang#121876. r? `@Kobzol`

workingjubilee mentioned this pull request Jun 25, 2024

Rollup of 14 pull requests #126962

Closed

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 26, 2024

Rollup merge of rust-lang#126941 - GuillaumeGomez:migrate-run-make-ll…

6f9b0af

…vm-ident, r=Kobzol Migrate `run-make/llvm-ident` to `rmake.rs` Part of rust-lang#121876. r? ``@Kobzol``

matthiaskrgr mentioned this pull request Jun 26, 2024

Rollup of 8 pull requests #126974

Closed

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 26, 2024

Rollup merge of rust-lang#126941 - GuillaumeGomez:migrate-run-make-ll…

60a14e9

…vm-ident, r=Kobzol Migrate `run-make/llvm-ident` to `rmake.rs` Part of rust-lang#121876. r? ```@Kobzol```

matthiaskrgr mentioned this pull request Jun 26, 2024

Rollup of 9 pull requests #126998

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 26, 2024

GuillaumeGomez added 2 commits July 1, 2024 15:10

Add input_file method on LlvmFileCheck

fc8b6c6

Migrate run-make/llvm-ident to rmake.rs

7276499

GuillaumeGomez force-pushed the migrate-run-make-llvm-ident branch from 221dd30 to 7276499 Compare July 1, 2024 13:12

bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 1, 2024

Auto merge of rust-lang#126941 - GuillaumeGomez:migrate-run-make-llvm…

c3bc540

…-ident, r=<try> Migrate `run-make/llvm-ident` to `rmake.rs` Part of rust-lang#121876. r? `@Kobzol` try-job: armhf-gnu

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 1, 2024

GuillaumeGomez mentioned this pull request Jul 1, 2024

Rollup of 7 pull requests #127207

Closed

bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 1, 2024

Auto merge of rust-lang#126941 - GuillaumeGomez:migrate-run-make-llvm…

4de9c7b

…-ident, r=Kobzol Migrate `run-make/llvm-ident` to `rmake.rs` Part of rust-lang#121876. r? `@Kobzol` try-job: armhf-gnu

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 1, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 1, 2024

bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 2, 2024

bors merged commit 7d97c59 into rust-lang:master Jul 2, 2024
7 checks passed

rustbot added this to the 1.81.0 milestone Jul 2, 2024

GuillaumeGomez deleted the migrate-run-make-llvm-ident branch July 2, 2024 08:54

GuillaumeGomez mentioned this pull request Jul 2, 2024

Improve code of run-make/llvm-ident #127237

Merged

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jul 8, 2024

Rollup merge of rust-lang#127237 - GuillaumeGomez:improve-run-make-ll…

485a861

…vm-ident, r=Kobzol Improve code of `run-make/llvm-ident` Follow-up of rust-lang#126941. r? `@Kobzol`

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate `run-make/llvm-ident` to `rmake.rs` #126941

Migrate `run-make/llvm-ident` to `rmake.rs` #126941

GuillaumeGomez commented Jun 25, 2024 •

edited

Loading

rustbot commented Jun 25, 2024

Kobzol left a comment •

edited

Loading

GuillaumeGomez commented Jun 25, 2024

bors commented Jun 25, 2024

matthiaskrgr commented Jun 26, 2024

GuillaumeGomez commented Jul 1, 2024

bors commented Jul 1, 2024

bors commented Jul 1, 2024

GuillaumeGomez commented Jul 1, 2024

bors commented Jul 1, 2024

bors commented Jul 1, 2024

rust-log-analyzer commented Jul 1, 2024

bors commented Jul 1, 2024

GuillaumeGomez commented Jul 1, 2024

bors commented Jul 1, 2024

bors commented Jul 2, 2024

rust-timer commented Jul 2, 2024

Migrate run-make/llvm-ident to rmake.rs #126941

Migrate run-make/llvm-ident to rmake.rs #126941

Conversation

GuillaumeGomez commented Jun 25, 2024 • edited Loading

rustbot commented Jun 25, 2024

Kobzol left a comment • edited Loading

Choose a reason for hiding this comment

GuillaumeGomez commented Jun 25, 2024

bors commented Jun 25, 2024

matthiaskrgr commented Jun 26, 2024

GuillaumeGomez commented Jul 1, 2024

bors commented Jul 1, 2024

bors commented Jul 1, 2024

GuillaumeGomez commented Jul 1, 2024

bors commented Jul 1, 2024

bors commented Jul 1, 2024

rust-log-analyzer commented Jul 1, 2024

bors commented Jul 1, 2024

GuillaumeGomez commented Jul 1, 2024

bors commented Jul 1, 2024

bors commented Jul 2, 2024

rust-timer commented Jul 2, 2024

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Migrate `run-make/llvm-ident` to `rmake.rs` #126941

Migrate `run-make/llvm-ident` to `rmake.rs` #126941

GuillaumeGomez commented Jun 25, 2024 •

edited

Loading

Kobzol left a comment •

edited

Loading