-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change to the NetBSD archive URL rather than the CDN #127232
Conversation
src/ci/docker/host-x86_64/dist-x86_64-netbsd/build-netbsd-toolchain.sh
Outdated
Show resolved
Hide resolved
src/ci/docker/host-x86_64/dist-x86_64-netbsd/build-netbsd-toolchain.sh
Outdated
Show resolved
Hide resolved
@@ -27,7 +27,10 @@ mkdir -p /x-tools/x86_64-unknown-netbsd/sysroot | |||
|
|||
# URL=https://ci-mirrors.rust-lang.org/rustc | |||
|
|||
SOURCE_URL=https://cdn.netbsd.org/pub/NetBSD/NetBSD-9.0/source/sets | |||
# FIXME: the archive URL is being used temporarily while the CDN is down. | |||
# Change back to the original URL once it is back up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should not do that, we should instead mirror it ourselves and use that URL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, I updated the fixme to say that
f6008aa
to
5dc002d
Compare
Just realized the archive URL uses http and doesn't seem to have https, we may not want this then :/ I'll give it another half hour to see if the CDN comes back. If not, I'll add a SHA sum check. Nothing to calculate the correct SHA from except what's currently available at the archive URL, unfortunately... Open to suggestions |
https://cdn.netbsd.org/pub/NetBSD/security/hashes/NetBSD-9.0_hashes.asc seems to work |
5dc002d
to
95b682c
Compare
CDN is still down. I added a check against the sha from @notriddle's link. Could somebody |
@bors try |
Change to the NetBSD archive URL rather than the CDN The CDN has been down for a few hours. Switch to an alternative for the time being so we can unblock CI. It appears that the CDN is quite a bit faster, so we will likely want to switch back when available. Context: https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/dist-x86_64-netbsd.20is.20borked
Why no dist-x86_64-netbsd in the try, it's in the top post 🤔 |
Does edit: looks like this shouldn't matter? rust/src/ci/github-actions/calculate-job-matrix.py Lines 74 to 87 in 7d97c59
edit edit: unless it needs to be in the actual commit message? |
I think that the problem is that the stuff inside the comments is indeed ignored by homu, and it then doesn't add it to the commit message. You can see that it is not here: 95b682c. CI reads the commit message, which is generated from the PR description by |
Oh that makes more sense, thanks. I removed the comments, mind restarting the try? (assuming this still seems necessary) |
@bors try |
Change to the NetBSD archive URL rather than the CDN The CDN has been down for a few hours. Switch to an alternative for the time being so we can unblock CI. It appears that the CDN is quite a bit faster, so we will likely want to switch back when available. Context: https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/dist-x86_64-netbsd.20is.20borked try-job: dist-x86_64-netbsd
This comment has been minimized.
This comment has been minimized.
💔 Test failed - checks-actions |
95b682c
to
4c51d7f
Compare
Forgot to rename a function, could use another try please |
try harder |
These spurious failures are really starting to compound... @bors retry |
…bzol Change to the NetBSD archive URL rather than the CDN The CDN has been down for a few hours. Switch to an alternative for the time being so we can unblock CI. It appears that the CDN is quite a bit faster, so we will likely want to switch back when available. Context: https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/dist-x86_64-netbsd.20is.20borked try-job: dist-x86_64-netbsd
The job Click to see the possible cause of the failure (guessed by this bot)
|
💔 Test failed - checks-actions |
@bors retry |
☀️ Test successful - checks-actions |
Finished benchmarking commit (bcf38b5): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResults (secondary 4.7%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 695.108s -> 696.686s (0.23%) |
I'm surprised that it is still down. @he32 (since you're listed as the NetBSD maintainer) any clue if anyone from NetBSD are aware of this? Summary: the CDN for 9.0 and 9.1 have been 404ing for a few days (e.g. https://cdn.netbsd.org/pub/NetBSD/NetBSD-9.0/source/sets/). Other versions correctly redirected to the archive URL for a while while the CDN was down, and now seem to be back up at the CDN (e.g. https://cdn.netbsd.org/pub/NetBSD/NetBSD-9.2/source/sets/) - but 9.0 and 9.1 CDN links are just dead. This isn't currently a problem for Rust since we switched to the archive URL (this PR), but presumably we aren't the only ones to experience some fallout. |
[beta] backports - Properly gate `safe` keyword in pre-expansion rust-lang#126757 - Switch back `non_local_definitions` lint to allow-by-default rust-lang#127015 - Stall computing instance for drop shim until it has no unsubstituted const params rust-lang#127068 - Update LLVM submodule rust-lang#127190 - Change to the NetBSD archive URL rather than the CDN rust-lang#127232 r? cuviper
[beta] backports - Properly gate `safe` keyword in pre-expansion rust-lang#126757 - Switch back `non_local_definitions` lint to allow-by-default rust-lang#127015 - Stall computing instance for drop shim until it has no unsubstituted const params rust-lang#127068 - Update LLVM submodule rust-lang#127190 - Change to the NetBSD archive URL rather than the CDN rust-lang#127232 r? cuviper
[beta] backports - Properly gate `safe` keyword in pre-expansion rust-lang#126757 - Switch back `non_local_definitions` lint to allow-by-default rust-lang#127015 - Stall computing instance for drop shim until it has no unsubstituted const params rust-lang#127068 - Update LLVM submodule rust-lang#127190 - Change to the NetBSD archive URL rather than the CDN rust-lang#127232 r? cuviper
The CDN has been down for a few hours. Switch to an alternative for the time being so we can unblock CI.
It appears that the CDN is quite a bit faster, so we will likely want to switch back when available.
Context: https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/dist-x86_64-netbsd.20is.20borked
try-job: dist-x86_64-netbsd