Removed @ from around several rustc contexts. #12735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was trying to hint at something else with the branch name, but the coincidence is amazing. |
|
@alexcrichton I think I did that to avoid adding a lifetime parameter to |
|
That sounds good to me. I think this is just waiting on the previous change to land first now. |
| None => self.default_sysroot.as_ref() | ||
| .expect("missing sysroot and default_sysroot in Session") | ||
| }; | ||
| filesearch::FileSearch::new( |
There was a problem hiding this comment.
Is this expensive? because it seems that this is now created several times, rather than just once.
There was a problem hiding this comment.
It's just a few references.
bors
added a commit
that referenced
this pull request
Mar 16, 2014
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 25, 2022
fix(completion): `super::` completion at crate root and module depth aware - should close rust-lang#12439 - Suggest super according to the depth in tree
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
May 2, 2024
Changelog for Clippy 1.78 🪄 Roses and Violets have colors, Red and Blue are the two, I'm getting to the end of my masters, what a cool goal to pursue --- ### The cat of this release is: *Shadow* submitted by `@benwh1:` <img height=500 src="https://github.com/rust-lang/rust-clippy/assets/32911992/c56af314-4644-482a-a08e-f32f4c7d7b22" alt="The cats of this Clippy release" /> Cats for the next release can be nominated in the comments :D --- changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.