Use verbose style when suggesting changing `const` with `let` #127382

estebank · 2024-07-05T19:33:00Z

No description provided.

rustbot · 2024-07-05T19:33:09Z

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

compiler-errors · 2024-07-05T20:54:55Z

@bors r+ rollup

bors · 2024-07-05T20:54:57Z

📌 Commit d9ed923 has been approved by compiler-errors

It is now in the queue for this repository.

Use verbose style when suggesting changing `const` with `let`

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#127333 (Split `SolverDelegate` back out from `InferCtxtLike`) - rust-lang#127363 (Improve readability of some fmt code examples) - rust-lang#127366 (Use `ControlFlow` results for visitors that are only looking for a single value) - rust-lang#127368 (Added dots at the sentence ends of rustc AST doc) - rust-lang#127369 (Match ergonomics 2024: align with RFC again) - rust-lang#127382 (Use verbose style when suggesting changing `const` with `let`) - rust-lang#127383 (Use verbose style for argument removal suggestion) r? `@ghost` `@rustbot` modify labels: rollup

ehuss · 2024-07-05T23:10:36Z

@bors r-

Failed in #127394 (comment)

workingjubilee · 2024-07-05T23:35:35Z

Hmm, that test needs to be minicored, I think.

compiler-errors · 2024-07-06T00:20:29Z

tests/ui/const-generics/legacy-const-generics-bad.stderr

+   |
+help: consider using `const` instead of `let`
+   |
+LL |     const a = 1;


Wait, this suggestion is definitely wrong. Please mark it as not MachineApplicable.

Sigh. This is partly why I'm doing this. A bunch of existing incorrect suggestions were hiding in plain sight. The verbose output makes them easier to actually notice when they are wrong :-/

Sorry, I should've noticed it sooner. I'll look at your diffs closer next time, but maybe you should look at them closer too 😉 Group effort 🙌

The sigh was at the suggestion being wrong in the first place :)

compiler-errors

Also the suggestion needs to be marked HasPlaceholders or otherwise tweaked since it's not MachineApplicable in its current state.

compiler-errors · 2024-07-08T19:44:36Z

r=me when ci green

compiler-errors · 2024-07-09T04:22:19Z

@bors r+ rollup

bors · 2024-07-09T04:22:22Z

📌 Commit ab56dfd has been approved by compiler-errors

It is now in the queue for this repository.

Use verbose style when suggesting changing `const` with `let`

…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#127028 (Fix regression in the MIR lowering of or-patterns) - rust-lang#127091 (impl FusedIterator and a size hint for the error sources iter) - rust-lang#127358 (Automatically taint when reporting errors from ItemCtxt) - rust-lang#127382 (Use verbose style when suggesting changing `const` with `let`) - rust-lang#127397 (fix interleaved output in the default panic hook when multiple threads panic simultaneously) - rust-lang#127484 (`#[doc(alias)]`'s doc: say that ASCII spaces are allowed) - rust-lang#127496 (Update `f16`/`f128` FIXMEs that needed `(NEG_)INFINITY`) - rust-lang#127508 (small search graph refactor) r? `@ghost` `@rustbot` modify labels: rollup

Use verbose style when suggesting changing `const` with `let`

estebank · 2024-07-09T17:14:35Z

@bors r-

I hadn't addressed #127382 (comment) yet.

Use verbose style when suggesting changing `const` with `let`

bors · 2024-07-09T19:24:41Z

⌛ Testing commit 6405df5 with merge 746c50f...

tgross35 · 2024-07-09T19:35:23Z

Looks like maybe one extra line was missing (failed rollup #127529)

024-07-09T19:22:37.6872320Z ---- [ui] tests/ui/asm/aarch64/parse-error.rs stdout ----
2024-07-09T19:22:37.6873300Z diff of stderr:
2024-07-09T19:22:37.6873600Z 
2024-07-09T19:22:37.6873920Z 398	LL |     const bar: /* Type */ = 0;
2024-07-09T19:22:37.6874630Z 399	   |     ~~~~~    ++++++++++++
2024-07-09T19:22:37.6875140Z 400	
2024-07-09T19:22:37.6875570Z -	
2024-07-09T19:22:37.6876020Z 402	error: aborting due to 57 previous errors
2024-07-09T19:22:37.6876560Z 403	
2024-07-09T19:22:37.6877170Z 404	For more information about this error, try `rustc --explain E0435`.
2024-07-09T19:22:37.6877690Z 
2024-07-09T19:22:37.6877810Z 
2024-07-09T19:22:37.6878100Z The actual stderr differed from the expected stderr.

tgross35 · 2024-07-09T19:36:49Z

Ah this is testing again already, bors is moving too fast. Somebody should r-

matthiaskrgr · 2024-07-09T19:44:03Z

@bors r-

bors · 2024-07-09T19:59:14Z

💔 Test failed - checks-actions

estebank · 2024-07-11T20:40:16Z

@bors try

bors · 2024-07-11T20:44:50Z

⌛ Trying commit 4df7514 with merge 4923464...

Use verbose style when suggesting changing `const` with `let`

bors · 2024-07-11T22:27:15Z

☀️ Try build successful - checks-actions
Build commit: 4923464 (49234641d8a0d2e23484db5a6ad9750775e16eed)

estebank · 2024-07-12T00:48:46Z

@bors r=compiler-errors

bors · 2024-07-12T00:48:48Z

📌 Commit 4df7514 has been approved by compiler-errors

It is now in the queue for this repository.

bors · 2024-07-12T01:18:16Z

⌛ Testing commit 4df7514 with merge 4a31a6c...

bors · 2024-07-12T03:39:31Z

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 4a31a6c to master...

rust-timer · 2024-07-12T05:02:40Z

Finished benchmarking commit (4a31a6c): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -1.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.6%	[3.6%, 3.6%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-3.8%	[-5.5%, -2.1%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-1.3%	[-5.5%, 3.6%]	3

Cycles

Results (primary -1.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.8%	[-2.7%, -0.8%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-1.8%	[-2.7%, -0.8%]	2

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 704.882s -> 704.308s (-0.08%)
Artifact size: 328.66 MiB -> 328.70 MiB (0.01%)

Update Rust toolchain from nightly-2024-07-12 to nightly-2024-07-13 without any other source changes. This is an automatically generated pull request. If any of the CI checks fail, manual intervention is required. In such a case, review the changes at https://github.com/rust-lang/rust from rust-lang@5315cbe up to rust-lang@c6727fc. The log for this commit range is: rust-lang@c6727fc9b5 Auto merge of rust-lang#123351 - beetrees:x86-ret-snan-rust, r=nikic,workingjubilee rust-lang@62c068feea Auto merge of rust-lang#127636 - nnethercote:fix-Parser-look_ahead, r=oli-obk rust-lang@5d76a13bbe Auto merge of rust-lang#127653 - matthiaskrgr:rollup-72bqgvp, r=matthiaskrgr rust-lang@f11c2c8e95 Rollup merge of rust-lang#127648 - Kobzol:ci-lower-timeout, r=pietroalbini rust-lang@526da2366a Rollup merge of rust-lang#127627 - lcnr:rustc_search_graph, r=compiler-errors rust-lang@f5fa6fb602 Rollup merge of rust-lang#127613 - nikic:riscv-update, r=cuviper rust-lang@b4f002d2e5 Rollup merge of rust-lang#127552 - onur-ozkan:unnecessary-git-usage, r=Kobzol rust-lang@8ceb4e49ff Rollup merge of rust-lang#127433 - dtolnay:conststrlen, r=workingjubilee rust-lang@f9b3e8b387 Rollup merge of rust-lang#126827 - the8472:pidfd-spawn, r=workingjubilee rust-lang@18152d72a4 Rollup merge of rust-lang#126639 - sayantn:amx, r=Amanieu rust-lang@65ea92d4a1 Rollup merge of rust-lang#124980 - zachs18:rc-allocator, r=Amanieu rust-lang@05eac57ef6 Auto merge of rust-lang#127479 - Urgau:rustc-stable-hash, r=michaelwoerister rust-lang@15f770b143 enable fuzzing of `SearchGraph` rust-lang@cae9d480bf Adjust tests for x86 "Rust" ABI changes rust-lang@3f4b9dd463 Lower timeout of CI jobs to 4 hours rust-lang@7f1518bddd Add instability attribute on private const_strlen function rust-lang@b286722878 Auto merge of rust-lang#127635 - matthiaskrgr:rollup-foopajr, r=matthiaskrgr rust-lang@100f3fd133 Add a new special case to `Parser::look_ahead`. rust-lang@ebe1305b1e Remove the bogus special case from `Parser::look_ahead`. rust-lang@dad95578b0 Add unit tests for `Parser::look_ahead`. rust-lang@ec05c4ea3f Add the feature gate and target-features rust-lang@c2b7842555 Rollup merge of rust-lang#127625 - SkiFire13:revert-comment-deletion, r=workingjubilee rust-lang@ca576eae4e Rollup merge of rust-lang#127622 - compiler-errors:builtin-internal, r=lqd rust-lang@fe564c10ab Rollup merge of rust-lang#127607 - Zalathar:normalize-hint, r=wesleywiser rust-lang@83d1a1b252 Rollup merge of rust-lang#127596 - tesuji:help-unwrap-or, r=compiler-errors rust-lang@1e7ad4c3ed Rollup merge of rust-lang#127422 - greaka:master, r=workingjubilee rust-lang@58fe37f2c3 Rollup merge of rust-lang#127164 - Nadrieril:clean-lowering-loop, r=matthewjasper rust-lang@4a31a6c32a Auto merge of rust-lang#127382 - estebank:const-let, r=compiler-errors rust-lang@5e311f933d Auto merge of rust-lang#127614 - matthiaskrgr:rollup-8geziwi, r=matthiaskrgr rust-lang@a776e5f922 Add doc for deconstruct_option_or_result rust-lang@872d7b82e1 Add suggestion for `Option<&Vec<T>> -> Option<&[T]` rust-lang@d9170dc666 Add regression test for issue 127545 rust-lang@4df75140dd Fix aarch64 test rust-lang@cbe75486f7 Account for `let foo = expr`; to suggest `const foo: Ty = expr;` rust-lang@b56dc8ee90 Use verbose style when suggesting changing `const` with `let` rust-lang@d9021791eb Revert accidental comment deletion rust-lang@b77d3ef7c4 Mark builtin syntax as internal rust-lang@fa3ce50f0b Rollup merge of rust-lang#127605 - nikic:remove-extern-wasm, r=oli-obk rust-lang@d433f176ef Rollup merge of rust-lang#127601 - trevyn:issue-127600, r=compiler-errors rust-lang@47ab86653e Rollup merge of rust-lang#127599 - tgross35:lazy_cell_consume-rename, r=workingjubilee rust-lang@a10b4d1463 Rollup merge of rust-lang#127598 - weiznich:diagnostic_do_not_recommend_also_skips_help, r=compiler-errors rust-lang@73c500b3a7 Rollup merge of rust-lang#127591 - compiler-errors:label-after-primary, r=lcnr rust-lang@380c78741e Rollup merge of rust-lang#127588 - uweigand:s390x-f16-doctests, r=tgross35 rust-lang@6fd955549a Rollup merge of rust-lang#127572 - tbu-:pr_debug_event_nonpacked, r=jhpratt rust-lang@8de487fdbd Rollup merge of rust-lang#124599 - estebank:issue-41708, r=wesleywiser rust-lang@55256c5a18 Update dist-riscv64-linux to binutils 2.40 rust-lang@977439d9b8 Use uplifted `rustc-stable-hash` crate in `rustc_data_structures` rust-lang@f56b2074c6 solve -> solve/mod rust-lang@08a2992d6b compiletest: Better error message for bad `normalize-*` headers rust-lang@8a50bcbdce Remove extern "wasm" ABI rust-lang@a01f49e7f3 check is_ident before parse_ident rust-lang@ab56fe2053 Rename `lazy_cell_consume` to `lazy_cell_into_inner` rust-lang@27d5db166e Allows `#[diagnostic::do_not_recommend]` to supress trait impls in suggestions as well rust-lang@12ae282987 Fix diagnostic and add a test for it rust-lang@df72e478b0 Make sure that labels are defined after the primary span in diagnostics rust-lang@0065763950 core: Limit remaining f16 doctests to x86_64 linux rust-lang@45ad522e87 Don't mark `DEBUG_EVENT` struct as `repr(packed)` rust-lang@0134bd2e67 remove unnecessary `git` usages rust-lang@42772e98e0 Address review comments rust-lang@3e030b38ef Return the `otherwise_block` instead of passing it as argument rust-lang@fc40247c6b Factor out the "process remaining candidates" cases rust-lang@8a222ffd6b Don't try to save an extra block rust-lang@c5062f7318 Move or-pattern expansion inside the main part of the algorithm rust-lang@bff4d213fa Factor out the special handling of or-patterns rust-lang@5bf50e66f9 Move a function rust-lang@53d3e6217b Stabilize const_cstr_from_ptr (CStr::from_ptr, CStr::count_bytes) rust-lang@585ca16e0b as_simd: fix comment to be in line with 507583a (rust-lang#121201) rust-lang@0f643c449a Ensure tests don't fail on i586 in CI rust-lang@ec0c755704 Check that we get somewhat sane PIDs when spawning with pidfds rust-lang@3e4e31b7bf more fine-grained feature-detection for pidfd spawning rust-lang@0ce361938e document safety properties of the internal Process::new constructor rust-lang@6687a3f7da use pidfd_spawn for faster process creation when pidfds are requested rust-lang@5c46acac04 document the cvt methods rust-lang@0e1c832dbd Update `platform-support.md` to reflect improvements in returning floats on 32-bit x86 rust-lang@952becc0bd Ensure floats are returned losslessly by the Rust ABI on 32-bit x86 rust-lang@a1ad6346d6 Add fn allocator method to rc/sync::Weak. Relax Rc<T>/Arc<T>::allocator to allow unsized T. rust-lang@2df4f7dd8c Suggest borrowing on fn argument that is `impl AsRef` Co-authored-by: celinval <35149715+celinval@users.noreply.github.com>

rustbot assigned davidtwco Jul 5, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 5, 2024

compiler-errors approved these changes Jul 5, 2024

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 5, 2024

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 5, 2024

Rollup merge of rust-lang#127382 - estebank:const-let, r=compiler-errors

a1f5487

Use verbose style when suggesting changing `const` with `let`

matthiaskrgr mentioned this pull request Jul 5, 2024

Rollup of 7 pull requests #127394

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 5, 2024

compiler-errors reviewed Jul 6, 2024

View reviewed changes

compiler-errors requested changes Jul 6, 2024

View reviewed changes

compiler-errors approved these changes Jul 8, 2024

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 9, 2024

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 9, 2024

Rollup merge of rust-lang#127382 - estebank:const-let, r=compiler-errors

2fea2c7

Use verbose style when suggesting changing `const` with `let`

matthiaskrgr mentioned this pull request Jul 9, 2024

Rollup of 8 pull requests #127519

Closed

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 9, 2024

Rollup merge of rust-lang#127382 - estebank:const-let, r=compiler-errors

3cbf0a9

Use verbose style when suggesting changing `const` with `let`

matthiaskrgr mentioned this pull request Jul 9, 2024

Rollup of 7 pull requests #127526

Closed

bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 9, 2024

Auto merge of rust-lang#127382 - estebank:const-let, r=compiler-errors

746c50f

Use verbose style when suggesting changing `const` with `let`

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 9, 2024

This comment has been minimized.

Sign in to view

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 9, 2024

estebank added 3 commits July 11, 2024 20:39

Use verbose style when suggesting changing const with let

b56dc8e

Account for let foo = expr; to suggest const foo: Ty = expr;

cbe7548

Fix aarch64 test

4df7514

estebank force-pushed the const-let branch from 6405df5 to 4df7514 Compare July 11, 2024 20:40

bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 11, 2024

Auto merge of rust-lang#127382 - estebank:const-let, r=<try>

4923464

Use verbose style when suggesting changing `const` with `let`

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 12, 2024

bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 12, 2024

bors merged commit 4a31a6c into rust-lang:master Jul 12, 2024
7 checks passed

rustbot added this to the 1.81.0 milestone Jul 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use verbose style when suggesting changing `const` with `let` #127382

Use verbose style when suggesting changing `const` with `let` #127382

estebank commented Jul 5, 2024

rustbot commented Jul 5, 2024

compiler-errors commented Jul 5, 2024

bors commented Jul 5, 2024

ehuss commented Jul 5, 2024

workingjubilee commented Jul 5, 2024

compiler-errors Jul 6, 2024

estebank Jul 6, 2024

compiler-errors Jul 6, 2024 •

edited

Loading

estebank Jul 6, 2024

compiler-errors left a comment

compiler-errors commented Jul 8, 2024

compiler-errors commented Jul 9, 2024

bors commented Jul 9, 2024

estebank commented Jul 9, 2024

bors commented Jul 9, 2024

tgross35 commented Jul 9, 2024

tgross35 commented Jul 9, 2024

matthiaskrgr commented Jul 9, 2024

This comment has been minimized.

bors commented Jul 9, 2024

estebank commented Jul 11, 2024

bors commented Jul 11, 2024

bors commented Jul 11, 2024

estebank commented Jul 12, 2024

bors commented Jul 12, 2024

bors commented Jul 12, 2024

bors commented Jul 12, 2024

rust-timer commented Jul 12, 2024

Use verbose style when suggesting changing const with let #127382

Use verbose style when suggesting changing const with let #127382

Conversation

estebank commented Jul 5, 2024

rustbot commented Jul 5, 2024

compiler-errors commented Jul 5, 2024

bors commented Jul 5, 2024

ehuss commented Jul 5, 2024

workingjubilee commented Jul 5, 2024

compiler-errors Jul 6, 2024

Choose a reason for hiding this comment

estebank Jul 6, 2024

Choose a reason for hiding this comment

compiler-errors Jul 6, 2024 • edited Loading

Choose a reason for hiding this comment

estebank Jul 6, 2024

Choose a reason for hiding this comment

compiler-errors left a comment

Choose a reason for hiding this comment

compiler-errors commented Jul 8, 2024

compiler-errors commented Jul 9, 2024

bors commented Jul 9, 2024

estebank commented Jul 9, 2024

bors commented Jul 9, 2024

tgross35 commented Jul 9, 2024

tgross35 commented Jul 9, 2024

matthiaskrgr commented Jul 9, 2024

This comment has been minimized.

bors commented Jul 9, 2024

estebank commented Jul 11, 2024

bors commented Jul 11, 2024

bors commented Jul 11, 2024

estebank commented Jul 12, 2024

bors commented Jul 12, 2024

bors commented Jul 12, 2024

bors commented Jul 12, 2024

rust-timer commented Jul 12, 2024

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Use verbose style when suggesting changing `const` with `let` #127382

Use verbose style when suggesting changing `const` with `let` #127382

compiler-errors Jul 6, 2024 •

edited

Loading