Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup failing fuchsia tests #127461

Merged
merged 3 commits into from
Jul 10, 2024
Merged

Commits on Jul 7, 2024

  1. [fuchsia-test-runner] Remove runner logs from stdout and stderr

    Many tests use stdout and stderr to validate whether the test emitted
    the correct output. Because fuchsia-test-runner.py was sending all
    logs, including test output, to stdout, tests could not validate
    output properly.
    
    This change removes the runner logs from stdout and stderr entirely
    with the exception of output from the test. All runner logs are still
    available in the "log" file.
    
    Fixed: https://fxbug.dev/351356417
    c6c7 committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    54aa9e8 View commit details
    Browse the repository at this point in the history
  2. [fuchsia-test-runner] Reformat fuchsia-test-runner.py

    Applied formatting suggestions from isort and black via pylsp.
    c6c7 committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    3d5b4d8 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. Ignore fuchsia tests implicitly relying on a signal upon abort

    Both test-panic-abort-nocapture.rs and test-panic-abort.rs assert the
    stderr output of the test. On Fuchsia, if a test fails an assertion,
    this output will contain a line noting the process returned the code
    -1028 (ZX_TASK_RETCODE_EXCEPTION_KILL). But the asserted stderr output
    lacks this note. Presumably this is because other platforms implement
    -Cpanic=abort by killing the process instead of returned a status
    code.
    c6c7 authored and tmandry committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    479b0cd View commit details
    Browse the repository at this point in the history