clarify the meaning of the version number for accepted/removed features #127710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
compiler-errors
approved these changes
Jul 14, 2024
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 14, 2024
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#127083 (Add release notes for 1.80) - rust-lang#127322 (handle ci-rustc incompatible options during config parse) - rust-lang#127697 (use std for file mtime and atime modifications) - rust-lang#127704 (Fix minor typos in std::process doc on Win argv) - rust-lang#127710 (clarify the meaning of the version number for accepted/removed features) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 14, 2024
Rollup merge of rust-lang#127710 - RalfJung:features, r=compiler-errors clarify the meaning of the version number for accepted/removed features For accepted features this is pretty clear, we even use the version number in the warning that says "feature has been stabilized, please remove feature gate". For removed features we are inconsistent. [This PR](rust-lang@8cece63#diff-a82bdbaaa3c79096a30755dce8896aaf2885128a7f3f3a290072b767f05b6095) set the version to when it got removed, but [here](https://github.com/rust-lang/rust/pull/116958/files#diff-1ff08f89ad7e972538827e989fa63732c5918b4d0216ccd921de08698d6e18ca) they just got copied over so the version says when the feature was originally added. As far as I can tell, this version number is not actually used anywhere in user-visible diagnostics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For accepted features this is pretty clear, we even use the version number in the warning that says "feature has been stabilized, please remove feature gate".
For removed features we are inconsistent. This PR set the version to when it got removed, but here they just got copied over so the version says when the feature was originally added. As far as I can tell, this version number is not actually used anywhere in user-visible diagnostics.