Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add myself to the review rotation #127736

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Add myself to the review rotation #127736

merged 1 commit into from
Jul 15, 2024

Conversation

tgross35
Copy link
Contributor

rust-lang/team#1497 may need to land first.

cc @Amanieu

@rustbot
Copy link
Collaborator

rustbot commented Jul 14, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented Jul 14, 2024

triagebot.toml has been modified, there may have been changes to the review queue.

cc @davidtwco, @wesleywiser

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 14, 2024
@Amanieu
Copy link
Member

Amanieu commented Jul 15, 2024

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jul 15, 2024

📌 Commit f18d4a8 has been approved by Amanieu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 15, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 15, 2024
@matthiaskrgr
Rollup merge of rust-lang#127736 - tgross35:patch-1, r=Amanieu
499d734 
Add myself to the review rotation
This was referenced Jul 15, 2024
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 15, 2024
@bors
Auto merge of rust-lang#127777 - matthiaskrgr:rollup-qp2vkan, r=matth…
24d2ac0 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#124921 (offset_from: always allow pointers to point to the same address)
 - rust-lang#127407 (Make parse error suggestions verbose and fix spans)
 - rust-lang#127684 (consolidate miri-unleashed tests for mutable refs into one file)
 - rust-lang#127729 (Stop using the `gen` identifier in the compiler)
 - rust-lang#127736 (Add myself to the review rotation)
 - rust-lang#127758 (coverage: Restrict `ExpressionUsed` simplification to `Code` mappings)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit cd25232 into rust-lang:master Jul 15, 2024
6 checks passed
@rustbot rustbot added this to the 1.81.0 milestone Jul 15, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jul 15, 2024
@rust-timer
Unrolled build for rust-lang#127736
534000a 
Rollup merge of rust-lang#127736 - tgross35:patch-1, r=Amanieu

Add myself to the review rotation
@tgross35 tgross35 deleted the patch-1 branch July 15, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.81.0
Development

Successfully merging this pull request may close these issues.
5 participants
@tgross35 @rustbot @Amanieu @bors @Mark-Simulacrum