-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 3 pull requests #127757
Rollup of 3 pull requests #127757
Commits on Jul 14, 2024
-
std: deny(unsafe_op_in_unsafe_fn) but allow sites
This provides a list of locations to hunt down issues in.
Configuration menu - View commit details
-
Copy full SHA for 4572ed6 - Browse repository at this point
Copy the full SHA 4572ed6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 87d850d - Browse repository at this point
Copy the full SHA 87d850dView commit details -
Configuration menu - View commit details
-
Copy full SHA for ce35265 - Browse repository at this point
Copy the full SHA ce35265View commit details
Commits on Jul 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 83a0fe5 - Browse repository at this point
Copy the full SHA 83a0fe5View commit details -
Configuration menu - View commit details
-
Copy full SHA for df353a0 - Browse repository at this point
Copy the full SHA df353a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 64fb236 - Browse repository at this point
Copy the full SHA 64fb236View commit details -
Configuration menu - View commit details
-
Copy full SHA for e324602 - Browse repository at this point
Copy the full SHA e324602View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1d1cae1 - Browse repository at this point
Copy the full SHA 1d1cae1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 91ba4eb - Browse repository at this point
Copy the full SHA 91ba4ebView commit details -
Configuration menu - View commit details
-
Copy full SHA for 65da4af - Browse repository at this point
Copy the full SHA 65da4afView commit details -
Configuration menu - View commit details
-
Copy full SHA for b107cfa - Browse repository at this point
Copy the full SHA b107cfaView commit details -
Configuration menu - View commit details
-
Copy full SHA for e70cc28 - Browse repository at this point
Copy the full SHA e70cc28View commit details -
We stick to C types in for socket and address as these are at least nominally BSD-ish and they're used outside of pal/windows in general *nix code
Configuration menu - View commit details
-
Copy full SHA for f2cc943 - Browse repository at this point
Copy the full SHA f2cc943View commit details -
As with USHORT, keep using C types for BSD socket APIs.
Configuration menu - View commit details
-
Copy full SHA for 5b700a7 - Browse repository at this point
Copy the full SHA 5b700a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 286c327 - Browse repository at this point
Copy the full SHA 286c327View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8052fb8 - Browse repository at this point
Copy the full SHA 8052fb8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1b7cf3a - Browse repository at this point
Copy the full SHA 1b7cf3aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 351f1f3 - Browse repository at this point
Copy the full SHA 351f1f3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 84dd7e4 - Browse repository at this point
Copy the full SHA 84dd7e4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 21f69b5 - Browse repository at this point
Copy the full SHA 21f69b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for d8d7c5c - Browse repository at this point
Copy the full SHA d8d7c5cView commit details -
Configuration menu - View commit details
-
Copy full SHA for e2b062c - Browse repository at this point
Copy the full SHA e2b062cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8a1ce3d - Browse repository at this point
Copy the full SHA 8a1ce3dView commit details -
Configuration menu - View commit details
-
Copy full SHA for ffe8fc2 - Browse repository at this point
Copy the full SHA ffe8fc2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 816d90a - Browse repository at this point
Copy the full SHA 816d90aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2402e84 - Browse repository at this point
Copy the full SHA 2402e84View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3411a02 - Browse repository at this point
Copy the full SHA 3411a02View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e16d5f - Browse repository at this point
Copy the full SHA 7e16d5fView commit details -
Rollup merge of rust-lang#127712 - ChrisDenton:raw-types, r=workingju…
…bilee Windows: Remove some unnecessary type aliases Back in the olden days, C did not have fixed-width types so these type aliases were at least potentially useful. Nowadays, and especially in Rust, we don't need the aliases and they don't help with anything. Notably the windows bindings we use also don't bother with the aliases. And even when we have used aliases they're often only used once then forgotten about. The only one that gives me pause is `DWORD` because it's used a fair bit. But it's still used inconsistently and we implicitly assume it's a `u32` anyway (e.g. `as` casting from an `i32`).
Configuration menu - View commit details
-
Copy full SHA for 64495b5 - Browse repository at this point
Copy the full SHA 64495b5View commit details -
Rollup merge of rust-lang#127744 - workingjubilee:deny-unsafe-op-in-s…
…td, r=jhpratt std: `#![deny(unsafe_op_in_unsafe_fn)]` in platform-independent code This applies the `unsafe_op_in_unsafe_fn` lint in all places in std that _do not have platform-specific cfg in their code_. For all such places, the lint remains allowed, because they need further work to address the relevant concerns. This list includes: - `std::backtrace_rs` (internal-only) - `std::sys` (internal-only) - `std::os` Notably this eliminates all "unwrapped" unsafe operations in `std::io` and `std::sync`, which will make them much more auditable in the future. Such has *also* been left for future work. While I made a few safety comments along the way on interfaces I have grown sufficiently familiar with, in most cases I had no context, nor particular confidence the unsafety was correct. In the cases where I was able to determine the unsafety was correct without having prior context, it was obviously redundant. For example, an unsafe function calling another unsafe function that has the exact same contract, forwarding its caller's requirements just as it forwards its actual call.
Configuration menu - View commit details
-
Copy full SHA for 99c5302 - Browse repository at this point
Copy the full SHA 99c5302View commit details -
Rollup merge of rust-lang#127750 - ChrisDenton:safe-unsafe-unsafe, r=…
…workingjubilee Make os/windows and pal/windows default to `#![deny(unsafe_op_in_unsafe_fn)]` This is to prevent regressions in modules that currently pass. I did also fix up a few trivial places where the module contained only one or two simple wrappers. In more complex cases we should try to ensure the `unsafe` blocks are appropriately scoped and have any appropriate safety comments. This does not fix the windows bits of rust-lang#127747 but it should help prevent regressions until that is done and also make it more obvious specifically which modules need attention.
Configuration menu - View commit details
-
Copy full SHA for 476d399 - Browse repository at this point
Copy the full SHA 476d399View commit details