Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganize the run-make-support library #127760

Merged
merged 27 commits into from
Jul 17, 2024
Merged

Reorganize the run-make-support library #127760

merged 27 commits into from
Jul 17, 2024

Commits on Jul 17, 2024

  1. run_make_support: move impl_common_helpers into own macros module

    @jieyouxu
    jieyouxu committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    427cf94 View commit details
    Browse the repository at this point in the history

  2. run_make_support: move target checks into targets module

    @jieyouxu
    jieyouxu committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    544dda3 View commit details
    Browse the repository at this point in the history

  3. run_make_support: move env_var{,_os} into env_checked module

    @jieyouxu
    jieyouxu committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    a02008e View commit details
    Browse the repository at this point in the history

  4. run_make_support: move external deps to external_deps module

    @jieyouxu
    jieyouxu committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    288c572 View commit details
    Browse the repository at this point in the history

  5. run_make_support: cleanup and document some lib.rs reexports

    @jieyouxu
    jieyouxu committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    f042e72 View commit details
    Browse the repository at this point in the history

  6. run_make_support: move ar into own module

    @jieyouxu
    jieyouxu committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    439c6f6 View commit details
    Browse the repository at this point in the history

  7. run_make_support: move artifact name helpers into artifact_names mo… 

    …dule
    @jieyouxu
    jieyouxu committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    483328d View commit details
    Browse the repository at this point in the history

  8. run_make_support: move path-related helpers into own module

    @jieyouxu
    jieyouxu committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    dc95315 View commit details
    Browse the repository at this point in the history

  9. run_make_support: move fs helpers to own module

    @jieyouxu
    jieyouxu committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    17212ab View commit details
    Browse the repository at this point in the history

  10. run_make_support: move run_in_tmpdir and test_while_readonly to `… 

    …scoped_run` module
    @jieyouxu
    jieyouxu committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    66cef19 View commit details
    Browse the repository at this point in the history

  11. run_make_support: move assertions and helpers into own module

    @jieyouxu
    jieyouxu committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    f66d3d3 View commit details
    Browse the repository at this point in the history

  12. run_make_support: rename recursive_diff to assert_recursive_eq

    @jieyouxu
    jieyouxu committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    230804d View commit details
    Browse the repository at this point in the history

  13. tests: update rustdoc test for renamed assert_recursive_eq

    @jieyouxu
    jieyouxu committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    56cbfa8 View commit details
    Browse the repository at this point in the history

  14. run_make_support: move assert_recursive_eq into assertion_helpers

    @jieyouxu
    jieyouxu committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    88fd1df View commit details
    Browse the repository at this point in the history

  15. run_make_support: move handle_failed_output into util module

    @jieyouxu
    jieyouxu committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    e956808 View commit details
    Browse the repository at this point in the history

  16. run_make_support: make set_host_rpath private and move into util

    @jieyouxu
    jieyouxu committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    aadd085 View commit details
    Browse the repository at this point in the history

  17. run_make_support: move build_native_static_lib under external_deps 

    And fix some `ar`-related rebase mishaps.
    @jieyouxu
    jieyouxu committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    b7f7205 View commit details
    Browse the repository at this point in the history

  18. run_make_support: rename env_checked -> env

    @jieyouxu
    jieyouxu committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    a443dc4 View commit details
    Browse the repository at this point in the history

  19. run_make_support: rename cygpath_windows to get_windows_path and … 

    …move under `external_deps` as private
    @jieyouxu
    jieyouxu committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    13a1751 View commit details
    Browse the repository at this point in the history

  20. run_make_support: coalesce fs helpers into single fs module 

    There were *two* `read_dir` helpers, one being a simple
`std::fs::read_dir` wrapper, the other has a different callback-based
signature. We also rename the callback-based `read_dir` as
`read_dir_entries`.

Also don't top-level re-export most `fs::*` helpers.
    @jieyouxu
    jieyouxu committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    e1569fd View commit details
    Browse the repository at this point in the history

  21. tests: update for renamed fs module in run_make_support

    @jieyouxu
    jieyouxu committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    636be91 View commit details
    Browse the repository at this point in the history

  22. run_make_support: move some helpers from assertion to path

    @jieyouxu
    jieyouxu committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    0dfecb3 View commit details
    Browse the repository at this point in the history

  23. run_make_support: moved some helpers into string module

    @jieyouxu
    jieyouxu committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    57a2f76 View commit details
    Browse the repository at this point in the history

  24. run_make_support: rename assert_recursive_eq to `assert_dirs_are_eq… 

    …ual`
    @jieyouxu
    jieyouxu committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    30bdc4a View commit details
    Browse the repository at this point in the history

  25. tests: update rustdoc test for renamed assert_dirs_are_equal

    @jieyouxu
    jieyouxu committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    a00b860 View commit details
    Browse the repository at this point in the history

  26. run_make_support: use fs internally, but rfs to tests

    @jieyouxu
    jieyouxu committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    1f1bf4c View commit details
    Browse the repository at this point in the history

  27. tests: update for rfs rename

    @jieyouxu
    jieyouxu committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    d69cc1c View commit details
    Browse the repository at this point in the history