Rollup of 6 pull requests #127796

tgross35 · 2024-07-16T07:02:27Z

Successful merges:

Suggest a borrow when using dbg #120990 (Suggest a borrow when using dbg)
fix least significant digits of f128 associated constants #127047 (fix least significant digits of f128 associated constants)
match lowering: Move MatchPair tree creation to its own module #127709 (match lowering: Move MatchPair tree creation to its own module)
Update books #127770 (Update books)
Make sure trait def ids match before zipping args in note_function_argument_obligation #127780 (Make sure trait def ids match before zipping args in note_function_argument_obligation)
Fix typos in RELEASES.md #127795 (Fix typos in RELEASES.md)

r? @ghost
@rustbot modify labels: rollup

While the numbers are parsed to the correct value, the decimal numbers in the source were rounded to zero instead of to the nearest, making the literals different from the values shown in the documentation.

This makes it easier to see that `MatchPair::new` has only one non-recursive caller, because the recursive callers are all in this module.

…gument_obligation

as requested in rust-lang/blog.rust-lang.org#1358 (comment)

…r=oli-obk Suggest a borrow when using dbg Fixes rust-lang#120327 r? ````@estebank````

fix least significant digits of f128 associated constants While the numbers are parsed to the correct value, the decimal numbers in the source were rounded to zero instead of to the nearest, making the literals different from the values shown in the documentation.

match lowering: Move `MatchPair` tree creation to its own module This makes it easier to see that `MatchPair::new` has only one non-recursive caller, because the recursive callers are all in this module. No functional changes. --- I have used `git diff --color-moved` to verify that the moved code is identical to the old code, except for reduced visibility on the helper methods.

Update books ## rust-lang/book 3 commits in f1e49bf7a8ea6c31ce016a52b8a4f6e1ffcfbc64..67fa536768013d9d5a13f3a06790521d511ef711 2024-07-12 21:21:45 UTC to 2024-07-05 17:35:06 UTC - Use Rust 2021 Edition for mdBook (rust-lang/book#3974) - Backport changes to chapter 11 (rust-lang/book#3969) - Upgrade to Rust 1.79.0 (rust-lang/book#3968) ## rust-lang/edition-guide 2 commits in 941db8b3df45fd46cd87b50a5c86714b91dcde9c..5454de3d12b9ccc6375b629cf7ccda8264640aac 2024-07-14 07:06:34 UTC to 2024-07-12 06:05:29 UTC - Update timeline etc. for Rust 2024 - 2024: Add note about never_type_fallback_flowing_into_unsafe lint level. (rust-lang/edition-guide#311) ## rust-embedded/book 1 commits in b10c6acaf0f43481f6600e95d4b5013446e29f7a..019f3928d8b939ec71b63722dcc2e46330156441 2024-07-11 17:46:10 UTC to 2024-07-11 17:46:10 UTC - typo on tooling.md (rust-embedded/book#373) ## rust-lang/reference 9 commits in 1ae3deebc3ac16e276b6558e01420f8e605def08..e2f0bdc4031866734661dcdb548184bde1450baf 2024-06-29 16:59:51 +0000 to 2024-07-15 17:52:44 +0000 - Suppress type length limit test and note that it is not enforced (rust-lang/reference#1527) - elaborate on slice wide pointer metadata (rust-lang/reference#1499) - '.inst' in inline-assembly changed to '.insn' (rust-lang/reference#1453) - Clarify that `asm!` blocks can be duplicated or deduplicated by the compiler (rust-lang/reference#1441) - Add mdbook-spec (rust-lang/reference#1520) - Add note about static libraries not linking their dependencies (rust-lang/reference#1472) - more explicitly explain the UB around immutable extern statics (rust-lang/reference#1502) - Improvements to `items/functions.md` (rust-lang/reference#1458) - Enable mdbook smart-punctuation. (rust-lang/reference#1516) ## rust-lang/rust-by-example 1 commits in 658c6c27cb975b92227936024816986c2d3716fb..89aecb6951b77bc746da73df8c9f2b2ceaad494a 2024-07-11 12:33:43 UTC to 2024-07-11 12:33:43 UTC - Update option_result.md (rust-lang/rust-by-example#1864) ## rust-lang/rustc-dev-guide 6 commits in d6e3a32a557db5902e714604def8015d6bb7e0f7..0c4d55cb59fe440d1a630e4e5774d043968edb3f 2024-07-15 15:16:43 UTC to 2024-07-01 19:05:14 UTC - Improve documentation of MIR queries & passes (rust-lang/rustc-dev-guide#1434) - Bump dependencies for date-check tool (rust-lang/rustc-dev-guide#2012) - Fix typo: lists -> lints (rust-lang/rustc-dev-guide#2011) - use "bootstrap" instead of "rustbuild" (rust-lang/rustc-dev-guide#2010) - Fix grammar issue in optimize-build.md (rust-lang/rustc-dev-guide#2009) - Update name of Fuchsia builder (rust-lang/rustc-dev-guide#2008)

Make sure trait def ids match before zipping args in `note_function_argument_obligation` Fixes rust-lang#126416 Fixes rust-lang#127745 Didn't add both tests b/c I felt like it was unnecessary.

Fix typos in RELEASES.md as requested in rust-lang/blog.rust-lang.org#1358 (comment) r? `@cuviper`

tgross35 · 2024-07-16T07:02:44Z

@bors r+ rollup=never p=5

bors · 2024-07-16T07:02:47Z

📌 Commit 658a13d has been approved by tgross35

It is now in the queue for this repository.

bors · 2024-07-16T08:33:15Z

⌛ Testing commit 658a13d with merge 5572759...

rust-highfive · 2024-07-16T10:52:15Z

📣 Toolstate changed by #127796!

Tested on commit 5572759.
Direct link to PR: #127796

🎉 reference on windows: test-fail → test-pass (cc @Havvy @ehuss @matthewjasper).
🎉 reference on linux: test-fail → test-pass (cc @Havvy @ehuss @matthewjasper).

@Havvy

Tested on commit rust-lang/rust@5572759. Direct link to PR: <rust-lang/rust#127796> 🎉 reference on windows: test-fail → test-pass (cc @Havvy @ehuss @matthewjasper). 🎉 reference on linux: test-fail → test-pass (cc @Havvy @ehuss @matthewjasper).

bors · 2024-07-16T10:53:21Z

☀️ Test successful - checks-actions
Approved by: tgross35
Pushing 5572759 to master...

rust-timer · 2024-07-16T10:55:03Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#120990	Suggest a borrow when using dbg	`46eeec212d8abfb98762279587b3f2b7355be971` (link)
#127047	fix least significant digits of f128 associated constants	`e08ba1d94bfca3452982b415a9b9c0f0ba7a5dd7` (link)
#127709	match lowering: Move `MatchPair` tree creation to its own m…	`d3a617d0b9630c66e2843131c33f0b356984c15c` (link)
#127770	Update books	`53e62946bf90f6fb834be51b911e64ffeb6414d2` (link)
#127780	Make sure trait def ids match before zipping args in `note_…	`dc1232fb9ba0f11c28d4f833ec7965cfcd2da7ca` (link)
#127795	Fix typos in RELEASES.md	`46e5e3694eb04478c929249ab40e1cf66c0f330e` (link)

previous master: 2823cfb1e5

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2024-07-16T12:10:12Z

Finished benchmarking commit (5572759): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -1.6%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.9%	[0.5%, 1.3%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-6.6%	[-6.6%, -6.6%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-1.6%	[-6.6%, 1.3%]	3

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 699.505s -> 700.256s (0.11%)
Artifact size: 328.65 MiB -> 328.62 MiB (-0.01%)

tspiteri and others added 14 commits June 27, 2024 18:31

fix least significant digits of f128 associated constants

dab77c5

While the numbers are parsed to the correct value, the decimal numbers in the source were rounded to zero instead of to the nearest, making the literals different from the values shown in the documentation.

Move MatchPair tree creation to its own module

ce86b2a

This makes it easier to see that `MatchPair::new` has only one non-recursive caller, because the recursive callers are all in this module.

Improve internal docs for MatchPair

f7508f8

Update books

ee86e2d

Update reference to fix toolstate

3051436

Suggest a borrow when using dbg

3179526

Make sure trait def ids match before zipping args in note_function_ar…

841b30f

…gument_obligation

Fix typos in RELEASES.md

47d8d3d

as requested in rust-lang/blog.rust-lang.org#1358 (comment)

Rollup merge of rust-lang#120990 - chenyukang:yukang-fix-120327-dbg, …

12fd2f9

…r=oli-obk Suggest a borrow when using dbg Fixes rust-lang#120327 r? ````@estebank````

Rollup merge of rust-lang#127780 - compiler-errors:zip-args, r=jieyouxu

1abed9f

Make sure trait def ids match before zipping args in `note_function_argument_obligation` Fixes rust-lang#126416 Fixes rust-lang#127745 Didn't add both tests b/c I felt like it was unnecessary.

Rollup merge of rust-lang#127795 - programmerjake:patch-3, r=cuviper

658a13d

Fix typos in RELEASES.md as requested in rust-lang/blog.rust-lang.org#1358 (comment) r? `@cuviper`

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 16, 2024

bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 16, 2024

bors merged commit 5572759 into rust-lang:master Jul 16, 2024
7 checks passed

rustbot added this to the 1.81.0 milestone Jul 16, 2024

This was referenced Jul 16, 2024

Support mcdc analysis for pattern matching #124278

Open

Solve a error .clone() suggestion when moving a mutable reference #127579

Merged

tgross35 deleted the rollup-ubo5hzb branch July 19, 2024 19:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 6 pull requests #127796

Rollup of 6 pull requests #127796

tgross35 commented Jul 16, 2024

tgross35 commented Jul 16, 2024

bors commented Jul 16, 2024

bors commented Jul 16, 2024

rust-highfive commented Jul 16, 2024

bors commented Jul 16, 2024

rust-timer commented Jul 16, 2024

rust-timer commented Jul 16, 2024

Rollup of 6 pull requests #127796

Rollup of 6 pull requests #127796

Conversation

tgross35 commented Jul 16, 2024

tgross35 commented Jul 16, 2024

bors commented Jul 16, 2024

bors commented Jul 16, 2024

rust-highfive commented Jul 16, 2024

bors commented Jul 16, 2024

rust-timer commented Jul 16, 2024

rust-timer commented Jul 16, 2024

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size