Rollup of 8 pull requests #127819
Merged
Rollup of 8 pull requests #127819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to see that the split point is always the index after the found item, or the whole list if no stopping point was found.
this is redundant, so we can just delete it.
… impossible for visitor impls to look at these values
…, r=nnethercote Fix the issue of invalid suggestion for a reference of iterator Fixes rust-lang#127590
match lowering: Use an iterator to find `expand_until` A small cleanup that I noticed while looking at rust-lang#127164. This makes it easier to see that the split point is always the index after the found item, or the whole list if no stopping point was found. r? `@Nadrieril`
…petrochenkov Fix and enforce `unsafe_op_in_unsafe_fn` in compiler In preparation for edition 2024, this PR previews the fallout of enabling the `unsafe_op_in_unsafe_fn` lint in the compiler, since it's defaulting to warn in the new edition (rust-lang#112038). The major annoyance comes primarily from the `rustc_codegen_llvm` module, where there's a ton of unsafe calls. I tended to wrap individual calls to unsafe fns in `unsafe {}`, but there a handful of places I chose to just wrap several calls in an `unsafe {}` block just because it would've been excessive to wrap each call individually. This doesn't enable the lint for the standard library, since I'm not totally certain what T-libs prefers w/ this lint.
delete #![allow(unsafe_op_in_unsafe_fn)] in teeos deny unsafe_op_in_unsafe_fn for teeos
…jieyouxu run-make-support: update gimli to 0.31.0 This version bump is required for the tests in rust-lang#126985 as suggested [here](rust-lang#126985 (comment)). r? tgross35 (^ that didn't work. cc `@tgross35)` try-job: x86_64-msvc try-job: x86_64-mingw try-job: aarch64-apple try-job: test-various try-job: armhf-gnu try-job: dist-x86_64-linux
…,nnethercote Make ErrorGuaranteed discoverable outside types, consts, and lifetimes types like `PatKind` could contain `ErrorGuaranteed`, but not return them via `tainted_by_errors` or `error_reported` (see rust-lang#127687 (comment)). Now this happens, but it's a bit fragile as you can see with the `TypeSuperVisitable for Ty` impl. We will catch any problems around Ty, Region or Const at runtime with an assert, and everything using derives will not have such issues, as it will just invoke the `TypeVisitable for ErrorGuaranteed` impl
…enkov Fix a bunch of sites that were walking instead of visiting, making it impossible for visitor impls to look at these values This doesn't affects anything right now, but a `MutVisitor` impl could be surprised by this. The reason this doesn't affect anything is that no one overrrides `visit_lifetime` or `visit_param_bounds` currently.
…ions, r=petrochenkov Various ast validation simplifications Changes pulled out of rust-lang#127524 These are needed to make ast validation a mutable visitor, as we can't keep immutable references to the AST around in that case. But I think they are simplifying things in general and can stand on their own
rustbot
added
A-run-make
|
@bors r+ rollup=never p=8 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR:
previous master: a91f7d72f1 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Jul 16, 2024
Closed
|
Finished benchmarking commit (16b5690): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 700.14s -> 699.147s (-0.14%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
expand_until#127707 (match lowering: Use an iterator to findexpand_until)unsafe_op_in_unsafe_fnin compiler #127730 (Fix and enforceunsafe_op_in_unsafe_fnin compiler)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup