Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite and rename issue-14698. issue-33329 and issue-107094 run-make tests to rmake or ui #127820

Merged
merged 3 commits into from
Jul 22, 2024
Merged

Rewrite and rename issue-14698. issue-33329 and issue-107094 run-make tests to rmake or ui #127820

merged 3 commits into from
Jul 22, 2024

Conversation

Oneirical
Copy link
Contributor

@Oneirical Oneirical commented Jul 16, 2024 •
edited by jieyouxu
Loading

Part of #121876 and the associated Google Summer of Code project.

try-job: armhf-gnu
try-job: test-various
try-job: aarch64-apple
try-job: x86_64-msvc

@rustbot
Copy link
Collaborator

rustbot commented Jul 16, 2024

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 16, 2024
@rustbot
Copy link
Collaborator

rustbot commented Jul 16, 2024

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Kobzol Kobzol mentioned this pull request Jul 17, 2024
Open
@Kobzol Kobzol changed the title Rewrite and rename issue-14698. issue-33329 and issue-10794 run-make tests to rmake or ui Rewrite and rename issue-14698. issue-33329 and issue-107094 run-make tests to rmake or ui Jul 17, 2024
@jieyouxu
Copy link
Member

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 17, 2024
@bors
Auto merge of rust-lang#127820 - Oneirical:intestellar-travel, r=<try>
33935cc 
Rewrite and rename `issue-14698`. `issue-33329` and `issue-107094` `run-make` tests to rmake or ui

Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html).

try-job: armhf-gnu
try-job: test-various
try-job: aarch64-apple
try-job: x86_64-msvc
@bors
Copy link
Contributor

bors commented Jul 17, 2024

⌛ Trying commit 6ef6243 with merge 33935cc...

@bors
Copy link
Contributor

bors commented Jul 17, 2024

☀️ Try build successful - checks-actions
Build commit: 33935cc (33935ccd6a3885667a569d6825450436544214ae)

@jieyouxu
Copy link
Member

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 18, 2024
@Oneirical
Copy link
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 18, 2024
@jieyouxu
Copy link
Member

Thanks!
@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jul 20, 2024

📌 Commit 1a0baaa has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 20, 2024
@tgross35 tgross35 mentioned this pull request Jul 20, 2024
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 20, 2024
@matthiaskrgr
Rollup merge of rust-lang#127820 - Oneirical:intestellar-travel, r=ji…
f31c7a5 
…eyouxu

Rewrite and rename `issue-14698`. `issue-33329` and `issue-107094` `run-make` tests to rmake or ui

Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html).

try-job: armhf-gnu
try-job: test-various
try-job: aarch64-apple
try-job: x86_64-msvc
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 20, 2024
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 20, 2024
@matthiaskrgr
Rollup merge of rust-lang#127820 - Oneirical:intestellar-travel, r=ji…
8a86059 
…eyouxu

Rewrite and rename `issue-14698`. `issue-33329` and `issue-107094` `run-make` tests to rmake or ui

Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html).

try-job: armhf-gnu
try-job: test-various
try-job: aarch64-apple
try-job: x86_64-msvc
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 20, 2024
Closed
@bors
Copy link
Contributor

bors commented Jul 20, 2024

☔ The latest upstream changes (presumably #127663) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 20, 2024
@Oneirical
Copy link
Contributor Author

Conflict removed, please re-approve.
@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 22, 2024
@jieyouxu
Copy link
Member

Thanks!

bors-r+

@bors
Copy link
Contributor

bors commented Jul 22, 2024

📌 Commit 8990df7 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 22, 2024
@tgross35 tgross35 mentioned this pull request Jul 22, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 22, 2024
@bors
Auto merge of rust-lang#128063 - tgross35:rollup-hsxmptf, r=tgross35
2a1c384 
Rollup of 9 pull requests

Successful merges:

 - rust-lang#117932 (Correct rustdoc section where we talk about rustdoc emitting errors on invalid code)
 - rust-lang#125990 (Rename `deprecated_safe` lint to `deprecated_safe_2024`)
 - rust-lang#127506 (rustc_target: add known safe s390x target features)
 - rust-lang#127820 (Rewrite and rename `issue-14698`. `issue-33329` and `issue-107094` `run-make` tests to rmake or ui)
 - rust-lang#127923 (Use reuse tool 4.0)
 - rust-lang#128008 (Start using `#[diagnostic::do_not_recommend]` in the standard library)
 - rust-lang#128036 (add more tests)
 - rust-lang#128051 (rustdoc: revert spacing change in item-table)
 - rust-lang#128059 (Add regression test for items list size (rust-lang#128023))

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 3ba92be into rust-lang:master Jul 22, 2024
6 checks passed
@rustbot rustbot added this to the 1.82.0 milestone Jul 22, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jul 22, 2024
@rust-timer
Unrolled build for rust-lang#127820
ba20784 
Rollup merge of rust-lang#127820 - Oneirical:intestellar-travel, r=jieyouxu

Rewrite and rename `issue-14698`. `issue-33329` and `issue-107094` `run-make` tests to rmake or ui

Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html).

try-job: armhf-gnu
try-job: test-various
try-job: aarch64-apple
try-job: x86_64-msvc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu jieyouxu left review comments

Assignees

@jieyouxu jieyouxu

Labels
A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
Oxidizing run-make tests
Status: Done
Milestone
1.82.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Oneirical @rustbot @rust-log-analyzer @jieyouxu @bors