Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#[naked]: report incompatible attributes #127853

Merged
merged 7 commits into from
Jul 28, 2024
Merged

#[naked]: report incompatible attributes #127853

merged 7 commits into from
Jul 28, 2024

Commits on Jul 16, 2024

  1. update text for E0736 and E0739

    @folkertdev
    folkertdev committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    ceec6dd View commit details
    Browse the repository at this point in the history

  2. improve error message when #[naked] is used with #[inline]

    @folkertdev
    folkertdev committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    4bd3632 View commit details
    Browse the repository at this point in the history

  3. improve error message when #[naked] is used with `#[track-caller] a… 

    …nd `#[target-feature]``
    @folkertdev
    folkertdev committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    7e6c083 View commit details
    Browse the repository at this point in the history

  4. add error message when #[naked] is used with #[test]

    @folkertdev
    folkertdev committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    4d082b7 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2024

  1. switch to an allowlist approach 

    - merge error codes
- use attribute name that is incompatible in error message
- add test for conditional incompatible attribute
- add `linkage` to the allowlist
    @folkertdev
    folkertdev committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    c6a166b View commit details
    Browse the repository at this point in the history

  2. allow #[target_feature] on #[naked] functions

    @folkertdev
    folkertdev committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    a3bb010 View commit details
    Browse the repository at this point in the history

  3. fix tests/ui/asm/naked-functions.rs for aarch64

    @folkertdev
    folkertdev committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    c7e688e View commit details
    Browse the repository at this point in the history