Don't elaborate associated types with Sized bounds in trait_object_ty in cfi
#127882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
PG-exploit-mitigations
compiler-errors
commented
Jul 17, 2024
| // Check that we only elaborate non-`Self: Sized` associated types when | ||
| // erasing the receiver from trait ref. | ||
|
|
||
| //@ revisions: cfi kcfi |
There was a problem hiding this comment.
Just copied this from another test.
|
This looks correct to me. |
|
LGTM (@pnkfelix FYI). Thank you for your time and for working on this, @compiler-errors! Much appreciated. |
|
r? compiler |
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 29, 2024
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#127882 (Don't elaborate associated types with Sized bounds in `trait_object_ty` in cfi) - rust-lang#128174 (Don't record trait aliases as marker traits) - rust-lang#128202 (Tell users not to file a bug when using internal library features) - rust-lang#128239 (Don't ICE when encountering error regions when confirming object method candidate) - rust-lang#128337 (skip assoc type during infer source visitor) - rust-lang#128341 (Make `rustc_attr::parse_version` pub) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 29, 2024
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#127882 (Don't elaborate associated types with Sized bounds in `trait_object_ty` in cfi) - rust-lang#128174 (Don't record trait aliases as marker traits) - rust-lang#128202 (Tell users not to file a bug when using internal library features) - rust-lang#128239 (Don't ICE when encountering error regions when confirming object method candidate) - rust-lang#128337 (skip assoc type during infer source visitor) - rust-lang#128341 (Make `rustc_attr::parse_version` pub) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 29, 2024
Rollup merge of rust-lang#127882 - compiler-errors:cfi-sized-self-gat, r=oli-obk Don't elaborate associated types with Sized bounds in `trait_object_ty` in cfi The elaboration mechanism introduced in rust-lang#123005 didn't filter for associated types with `Self: Sized` bounds, which since rust-lang#112319 has excluded them from the object type. Fixes rust-lang#127881 cc `@maurer` `@rcvalle`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The elaboration mechanism introduced in #123005 didn't filter for associated types with
Self: Sizedbounds, which since #112319 has excluded them from the object type.Fixes #127881
cc @maurer @rcvalle