-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 9 pull requests #127896
Rollup of 9 pull requests #127896
Commits on Jul 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 2f305ff - Browse repository at this point
Copy the full SHA 2f305ffView commit details -
Inline
Parser::parse_item_common_
.It has a single call site, it isn't that big, and its name is confusingly similar to `Parser::parse_item_common`.
Configuration menu - View commit details
-
Copy full SHA for 48cdfc3 - Browse repository at this point
Copy the full SHA 48cdfc3View commit details -
Reorder
Parser::parse_expr_dot_or_call_with
arguments.Put `attrs` before `e0` because that matches the order in the source code, where outer attributes appear before expressions.
Configuration menu - View commit details
-
Copy full SHA for d247489 - Browse repository at this point
Copy the full SHA d247489View commit details -
Inline and remove
Parser::parse_and_disallow_postfix_after_cast
.It has a single call site. Removing it removes the need for an `ExprKind` check. The commit also clarifies the relevant comment.
Configuration menu - View commit details
-
Copy full SHA for 96cc9c9 - Browse repository at this point
Copy the full SHA 96cc9c9View commit details -
Inline and remove
Parser::parse_expr_dot_or_call_with_
.It only has two call sites, and it extremely similar to `Parser::parse_expr_dot_or_call_with`, in both name and behaviour. The only difference is the latter has an `attrs` argument and an `ensure_sufficient_stack` call. We can pass in an empty `attrs` as necessary, as is already done at some `parse_expr_dot_or_call_with` call sites.
Configuration menu - View commit details
-
Copy full SHA for 96b39f1 - Browse repository at this point
Copy the full SHA 96b39f1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8cb6bc3 - Browse repository at this point
Copy the full SHA 8cb6bc3View commit details -
Remove references to
maybe_whole_expr
.It was removed in rust-lang#126571.
Configuration menu - View commit details
-
Copy full SHA for 9c4f3db - Browse repository at this point
Copy the full SHA 9c4f3dbView commit details
Commits on Jul 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 538b31e - Browse repository at this point
Copy the full SHA 538b31eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2162f3f - Browse repository at this point
Copy the full SHA 2162f3fView commit details -
Configuration menu - View commit details
-
Copy full SHA for a651050 - Browse repository at this point
Copy the full SHA a651050View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8d90f44 - Browse repository at this point
Copy the full SHA 8d90f44View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0b5ce54 - Browse repository at this point
Copy the full SHA 0b5ce54View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5483945 - Browse repository at this point
Copy the full SHA 5483945View commit details -
Configuration menu - View commit details
-
Copy full SHA for f54fa62 - Browse repository at this point
Copy the full SHA f54fa62View commit details -
Configuration menu - View commit details
-
Copy full SHA for a9e1466 - Browse repository at this point
Copy the full SHA a9e1466View commit details -
Configuration menu - View commit details
-
Copy full SHA for a8b6e3f - Browse repository at this point
Copy the full SHA a8b6e3fView commit details -
Fix associated item removal suggestion
We were previously telling people to write what was already there, instead of removal. ``` error[E0229]: associated item constraints are not allowed here --> $DIR/E0229.rs:13:25 | LL | fn baz<I>(x: &<I as Foo<A = Bar>>::A) {} | ^^^^^^^ associated item constraint not allowed here | help: consider removing this associated item binding | LL - fn baz<I>(x: &<I as Foo<A = Bar>>::A) {} LL + fn baz<I>(x: &<I as Foo>::A) {} | ```
Configuration menu - View commit details
-
Copy full SHA for e38032f - Browse repository at this point
Copy the full SHA e38032fView commit details
Commits on Jul 18, 2024
-
Accurate
use
rename suggestion spanWhen suggesting to rename an import with `as`, use a smaller span to render the suggestion with a better format: ``` error[E0252]: the name `baz` is defined multiple times --> $DIR/issue-25396.rs:4:5 | LL | use foo::baz; | -------- previous import of the module `baz` here LL | use bar::baz; | ^^^^^^^^ `baz` reimported here | = note: `baz` must be defined only once in the type namespace of this module help: you can use `as` to change the binding name of the import | LL | use bar::baz as other_baz; | ++++++++++++ ```
Configuration menu - View commit details
-
Copy full SHA for 8eb5185 - Browse repository at this point
Copy the full SHA 8eb5185View commit details -
More accurate span for type parameter suggestion
After: ``` error[E0229]: associated item constraints are not allowed here --> $DIR/impl-block-params-declared-in-wrong-spot-issue-113073.rs:3:10 | LL | impl Foo<T: Default> for String {} | ^^^^^^^^^^ associated item constraint not allowed here | help: declare the type parameter right after the `impl` keyword | LL - impl Foo<T: Default> for String {} LL + impl<T: Default> Foo<T> for String {} | ``` Before: ``` error[E0229]: associated item constraints are not allowed here --> $DIR/impl-block-params-declared-in-wrong-spot-issue-113073.rs:3:10 | LL | impl Foo<T: Default> for String {} | ^^^^^^^^^^ associated item constraint not allowed here | help: declare the type parameter right after the `impl` keyword | LL | impl<T: Default> Foo<T> for String {} | ++++++++++++ ~ ```
Configuration menu - View commit details
-
Copy full SHA for be9d961 - Browse repository at this point
Copy the full SHA be9d961View commit details -
More accurate span for anonymous argument suggestion
Use smaller span for suggesting adding `_:` ahead of a type: ``` error: expected one of `(`, `...`, `..=`, `..`, `::`, `:`, `{`, or `|`, found `)` --> $DIR/anon-params-denied-2018.rs:12:47 | LL | fn foo_with_qualified_path(<Bar as T>::Baz); | ^ expected one of 8 possible tokens | = note: anonymous parameters are removed in the 2018 edition (see RFC 1685) help: explicitly ignore the parameter name | LL | fn foo_with_qualified_path(_: <Bar as T>::Baz); | ++ ```
Configuration menu - View commit details
-
Copy full SHA for f6c4679 - Browse repository at this point
Copy the full SHA f6c4679View commit details -
Rollup merge of rust-lang#127077 - tbu-:pr_doc_fd_to_owned, r=working…
…jubilee Make language around `ToOwned` for `BorrowedFd` more precise
Configuration menu - View commit details
-
Copy full SHA for 483161d - Browse repository at this point
Copy the full SHA 483161dView commit details -
Rollup merge of rust-lang#127523 - Oneirical:treasure-test, r=jieyouxu
Migrate `dump-ice-to-disk` and `panic-abort-eh_frame` `run-make` tests to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). Please try: try-job: x86_64-msvc
Configuration menu - View commit details
-
Copy full SHA for c0cd3ca - Browse repository at this point
Copy the full SHA c0cd3caView commit details -
Rollup merge of rust-lang#127787 - Rejyr:migrate-atomic-lock-free-rma…
…ke, r=jieyouxu Migrate `atomic-lock-free` to `rmake` Also adds `llvm_components_contain` to `run-make-support`. Part of rust-lang#121876. r? `@jieyouxu` try-job: dist-x86_64-linux
Configuration menu - View commit details
-
Copy full SHA for af30f40 - Browse repository at this point
Copy the full SHA af30f40View commit details -
Rollup merge of rust-lang#127806 - nnethercote:parser-improvements, r…
…=spastorino Some parser improvements I was looking closely at attribute handling in the parser while debugging some issues relating to rust-lang#124141, and found a few small improvements. ```@spastorino```
Configuration menu - View commit details
-
Copy full SHA for caf888c - Browse repository at this point
Copy the full SHA caf888cView commit details -
Rollup merge of rust-lang#127810 - compiler-errors:less-tcx, r=lcnr
Rename `tcx` to `cx` in `rustc_type_ir` Self-explanatory. Forgot that we had to do this in type_ir too, and not just the new solver crate lol. r? lcnr
Configuration menu - View commit details
-
Copy full SHA for fe9940c - Browse repository at this point
Copy the full SHA fe9940cView commit details -
Rollup merge of rust-lang#127878 - estebank:assoc-item-removal, r=fmease
Fix associated item removal suggestion We were previously telling people to write what was already there, instead of removal (treating it as a `help`). We now properly suggest to remove the code that needs to be removed. ``` error[E0229]: associated item constraints are not allowed here --> $DIR/E0229.rs:13:25 | LL | fn baz<I>(x: &<I as Foo<A = Bar>>::A) {} | ^^^^^^^ associated item constraint not allowed here | help: consider removing this associated item binding | LL - fn baz<I>(x: &<I as Foo<A = Bar>>::A) {} LL + fn baz<I>(x: &<I as Foo>::A) {} | ```
Configuration menu - View commit details
-
Copy full SHA for 9b001ce - Browse repository at this point
Copy the full SHA 9b001ceView commit details -
Rollup merge of rust-lang#127886 - estebank:as-rename-suggestion, r=c…
…ompiler-errors Accurate `use` rename suggestion span When suggesting to rename an import with `as`, use a smaller span to render the suggestion with a better format: ``` error[E0252]: the name `baz` is defined multiple times --> $DIR/issue-25396.rs:4:5 | LL | use foo::baz; | -------- previous import of the module `baz` here LL | use bar::baz; | ^^^^^^^^ `baz` reimported here | = note: `baz` must be defined only once in the type namespace of this module help: you can use `as` to change the binding name of the import | LL | use bar::baz as other_baz; | ++++++++++++ ```
Configuration menu - View commit details
-
Copy full SHA for a5fd37e - Browse repository at this point
Copy the full SHA a5fd37eView commit details -
Rollup merge of rust-lang#127888 - estebank:type-param-sugg, r=compil…
…er-errors More accurate span for type parameter suggestion After: ``` error[E0229]: associated item constraints are not allowed here --> $DIR/impl-block-params-declared-in-wrong-spot-issue-113073.rs:3:10 | LL | impl Foo<T: Default> for String {} | ^^^^^^^^^^ associated item constraint not allowed here | help: declare the type parameter right after the `impl` keyword | LL - impl Foo<T: Default> for String {} LL + impl<T: Default> Foo<T> for String {} | ``` Before: ``` error[E0229]: associated item constraints are not allowed here --> $DIR/impl-block-params-declared-in-wrong-spot-issue-113073.rs:3:10 | LL | impl Foo<T: Default> for String {} | ^^^^^^^^^^ associated item constraint not allowed here | help: declare the type parameter right after the `impl` keyword | LL | impl<T: Default> Foo<T> for String {} | ++++++++++++ ~ ```
Configuration menu - View commit details
-
Copy full SHA for 1bdc0fb - Browse repository at this point
Copy the full SHA 1bdc0fbView commit details -
Rollup merge of rust-lang#127889 - estebank:anon-arg-sugg, r=compiler…
…-errors More accurate span for anonymous argument suggestion Use smaller span for suggesting adding `_:` ahead of a type: ``` error: expected one of `(`, `...`, `..=`, `..`, `::`, `:`, `{`, or `|`, found `)` --> $DIR/anon-params-denied-2018.rs:12:47 | LL | fn foo_with_qualified_path(<Bar as T>::Baz); | ^ expected one of 8 possible tokens | = note: anonymous parameters are removed in the 2018 edition (see RFC 1685) help: explicitly ignore the parameter name | LL | fn foo_with_qualified_path(_: <Bar as T>::Baz); | ++ ```
Configuration menu - View commit details
-
Copy full SHA for 6973719 - Browse repository at this point
Copy the full SHA 6973719View commit details