Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing GHA group for building llvm-bitcode-linker #127901

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Jul 18, 2024

Found while investigating #127869.

r? @onur-ozkan

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jul 18, 2024
@Kobzol Kobzol force-pushed the llvm-bitcode-linker-gha-group branch from 4c233c0 to 69157bd Compare July 18, 2024 08:08
@Kobzol
Copy link
Contributor Author

Kobzol commented Jul 18, 2024

I wonder if we should eventually do this automatically somehow, e.g. by returning something like WithGroup<CargoCommand> from prepare_tool_cargo, which could automatically open/close groups in constructor/Drop.

@onur-ozkan
Copy link
Member

I wonder if we should eventually do this automatically somehow, e.g. by returning something like WithGroup<CargoCommand> from prepare_tool_cargo, which could automatically open/close groups in constructor/Drop.

Good idea, we can probably do the similar thing in other modules (e.g., check.rs) too. Feel free to r=me if you don't want to handle them in this PR.

@Kobzol
Copy link
Contributor Author

Kobzol commented Jul 18, 2024

Yeah this will require some experimentation, I don't want to do that in this PR.

@bors r=onur-ozkan rollup

@bors
Copy link
Contributor

bors commented Jul 18, 2024

📌 Commit 69157bd has been approved by onur-ozkan

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 18, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 18, 2024
Rollup of 7 pull requests

Successful merges:

 - rust-lang#127491 (Migrate 8 very similar FFI `run-make` tests to rmake)
 - rust-lang#127687 (Const-to-pattern-to-MIR cleanup)
 - rust-lang#127822 (Migrate `issue-85401-static-mir`, `missing-crate-dependency` and `unstable-flag-required` `run-make` tests to rmake)
 - rust-lang#127842 (Remove `TrailingToken`.)
 - rust-lang#127864 (cleanup: remove support for 3DNow! cpu features)
 - rust-lang#127899 (Mark myself as on leave)
 - rust-lang#127901 (Add missing GHA group for building `llvm-bitcode-linker`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 16d2b61 into rust-lang:master Jul 18, 2024
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jul 18, 2024
Rollup merge of rust-lang#127901 - Kobzol:llvm-bitcode-linker-gha-group, r=onur-ozkan

Add missing GHA group for building `llvm-bitcode-linker`

Found while investigating rust-lang#127869.

r? `@onur-ozkan`
@rustbot rustbot added this to the 1.81.0 milestone Jul 18, 2024
@Kobzol Kobzol deleted the llvm-bitcode-linker-gha-group branch July 18, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants