-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add limit for unclosed delimiters in lexer diagnostic #127955
Add limit for unclosed delimiters in lexer diagnostic #127955
Conversation
rustbot has assigned @michaelwoerister. Use |
fcdbd21
to
b35d173
Compare
r? lexer |
tests/ui/parser/mismatched-delimiter-corner-case-issue-127868.rs
Outdated
Show resolved
Hide resolved
Thanks for splitting this into two commits, it helps with the reviewing :) r=me once the minor comments above are addressed. |
b35d173
to
52bc90c
Compare
@bors r=nnethercote |
This comment has been minimized.
This comment has been minimized.
52bc90c
to
94a3fd7
Compare
@bors r=nnethercote |
☀️ Test successful - checks-actions |
Finished benchmarking commit (595316b): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary -0.2%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (primary 2.6%, secondary -2.5%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 769.935s -> 768.761s (-0.15%) |
Fixes #127868
The first commit shows the original diagnostic, and the second commit shows the changes.