Return Option rather than fail for slice_shift_char and {shift,pop}_{char,byte}
#12797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -3600,6 +3612,22 @@ mod tests { | |||
| } | |||
|
|
|||
| #[test] | |||
| fn test_slice_shift_char() { | |||
| let data = "ประเทศไทย中"; | |||
| let (cc, rest) = data.slice_shift_char(); | |||
There was a problem hiding this comment.
This test could be assert_eq!(data.slice_shift_char(), (Some('ป'), "ระเทศไทย中")) (and below too).
|
This looks great, thanks! Just a small comment from me and @huonw, and I think this is good to go. |
| @@ -3148,7 +3159,7 @@ mod tests { | |||
| let mut data = ~"ประเทศไทย中华"; | |||
| let cc = data.pop_char(); | |||
| assert_eq!(~"ประเทศไทย中", data); | |||
| assert_eq!('华', cc); | |||
| assert_eq!('华', cc.unwrap()); | |||
There was a problem hiding this comment.
Could you convert all of the unwraps you added to comparing against Some('...')? It makes test failures much easier to diagnose.
…yte` and `pop_byte` to return an Option instead of failing
bors
added a commit
that referenced
this pull request
Mar 12, 2014
Along the lines of `shift_ref` and `pop_ref`.
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Aug 9, 2022
…data, r=Veykril feat: support associated values in "Generate Enum Variant" assist This change adds support for associated values to the "Generate Enum Variant" assist. I've split the implementation out into 4 steps to make code review easier: - Add "add_variant" support to the structural ast editing system in `edit_in_place` - Migrate `generate_enum_variant` to use structural ast editing instead of string manipulation - Support tuple fields - Support record fields Please let me know if I should leave the commits as-is, or squash before merging. Fixes rust-lang#12797
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Along the lines of
shift_refandpop_ref.