Fix issue #5121: Add proper support for early/late distinction for lifetime bindings #12807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
|
Super weird, why don't I see these resolve problems on my own builds? (I did a Update: well, i can reproduce the above problem locally, so I must have just been sloppy with my earlier local |
There is a broader revision (that does this across the board) pending in rust-lang#12675, but that is awaiting the arrival of more data (to decide whether to keep OptVec alive by using a non-Vec internally). For this code, the representation of lifetime lists needs to be the same in both ScopeChain and in the ast and ty structures. So it seemed cleanest to just use `vec_ng::Vec`, now that it has a cheaper empty representation than the current `vec` code.
Uses newly added Vec::partition method to simplify resolve_lifetime.
bors
added a commit
that referenced
this pull request
Mar 12, 2014
…etime-params, r=pnkfelix Fix issue #5121: Add proper support for early/late distinction for lifetime bindings. There are some little refactoring cleanups as separate commits; the real meat that has the actual fix is in the final commit. The original author of the work was @nikomatsakis; I have reviewed it, revised it slightly, refactored it into these separate commits, and done some rebasing work.
This was referenced Mar 13, 2014
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 25, 2022
…ykril Add simple support for completion item details Supercedes rust-lang/rust-analyzer#9891 This doesn't yet really implement anything new, it just adds the scaffolding for the protocol conversion
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 30, 2024
…s, r=y21 Suppress `iter_on_empty_collections` if the iterator's concrete type is relied upon changelog: fixed rust-lang#12807
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #5121: Add proper support for early/late distinction for lifetime bindings.
There are some little refactoring cleanups as separate commits; the real meat that has the actual fix is in the final commit.
The original author of the work was @nikomatsakis; I have reviewed it, revised it slightly, refactored it into these separate commits, and done some rebasing work.