Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Fuchsia #128127

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Bump Fuchsia #128127

merged 1 commit into from
Jul 24, 2024

Conversation

tmandry
Copy link
Member

@tmandry tmandry commented Jul 24, 2024

This includes changes to unblock merging #126024.

try-job: x86_64-fuchsia

@rustbot
Copy link
Collaborator

rustbot commented Jul 24, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jul 24, 2024
@tmandry
Copy link
Member Author

tmandry commented Jul 24, 2024

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 24, 2024
@bors
Auto merge of rust-lang#128127 - tmandry:you-wouldnt-bump-a-fuchsia, …
591f6bb 
…r=<try>

Bump Fuchsia

This includes changes to unblock merging rust-lang#126024.

try-job: x86_64-fuchsia
@bors
Copy link
Contributor

bors commented Jul 24, 2024

⌛ Trying commit cfbb2e3 with merge 591f6bb...

@tmandry tmandry mentioned this pull request Jul 24, 2024
Merged
@rust-log-analyzer

This comment was marked as outdated.

Sign in to view
@bors

This comment was marked as outdated.

Sign in to view
@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 24, 2024
@tmandry
Bump Fuchsia
2fd41df 
This includes changes to unblock merging rust-lang#126024.
@tmandry tmandry force-pushed the you-wouldnt-bump-a-fuchsia branch from cfbb2e3 to 2fd41df Compare July 24, 2024 03:30
@tmandry
Copy link
Member Author

tmandry commented Jul 24, 2024

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 24, 2024
@bors
Auto merge of rust-lang#128127 - tmandry:you-wouldnt-bump-a-fuchsia, …
17a1345 
…r=<try>

Bump Fuchsia

This includes changes to unblock merging rust-lang#126024.

try-job: x86_64-fuchsia
@bors
Copy link
Contributor

bors commented Jul 24, 2024

⌛ Trying commit 2fd41df with merge 17a1345...

@bors
Copy link
Contributor

bors commented Jul 24, 2024

☀️ Try build successful - checks-actions
Build commit: 17a1345 (17a134524717990269a4957e6d3ebd06d2df3a92)

@Kobzol
Copy link
Contributor

Kobzol commented Jul 24, 2024

Thanks!

@bors r+ p=1

(priority set to to unblock #126024)

@bors
Copy link
Contributor

bors commented Jul 24, 2024

📌 Commit 2fd41df has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 24, 2024
@bors
Copy link
Contributor

bors commented Jul 24, 2024

⌛ Testing commit 2fd41df with merge 08a9ca7...

@bors
Copy link
Contributor

bors commented Jul 24, 2024

☀️ Test successful - checks-actions
Approved by: Kobzol
Pushing 08a9ca7 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 24, 2024
@bors bors merged commit 08a9ca7 into rust-lang:master Jul 24, 2024
7 checks passed
@rustbot rustbot added this to the 1.82.0 milestone Jul 24, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (08a9ca7): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -3.2%, secondary -2.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -3.2% [-3.2%, -3.2%] 1
Improvements ✅
(secondary)		 -2.2% [-2.2%, -2.2%] 1
All ❌✅ (primary) -3.2% [-3.2%, -3.2%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 770.179s -> 769.585s (-0.08%)
Artifact size: 328.89 MiB -> 328.88 MiB (-0.00%)

@tmandry tmandry deleted the you-wouldnt-bump-a-fuchsia branch July 24, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.82.0
Development

Successfully merging this pull request may close these issues.
7 participants
@tmandry @rustbot @bors @rust-log-analyzer @Kobzol @rust-timer @Mark-Simulacrum