Migrate `cross-lang-lto-upstream-rlibs`, `long-linker-command-lines` and `long-linker-command-lines-cmd-exe` `run-make` tests to rmake #128196

Oneirical · 2024-07-25T17:19:06Z

Part of #121876 and the associated Google Summer of Code project.

The long-linker tests are certainly doing something... interesting - they summon rustc calls with obscene quantities of arguments and check that this is appropriately handled. I removed the RUSTC_ORIGINAL magic - it's equivalent to RUSTC in tools.mk, so what is the purpose? Making it so the massive pile of flags doesn't modify rustc itself and start leaking into other tests? Tell me what you think.

Please try:

try-job: x86_64-msvc
try-job: i686-msvc
try-job: x86_64-mingw
try-job: i686-mingw
try-job: aarch64-apple
try-job: test-various
try-job: x86_64-gnu-debug
try-job: x86_64-gnu-llvm-17

rustbot · 2024-07-25T17:19:14Z

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2024-07-25T17:19:16Z

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

jieyouxu · 2024-07-25T17:47:26Z

@bors try

… r=<try> Migrate `cross-lang-lto-upstream-rlibs`, `long-linker-command-lines` and `long-linker-command-lines-cmd-exe` `run-make` tests to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). The `long-linker` tests are certainly doing something... interesting - they summon `rustc` calls with obscene quantities of arguments and check that this is appropriately handled. I removed the `RUSTC_ORIGINAL` magic - it's equivalent to `RUSTC` in `tools.mk`, so what is the purpose? Making it so the massive pile of flags doesn't modify rustc itself and start leaking into other tests? Tell me what you think. Please try: try-job: x86_64-msvc

bors · 2024-07-25T17:48:39Z

⌛ Trying commit 9ed58e6 with merge 5bdf06b...

bors · 2024-07-25T19:34:19Z

☀️ Try build successful - checks-actions
Build commit: 5bdf06b (5bdf06befc42dfa009dc918381b3759c5f85af07)

jieyouxu · 2024-07-26T02:37:20Z

Note to self: take a closer look at the self-linker magic.

jieyouxu

Thanks, LGTM in general, just some minor suggestions.

tests/run-make/long-linker-command-lines-cmd-exe/rmake.rs

tests/run-make/long-linker-command-lines/foo.rs

tests/run-make/cross-lang-lto-upstream-rlibs/rmake.rs

Oneirical · 2024-08-05T14:20:01Z

All review comments addressed. @rustbot review

jieyouxu · 2024-08-06T09:20:14Z

@bors try

bors · 2024-08-06T09:22:18Z

⌛ Trying commit 262f54d with merge d3ea261...

… r=<try> Migrate `cross-lang-lto-upstream-rlibs`, `long-linker-command-lines` and `long-linker-command-lines-cmd-exe` `run-make` tests to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). The `long-linker` tests are certainly doing something... interesting - they summon `rustc` calls with obscene quantities of arguments and check that this is appropriately handled. I removed the `RUSTC_ORIGINAL` magic - it's equivalent to `RUSTC` in `tools.mk`, so what is the purpose? Making it so the massive pile of flags doesn't modify rustc itself and start leaking into other tests? Tell me what you think. Please try: try-job: x86_64-msvc try-job: i686-msvc try-job: x86_64-mingw try-job: i686-mingw try-job: aarch64-apple try-job: test-various try-job: x86_64-gnu-debug try-job: x86_64-gnu-llvm-17

bors · 2024-08-06T11:46:27Z

☀️ Try build successful - checks-actions
Build commit: d3ea261 (d3ea261782cced65c52eefd1913ca00cf4adcd2f)

jieyouxu · 2024-08-06T11:52:50Z

@bors r+ rollup=iffy (cross-lang LTO, linker)

bors · 2024-08-06T11:52:53Z

📌 Commit 262f54d has been approved by jieyouxu

It is now in the queue for this repository.

bors · 2024-08-06T14:36:53Z

☔ The latest upstream changes (presumably #128245) made this pull request unmergeable. Please resolve the merge conflicts.

Oneirical · 2024-08-06T15:03:39Z

Rebased. Please re-approve. @rustbot ready

jieyouxu · 2024-08-07T00:53:35Z

@bors r+

bors · 2024-08-07T00:53:37Z

📌 Commit fe4cd9a has been approved by jieyouxu

It is now in the queue for this repository.

…n, r=jieyouxu Migrate `cross-lang-lto-upstream-rlibs`, `long-linker-command-lines` and `long-linker-command-lines-cmd-exe` `run-make` tests to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). The `long-linker` tests are certainly doing something... interesting - they summon `rustc` calls with obscene quantities of arguments and check that this is appropriately handled. I removed the `RUSTC_ORIGINAL` magic - it's equivalent to `RUSTC` in `tools.mk`, so what is the purpose? Making it so the massive pile of flags doesn't modify rustc itself and start leaking into other tests? Tell me what you think. Please try: try-job: x86_64-msvc try-job: i686-msvc try-job: x86_64-mingw try-job: i686-mingw try-job: aarch64-apple try-job: test-various try-job: x86_64-gnu-debug try-job: x86_64-gnu-llvm-17

bors · 2024-08-07T10:58:13Z

⌛ Testing commit fe4cd9a with merge 9bad7ba...

bors · 2024-08-07T13:22:14Z

☀️ Test successful - checks-actions
Approved by: jieyouxu
Pushing 9bad7ba to master...

rust-timer · 2024-08-07T14:39:24Z

Finished benchmarking commit (9bad7ba): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 3.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.0%	[3.0%, 3.0%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	3.0%	[3.0%, 3.0%]	1

Cycles

Results (secondary 2.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.1%	[1.9%, 2.4%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 762.326s -> 761.829s (-0.07%)
Artifact size: 336.97 MiB -> 336.99 MiB (0.01%)

rustbot assigned jieyouxu Jul 25, 2024

jieyouxu mentioned this pull request Jul 25, 2024

Tracking Issue for porting run-make tests to use Rust #121876

Open

jieyouxu approved these changes Aug 2, 2024

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 2, 2024

Oneirical force-pushed the poltergeist-manitestation branch from 9ed58e6 to 262f54d Compare August 5, 2024 14:19

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 5, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 6, 2024

bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 6, 2024

bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Aug 6, 2024

Oneirical added 3 commits August 6, 2024 11:03

rewrite cross-lang-lto-upstream-rlibs to rmake

342b807

rewrite long-linker-command-lines to rmake

fe6feb8

rewrite long-linker-command-lines-cmd-exe to rmake

fe4cd9a

Oneirical force-pushed the poltergeist-manitestation branch from 262f54d to fe4cd9a Compare August 6, 2024 15:03

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 6, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 7, 2024

tgross35 mentioned this pull request Aug 7, 2024

Rollup of 6 pull requests #128765

Closed

tgross35 mentioned this pull request Aug 7, 2024

Rollup of 3 pull requests #128774

Closed

bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 7, 2024

bors merged commit 9bad7ba into rust-lang:master Aug 7, 2024
7 checks passed

rustbot added this to the 1.82.0 milestone Aug 7, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate `cross-lang-lto-upstream-rlibs`, `long-linker-command-lines` and `long-linker-command-lines-cmd-exe` `run-make` tests to rmake #128196

Migrate `cross-lang-lto-upstream-rlibs`, `long-linker-command-lines` and `long-linker-command-lines-cmd-exe` `run-make` tests to rmake #128196

Oneirical commented Jul 25, 2024 •

edited by jieyouxu

Loading

rustbot commented Jul 25, 2024

rustbot commented Jul 25, 2024

jieyouxu commented Jul 25, 2024

bors commented Jul 25, 2024

bors commented Jul 25, 2024

jieyouxu commented Jul 26, 2024

jieyouxu left a comment

Oneirical commented Aug 5, 2024

jieyouxu commented Aug 6, 2024

bors commented Aug 6, 2024

bors commented Aug 6, 2024

jieyouxu commented Aug 6, 2024

bors commented Aug 6, 2024

bors commented Aug 6, 2024

Oneirical commented Aug 6, 2024

jieyouxu commented Aug 7, 2024

bors commented Aug 7, 2024

bors commented Aug 7, 2024

bors commented Aug 7, 2024

rust-timer commented Aug 7, 2024

Migrate cross-lang-lto-upstream-rlibs, long-linker-command-lines and long-linker-command-lines-cmd-exe run-make tests to rmake #128196

Migrate cross-lang-lto-upstream-rlibs, long-linker-command-lines and long-linker-command-lines-cmd-exe run-make tests to rmake #128196

Conversation

Oneirical commented Jul 25, 2024 • edited by jieyouxu Loading

rustbot commented Jul 25, 2024

rustbot commented Jul 25, 2024

jieyouxu commented Jul 25, 2024

bors commented Jul 25, 2024

bors commented Jul 25, 2024

jieyouxu commented Jul 26, 2024

jieyouxu left a comment

Choose a reason for hiding this comment

Oneirical commented Aug 5, 2024

jieyouxu commented Aug 6, 2024

bors commented Aug 6, 2024

bors commented Aug 6, 2024

jieyouxu commented Aug 6, 2024

bors commented Aug 6, 2024

bors commented Aug 6, 2024

Oneirical commented Aug 6, 2024

jieyouxu commented Aug 7, 2024

bors commented Aug 7, 2024

bors commented Aug 7, 2024

bors commented Aug 7, 2024

rust-timer commented Aug 7, 2024

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Migrate `cross-lang-lto-upstream-rlibs`, `long-linker-command-lines` and `long-linker-command-lines-cmd-exe` `run-make` tests to rmake #128196

Migrate `cross-lang-lto-upstream-rlibs`, `long-linker-command-lines` and `long-linker-command-lines-cmd-exe` `run-make` tests to rmake #128196

Oneirical commented Jul 25, 2024 •

edited by jieyouxu

Loading