Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rwlock downgrade #128219

Merged
merged 10 commits into from
Nov 18, 2024
Merged

Rwlock downgrade #128219

merged 10 commits into from
Nov 18, 2024

Commits on Nov 16, 2024

  1. add RwLock downgrade tests

    @connortsui20
    connortsui20 committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    b683e1d View commit details
    Browse the repository at this point in the history

  2. add downgrade method onto RwLockWriteGuard

    @connortsui20
    connortsui20 committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    f71ecc4 View commit details
    Browse the repository at this point in the history

  3. add simple downgrade implementations

    @connortsui20
    connortsui20 committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    3336ae0 View commit details
    Browse the repository at this point in the history

  4. add downgrade to futex implementation

    @connortsui20
    connortsui20 committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    fa9f04a View commit details
    Browse the repository at this point in the history

  5. modify queue implementation documentation 

    This commit only has documentation changes and a few things moved around
the file. The very few code changes are cosmetic: changes like turning a
`match` statement into an `if let` statement or reducing indentation for
long if statements.

This commit also adds several safety comments on top of `unsafe` blocks
that might not be immediately obvious to a first-time reader.

Code "changes" are in:
- `add_backlinks_and_find_tail`
- `lock_contended`

A majority of the changes are just expanding the comments from 80
columns to 100 columns.
    @connortsui20
    connortsui20 committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    31e35c2 View commit details
    Browse the repository at this point in the history

  6. add downgrade to queue implementation 

    This commit adds the `downgrade` method onto the inner `RwLock` queue
implementation.

There are also a few other style patches included in this commit.

Co-authored-by: Jonas Böttiger <jonasboettiger@icloud.com>
    @connortsui20 @joboet
    connortsui20 and joboet committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    26b5a14 View commit details
    Browse the repository at this point in the history

  7. add safety comments for queue implementation

    @connortsui20
    connortsui20 committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    3d191b5 View commit details
    Browse the repository at this point in the history

  8. fix memory ordering bug + bad test 

    This commit fixes a memory ordering bug in the futex implementation
(`Relaxed` -> `Release` on `downgrade`).

This commit also removes a badly written test that deadlocked and
replaces it with a more reasonable test based on an already-tested
`downgrade` test from the parking-lot crate.
    @connortsui20
    connortsui20 committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    84fd95c View commit details
    Browse the repository at this point in the history

  9. fix DOWNGRADED bit unpreserved 

    Co-authored-by: Jonas Böttiger <jonasboettiger@icloud.com>
    @connortsui20 @joboet
    connortsui20 and joboet committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    782b07e View commit details
    Browse the repository at this point in the history

  10. reduce threads in downgrade test

    @connortsui20
    connortsui20 committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    fc52cdd View commit details
    Browse the repository at this point in the history