Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not apply #[do_not_recommend] if the feature flag is not set #128674

Commits on Aug 9, 2024

  1. Do not apply #[do_not_recommend] if the feature flag is not set

    This commit adds additional checks for the feature flag as apparently it
    is possible to use this on a beta compiler without feature flags. To
    track whether a diagnostic attribute is allowed based of the feature in
    certain possibly upstream crate we introduce a new boolean flag stored
    in each attribute. This hopefully enables future diagnostic attributes
    to prevent this situation, as there is now a single place that can be
    checked whether the attribute should be honored or not.
    
    This0PR might be a candidate for backporting to the latest beta release.
    
    Reported in the bevy issue tracker: bevyengine/bevy#14591 (comment)
    weiznich committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    f518ce8 View commit details
    Browse the repository at this point in the history