Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify a minimum supported version for VxWorks #128758

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

devnexen
Copy link
Contributor

@devnexen devnexen commented Aug 6, 2024

Document that VxWorks 7 is the minimum supported version.

@rustbot
Copy link
Collaborator

rustbot commented Aug 6, 2024

r? @GuillaumeGomez

rustbot has assigned @GuillaumeGomez.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 6, 2024
@devnexen devnexen marked this pull request as ready for review August 6, 2024 20:57
@rustbot
Copy link
Collaborator

rustbot commented Aug 6, 2024

Some changes occurred in src/doc/rustc/src/platform-support

cc @Noratrieb

@devnexen
Copy link
Contributor Author

devnexen commented Aug 6, 2024

r? tgross35

@rustbot rustbot assigned tgross35 and unassigned GuillaumeGomez Aug 6, 2024
@tgross35
Copy link
Contributor

tgross35 commented Aug 6, 2024

This PR seeks to specify a minimum supported version of VxWorks to 7 to make it more obvious which APIs should be considered usable. Does this seem reasonable, or should a different version be specified?

Asking some people who have contributed to vxworks here or in libc, please comment or thumbs up if the proposed version seems good: @biabbas @jdygert-spok @NicholasBaron @BaoshanPang

Some more context is at #128758

(also, it would be good to have one or two more listed maintainers for VxWorks, which just means you can get pinged when platform-specific questions come up. If anyone here is interested, just submit a PR updating src/doc/rustc/src/platform-support/vxworks.md.)

@@ -20,6 +20,12 @@ Target triplets available:

## Requirements

### OS version

The minimum supported version is VxWorks 7 on x86/64 and ARM64.
Copy link
Contributor

@tgross35 tgross35 Aug 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are the architectures specified - is something different for ppc and arm32?

Copy link
Contributor

@biabbas biabbas Aug 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minimum supported version of OS would be the same for all VxWorks supported architectures. Although PowerPC targets are not an active consideration during Rust for VxWorks development.

Note:
#128545

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for confirming. @devnexen could you drop the "on x86/64 and ARM64" unless there is a specific reason?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@biabbas does this minimum version seem reasonable to you?

Also, could someone confirm when this version (VxWorks 7) was released? I am having some trouble figuring this out online what the oldest supported version will be.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think VxWorks 7 was released in 2016. Rust was enable for VxWorks in 2019(#61946 ). I've only worked on VxWorks 7.

Copy link
Contributor

@biabbas biabbas Aug 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Versions older than VxWorks7 would require porting efforts, minimum supported version should be VxWorks7.

But since we would have to go through the changes from VxWorks 6 to VxWorks 7 to confirm the minimum supported version. This seems less reasonable now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think your PR should be merged first.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@devnexen
Do you have access to VxWorks 6 workbench?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope.

Copy link
Contributor

@biabbas biabbas Aug 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for confirming. @devnexen could you drop the "on x86/64 and ARM64" unless there is a specific reason?

After these changes, this pr would be good for now.

@tgross35
Copy link
Contributor

tgross35 commented Aug 6, 2024

Just to clarify this should get some feedback before merge:

@rustbot blocked

@rustbot rustbot added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 6, 2024
@tgross35 tgross35 changed the title VxWorks platform support update proposal VxWorks minimum supported version proposal Aug 7, 2024
@tgross35 tgross35 changed the title VxWorks minimum supported version proposal Specify a minimum supported version for VxWorks Aug 7, 2024
@biabbas
Copy link
Contributor

biabbas commented Aug 7, 2024

This PR seeks to specify a minimum supported version of VxWorks to 7 to make it more obvious which APIs should be considered usable. Does this seem reasonable, or should a different version be specified?

Asking some people who have contributed to vxworks here or in libc, please comment or thumbs up if the proposed version seems good: @biabbas @jdygert-spok @NicholasBaron @BaoshanPang

Some more context is at #128758

(also, it would be good to have one or two more listed maintainers for VxWorks, which just means you can get pinged when platform-specific questions come up. If anyone here is interested, just submit a PR updating src/doc/rustc/src/platform-support/vxworks.md.)

I'm not sure if anyone else is also working on VxWorks rust, thus no one else is listed as a maintainer.

@devnexen devnexen force-pushed the vxworks_release_min branch 2 times, most recently from 27f029e to 00800bc Compare August 7, 2024 05:49
@devnexen devnexen force-pushed the vxworks_release_min branch from 00800bc to c8eacd6 Compare August 7, 2024 06:24
@tgross35
Copy link
Contributor

tgross35 commented Aug 7, 2024

If the specified version is from 2016, I think it is pretty unobjectionable. That is pretty similar to our oldest MacOS (10.12, 2016) and Windows (10, 2015). If there are any problems we can revisit, but this should make the ongoing std support effort more straightforward.

Thanks for getting this documented.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 7, 2024

📌 Commit c8eacd6 has been approved by tgross35

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Aug 7, 2024
tgross35 added a commit to tgross35/rust that referenced this pull request Aug 7, 2024
…ross35

Specify a minimum supported version for VxWorks

Document that VxWorks 7 is the minimum supported version.
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 7, 2024
Rollup of 7 pull requests

Successful merges:

 - rust-lang#128206 (Make create_dll_import_lib easier to implement)
 - rust-lang#128221 (Add implied target features to target_feature attribute)
 - rust-lang#128384 (Add tests to ensure MTE tags are preserved across FFI boundaries)
 - rust-lang#128656 (Enable msvc for run-make/rust-lld)
 - rust-lang#128691 (Update `compiler-builtins` to 0.1.117)
 - rust-lang#128700 (Migrate `simd-ffi` `run-make` test to rmake)
 - rust-lang#128758 (Specify a minimum supported version for VxWorks)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 7, 2024
…llaumeGomez

Rollup of 9 pull requests

Successful merges:

 - rust-lang#128206 (Make create_dll_import_lib easier to implement)
 - rust-lang#128424 (minor `effects` cleanups)
 - rust-lang#128527 (More information for fully-qualified suggestion when there are multiple impls)
 - rust-lang#128656 (Enable msvc for run-make/rust-lld)
 - rust-lang#128683 (bootstrap: clear miri's ui test deps when rustc changes)
 - rust-lang#128700 (Migrate `simd-ffi` `run-make` test to rmake)
 - rust-lang#128753 (Don't arbitrarily choose one upper bound for hidden captured region error message)
 - rust-lang#128757 (Migrate `pgo-gen-lto` `run-make` test to rmake)
 - rust-lang#128758 (Specify a minimum supported version for VxWorks)

Failed merges:

 - rust-lang#128679 (codegen: better centralize function declaration attribute computation)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 920cb64 into rust-lang:master Aug 7, 2024
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Aug 7, 2024
Rollup merge of rust-lang#128758 - devnexen:vxworks_release_min, r=tgross35

Specify a minimum supported version for VxWorks

Document that VxWorks 7 is the minimum supported version.
@rustbot rustbot added this to the 1.82.0 milestone Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants