-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
-Znext-solver
caching
#128828
Merged
Merged
-Znext-solver
caching
#128828
Commits on Aug 12, 2024
-
do not use the global solver cache for proof trees
doing so requires overwriting global cache entries and generally adds significant complexity to the solver. This is also only ever done for root goals, so it feels easier to wrap the `evaluate_canonical_goal` in an ordinary query if necessary.
Configuration menu - View commit details
-
Copy full SHA for 7b86c98 - Browse repository at this point
Copy the full SHA 7b86c98View commit details -
this allows us to only sometimes disable the global cache.
Configuration menu - View commit details
-
Copy full SHA for 51338ca - Browse repository at this point
Copy the full SHA 51338caView commit details -
Configuration menu - View commit details
-
Copy full SHA for e87157b - Browse repository at this point
Copy the full SHA e87157bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9308401 - Browse repository at this point
Copy the full SHA 9308401View commit details -
Configuration menu - View commit details
-
Copy full SHA for e83eacd - Browse repository at this point
Copy the full SHA e83eacdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c75c08 - Browse repository at this point
Copy the full SHA 0c75c08View commit details -
split provisional cache and stack lookup
this makes it easier to maintain and modify going forward. There may be a small performance cost as we now need to access the provisional cache *and* walk through the stack to detect cycles. However, the provisional cache should be mostly empty and the stack should only have a few elements so the performance impact is likely minimal. Given the complexity of the search graph maintainability trumps linear performance improvements.
Configuration menu - View commit details
-
Copy full SHA for f860873 - Browse repository at this point
Copy the full SHA f860873View commit details
Commits on Aug 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0aa17a4 - Browse repository at this point
Copy the full SHA 0aa17a4View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.