bypass linker configuration and cross target check for specific commands #128871

onur-ozkan · 2024-08-09T09:33:50Z

Avoids configuring the linker and checking cross-target-specific tools unless necessary.

Calling `Cargo::configure_linker` unconditionally slows down certain commands (e.g., "check" command) without providing any benefit. Signed-off-by: onur-ozkan <work@onurozkan.dev>

rustbot · 2024-08-09T09:33:59Z

r? @Kobzol

rustbot has assigned @Kobzol.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

For commands like check/clean there is no need to check for target tools. Avoiding this check can also speed up the process. Signed-off-by: onur-ozkan <work@onurozkan.dev>

src/bootstrap/src/core/builder.rs

Kobzol · 2024-09-02T12:38:12Z

@bors r+

bors · 2024-09-02T12:38:14Z

📌 Commit 94fbe14 has been approved by Kobzol

It is now in the queue for this repository.

bypass linker configuration and cross target check for specific commands Avoids configuring the linker and checking cross-target-specific tools unless necessary. Resolves rust-lang#128180 cc `@ChrisDenton`

…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#101339 (enable -Zrandomize-layout in debug CI builds ) - rust-lang#127021 (Add target support for RTEMS Arm) - rust-lang#127692 (Suggest `impl Trait` for References to Bare Trait in Function Header) - rust-lang#128701 (Don't Suggest Labeling `const` and `unsafe` Blocks ) - rust-lang#128871 (bypass linker configuration and cross target check for specific commands) - rust-lang#129624 (Adjust `memchr` pinning and run `cargo update`) - rust-lang#129706 (Rename dump of coroutine by-move-body to be more consistent, fix ICE in dump_mir) - rust-lang#129789 (rustdoc: use strategic boxing to shrink `clean::Item`) r? `@ghost` `@rustbot` modify labels: rollup

bypass linker configuration and cross target check for specific commands Avoids configuring the linker and checking cross-target-specific tools unless necessary. Resolves rust-lang#128180 cc ``@ChrisDenton``

…llaumeGomez Rollup of 7 pull requests Successful merges: - rust-lang#127021 (Add target support for RTEMS Arm) - rust-lang#128871 (bypass linker configuration and cross target check for specific commands) - rust-lang#129471 ([rustdoc] Sort impl associated items by kinds and then by appearance) - rust-lang#129529 (Add test to build crates used by r-a on stable) - rust-lang#129706 (Rename dump of coroutine by-move-body to be more consistent, fix ICE in dump_mir) - rust-lang#129796 (Unify scraped examples with other code examples) - rust-lang#129939 (explain why Rvalue::Len still exists) r? `@ghost` `@rustbot` modify labels: rollup

bypass linker configuration and cross target check for specific commands Avoids configuring the linker and checking cross-target-specific tools unless necessary. Resolves rust-lang#128180 cc ```@ChrisDenton```

Rollup of 8 pull requests Successful merges: - rust-lang#101339 (enable -Zrandomize-layout in debug CI builds ) - rust-lang#127021 (Add target support for RTEMS Arm) - rust-lang#128871 (bypass linker configuration and cross target check for specific commands) - rust-lang#129471 ([rustdoc] Sort impl associated items by kinds and then by appearance) - rust-lang#129529 (Add test to build crates used by r-a on stable) - rust-lang#129624 (Adjust `memchr` pinning and run `cargo update`) - rust-lang#129796 (Unify scraped examples with other code examples) - rust-lang#129939 (explain why Rvalue::Len still exists) r? `@ghost` `@rustbot` modify labels: rollup

bypass linker configuration and cross target check for specific commands Avoids configuring the linker and checking cross-target-specific tools unless necessary. Resolves rust-lang#128180 cc `@ChrisDenton`

…llaumeGomez Rollup of 7 pull requests Successful merges: - rust-lang#119229 (Update mingw-w64 + GNU toolchain) - rust-lang#128871 (bypass linker configuration and cross target check for specific commands) - rust-lang#128939 (Distribute rustc_codegen_cranelift for Windows) - rust-lang#129529 (Add test to build crates used by r-a on stable) - rust-lang#129624 (Adjust `memchr` pinning and run `cargo update`) - rust-lang#129835 (enable const-float-classify test, and test_next_up/down on 32bit x86) - rust-lang#130009 (rustdoc-search: allow trailing `Foo ->` arg search) r? `@ghost` `@rustbot` modify labels: rollup

GuillaumeGomez · 2024-09-06T14:19:54Z

I wonder if this the one which failed in #130027...

onur-ozkan · 2024-09-07T04:27:34Z

I wonder if this the one which failed in #130027...

Could be.

@bors rollup=iffy

bors · 2024-09-07T05:50:05Z

⌛ Testing commit 94fbe14 with merge 2122300...

Kobzol · 2024-09-07T07:38:40Z

@bors retry

bypass linker configuration and cross target check for specific commands Avoids configuring the linker and checking cross-target-specific tools unless necessary. Resolves rust-lang#128180 cc `@ChrisDenton`

bors · 2024-09-07T09:31:54Z

⌛ Testing commit 94fbe14 with merge d29eebd...

rust-log-analyzer · 2024-09-07T11:08:37Z

The job x86_64-msvc-ext failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[RUSTC-TIMING] miri test:false 4.469
error: failed to remove file `C:\a\rust\rust\build\x86_64-pc-windows-msvc\stage1-tools\x86_64-pc-windows-msvc\release\miri.exe`

Caused by:
  Access is denied. (os error 5)
Command has failed. Rerun with -v to see more details.
  local time: Sat, Sep  7, 2024 11:08:18 AM
  network time: Sat, 07 Sep 2024 11:08:18 GMT
##[error]Process completed with exit code 1.
Post job cleanup.

bors · 2024-09-07T11:09:19Z

💔 Test failed - checks-actions

Kobzol · 2024-09-07T11:13:32Z

@bors retry

bypass linker configuration and cross target check for specific commands Avoids configuring the linker and checking cross-target-specific tools unless necessary. Resolves rust-lang#128180 cc `@ChrisDenton`

…mpiler-errors Rollup of 9 pull requests Successful merges: - rust-lang#128871 (bypass linker configuration and cross target check for specific commands) - rust-lang#129468 ([testsuite][cleanup] Remove all usages of `dont_merge` hack to avoid function merging) - rust-lang#129614 (Adjust doc comment of Condvar::wait_while) - rust-lang#129840 (Implement suggestions for `elided_named_lifetimes`) - rust-lang#129891 (Do not request sanitizers for naked functions) - rust-lang#129899 (Add Suggestions for Misspelled Keywords) - rust-lang#129940 (s390x: Fix a regression related to backchain feature) - rust-lang#129987 (Don't store region in `CapturedPlace`) - rust-lang#130054 (Add missing quotation marks) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2024-09-07T13:21:48Z

⌛ Testing commit 94fbe14 with merge 7468b69...

bors · 2024-09-07T15:46:08Z

☀️ Test successful - checks-actions
Approved by: Kobzol
Pushing 7468b69 to master...

…mpiler-errors Rollup of 9 pull requests Successful merges: - rust-lang#128871 (bypass linker configuration and cross target check for specific commands) - rust-lang#129468 ([testsuite][cleanup] Remove all usages of `dont_merge` hack to avoid function merging) - rust-lang#129614 (Adjust doc comment of Condvar::wait_while) - rust-lang#129840 (Implement suggestions for `elided_named_lifetimes`) - rust-lang#129891 (Do not request sanitizers for naked functions) - rust-lang#129899 (Add Suggestions for Misspelled Keywords) - rust-lang#129940 (s390x: Fix a regression related to backchain feature) - rust-lang#129987 (Don't store region in `CapturedPlace`) - rust-lang#130054 (Add missing quotation marks) r? `@ghost` `@rustbot` modify labels: rollup

rust-timer · 2024-09-07T17:00:40Z

Finished benchmarking commit (7468b69): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -2.7%, secondary -0.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.6%	[2.6%, 2.6%]	1
Improvements ✅ (primary)	-2.7%	[-3.2%, -2.2%]	2
Improvements ✅ (secondary)	-3.1%	[-3.1%, -3.1%]	1
All ❌✅ (primary)	-2.7%	[-3.2%, -2.2%]	2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 756.798s -> 756.576s (-0.03%)
Artifact size: 341.03 MiB -> 341.08 MiB (0.02%)

…ic commands rust-lang#128871" Signed-off-by: onur-ozkan <work@onurozkan.dev>

…r-ozkan Do not skip linker configuration for `check` builds This essentially reverts a part of rust-lang#128871, to fix rust-lang#130108. This is mostly a hotfix until we can figure out a better way to both avoid rebuilds and avoid configuring the linker for `x check`. Skipping linker for check builds was causing unexpected rebuilds. Fixes: rust-lang#130108

Do not skip linker configuration for `check` builds This essentially reverts a part of rust-lang/rust#128871, to fix rust-lang/rust#130108. This is mostly a hotfix until we can figure out a better way to both avoid rebuilds and avoid configuring the linker for `x check`. Skipping linker for check builds was causing unexpected rebuilds. Fixes: rust-lang/rust#130108

call Cargo::configure_linker only for specific commands

9a29081

Calling `Cargo::configure_linker` unconditionally slows down certain commands (e.g., "check" command) without providing any benefit. Signed-off-by: onur-ozkan <work@onurozkan.dev>

rustbot assigned Kobzol Aug 9, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Aug 9, 2024

onur-ozkan changed the title ~~128180~~ bypass linker configuration and cross target check for specific commands Aug 9, 2024

don't try to find target tools on certain commands

94fbe14

For commands like check/clean there is no need to check for target tools. Avoiding this check can also speed up the process. Signed-off-by: onur-ozkan <work@onurozkan.dev>

Kobzol reviewed Aug 9, 2024

View reviewed changes

src/bootstrap/src/core/builder.rs Show resolved Hide resolved

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 2, 2024

matthiaskrgr mentioned this pull request Sep 2, 2024

Rollup of 8 pull requests #129900

Closed

GuillaumeGomez mentioned this pull request Sep 3, 2024

Rollup of 7 pull requests #129946

Closed

tgross35 mentioned this pull request Sep 4, 2024

Rollup of 8 pull requests #129949

Closed

GuillaumeGomez mentioned this pull request Sep 6, 2024

Rollup of 7 pull requests #130027

Closed

bors added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 7, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 7, 2024

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 7, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 7, 2024

compiler-errors mentioned this pull request Sep 7, 2024

Rollup of 9 pull requests #130066

Merged

bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 7, 2024

bors merged commit 7468b69 into rust-lang:master Sep 7, 2024
7 checks passed

rustbot added this to the 1.83.0 milestone Sep 7, 2024

onur-ozkan deleted the 128180 branch September 7, 2024 16:11

onur-ozkan mentioned this pull request Sep 8, 2024

Bootstrap re-builds everything after "x.py check" #130108

Closed

onur-ozkan added a commit to onur-ozkan/rust that referenced this pull request Sep 9, 2024

Revert "bypass linker configuration and cross target check for specif…

25511ed

…ic commands rust-lang#128871" Signed-off-by: onur-ozkan <work@onurozkan.dev>

onur-ozkan mentioned this pull request Sep 9, 2024

Revert "bypass linker configuration and cross target check for specific commands #128871" #130134

Closed

Kobzol mentioned this pull request Sep 9, 2024

Do not skip linker configuration for check builds #130135

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bypass linker configuration and cross target check for specific commands #128871

bypass linker configuration and cross target check for specific commands #128871

onur-ozkan commented Aug 9, 2024

rustbot commented Aug 9, 2024

Kobzol commented Sep 2, 2024

bors commented Sep 2, 2024

GuillaumeGomez commented Sep 6, 2024

onur-ozkan commented Sep 7, 2024

bors commented Sep 7, 2024

Kobzol commented Sep 7, 2024

bors commented Sep 7, 2024

rust-log-analyzer commented Sep 7, 2024

bors commented Sep 7, 2024

Kobzol commented Sep 7, 2024

bors commented Sep 7, 2024

bors commented Sep 7, 2024

rust-timer commented Sep 7, 2024

bypass linker configuration and cross target check for specific commands #128871

bypass linker configuration and cross target check for specific commands #128871

Conversation

onur-ozkan commented Aug 9, 2024

rustbot commented Aug 9, 2024

Kobzol commented Sep 2, 2024

bors commented Sep 2, 2024

GuillaumeGomez commented Sep 6, 2024

onur-ozkan commented Sep 7, 2024

bors commented Sep 7, 2024

Kobzol commented Sep 7, 2024

bors commented Sep 7, 2024

rust-log-analyzer commented Sep 7, 2024

bors commented Sep 7, 2024

Kobzol commented Sep 7, 2024

bors commented Sep 7, 2024

bors commented Sep 7, 2024

rust-timer commented Sep 7, 2024

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size