-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make DeepRejectCtxt
symmetric with respect to TreatParams
#129051
Conversation
thanks @bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
… r=<try> Make `DeepRejectCtxt` symmetric with respect to `TreatParams` The PR was split from rust-lang#128776 r? `@lcnr`
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (82992a0): comparison URL. Overall result: ❌ regressions - ACTION NEEDEDBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @bors rollup=never Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResults (secondary -3.3%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 752.976s -> 753.56s (0.08%) |
503fbd8
to
b4eaef1
Compare
In the latest commit, micro-optimizations from the comment were added. |
pub struct DeepRejectCtxt<I: Interner> { | ||
treat_obligation_params: TreatParams, | ||
pub struct DeepRejectCtxt<I: Interner, const TREAT_LHS_PARAMS: bool, const TREAT_RHS_PARAMS: bool> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better to use the adt_const_params
here, but I'm not sure if that feature is allowed in rustc_type_ir
.
This comment has been minimized.
This comment has been minimized.
b4eaef1
to
35ca8f8
Compare
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
… r=<try> Make `DeepRejectCtxt` symmetric with respect to `TreatParams` The PR was split from rust-lang#128776 r? `@lcnr`
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (1776c24): comparison URL. Overall result: ✅ improvements - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)Results (primary 4.7%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 751.027s -> 751.371s (0.05%) |
I also rewrote before:
after:
|
☔ The latest upstream changes (presumably #128252) made this pull request unmergeable. Please resolve the merge conflicts. |
#128776 has landed |
The PR was split from #128776
r? @lcnr