Add platform docs for FreeBSD. #129220

asomers · 2024-08-17T23:38:56Z

No description provided.

rustbot · 2024-08-17T23:39:04Z

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

asomers · 2024-08-17T23:39:27Z

cc @tgross35 . Also, perhaps @MikaelUrankar would like to sign up as a second target maintainer?

ehuss · 2024-08-18T00:33:57Z

r? ehuss

Looks like we have two PRs updating the same thing over at #128546.

Can we combine them? Or I can merge #128546 now, until this is ready?

workingjubilee

In the platform support docs, please note that FreeBSD's ports patches i686-unknown-freebsd in a way that introduces incorrect compilations, thus people must use the upstream toolchain instead of a FreeBSD-built toolchain for building for i686-unknown-freebsd without introducing incorrect compilations.

Unless this changes, of course.

beetrees · 2024-08-18T08:57:39Z

Ideally (since FreeBSD wants to support pre-SSE2 CPUs), instead of FreeBSD ports patching the i686-unknown-freebsd package to be subtly different than upstream, a separate i586-unknown-freebsd target should be introduced (similar to the existing i586-unknown-linux-gnu target for Linux). That way upstream and FreeBSD ports targets can have the same behaviour, and users can pick between "I want to support really old hardware" (i586) and "I want to be able to use floats" (i686), same as they can on other operating systems.

beetrees · 2024-08-18T10:03:10Z

Also, as far as I can tell, the powerpc64-unknown-freebsd target in upstream Rust supports FreeBSD 12 only as FreeBSD 13+ switched to the ELFv2 ABI, which the FreeBSD port patches the Rust compiler to use. Given that FreeBSD 12 is EOL, the solution seems to be to upstream a cx.target_spec().os == "freebsd" version of the patch (the FreeBSD ports patch currently changes all big-endian PowerPC64 targets to use ELFv2, not just FreeBSD), and just state that powerpc64-unknown-freebsd only supports FreeBSD 13+. The target description also needs to be updated: currently it states "PPC64 FreeBSD (ELFv1 and ELFv2)" which is incorrect as the compiler currently only supports the ELFv1 ABI for the target (and after the patch is upstreamed will only support the ELFv2 ABI for the target).

MikaelUrankar · 2024-08-18T12:11:18Z

cc @tgross35 . Also, perhaps @MikaelUrankar would like to sign up as a second target maintainer?

Yes, you can put me as a 2nd target maintainer.

asomers · 2024-08-20T23:13:29Z

@workingjubilee @beetrees the decision to build lang/rust without SSE support was made in 2017, before any of the linked LLVM issues. I'll start a discussion about revisiting it. I'll inquire about the ELFv1/ELFv2 issue too.

workingjubilee · 2024-08-23T02:28:17Z

Ideally (since FreeBSD wants to support pre-SSE2 CPUs)

I am not entirely sure they do? I have been informed contrariwise, i.e. that FreeBSD is only interested in Pentium 4 or later equivalents. Naturally, that might have been decided many years after the 2017 decision!

Of course, if two targets settles the matter for FreeBSD, that is fine by me, and if a documentation change is preferred, that is also fine by me. I do not mean to be obstructive, I merely want the matter to be clear for everyone involved.

beetrees · 2024-08-23T05:01:35Z

I was inferring "since FreeBSD wants to support pre-SSE2 CPUs" from the FreeBSD i386 platform page, which states "FreeBSD/i386 should support any CPU compatible with the Intel Pentium Pro / Pentium II (i686) or better" (it's quite possible that the platform page is out of date though).

It's worth noting that the FreeBSD 14.1 release notes state that 32-bit x86 platform support will be dropped from FreeBSD 15 onwards, while support for running 32-bit binaries on 64-bit x86 will remain for at least FreeBSD 15 and 16. Given that all 64-bit x86 CPUs support SSE2, there will definitely be no need for non-SSE2 CPU support after FreeBSD 14 reaches EOL (currently expected to be in November 2028).

src/doc/rustc/src/platform-support/freebsd.md

beetrees · 2024-10-20T17:03:18Z

#120869 appears relevant to this PR as it bumps the minimum supported FreeBSD version.

bors · 2024-10-21T04:17:57Z

☔ The latest upstream changes (presumably #120869) made this pull request unmergeable. Please resolve the merge conflicts.

ehuss · 2024-10-21T14:49:59Z

Just FYI, you'll need to add the link to SUMMARY.md. Also, I'd suggest fixing the target definitions in
compiler/rustc_target/src/spec/targets if those are indeed incorrect. See #128546 for examples of these changes.

workingjubilee · 2024-10-21T21:14:17Z

@ehuss I would rather not deliberately introduce miscompilations into existing tier 2 targets that currently have none, whether or not ports has decided to make their target unsound.

ehuss · 2024-10-21T22:12:51Z

@workingjubilee Sorry, I'm not following. Are you asking that the change requested above be resolved? I'm not the author, so I wouldn't be the one making that change. As the reviewer, I won't merge until it is resolved.

Or maybe you intended to tag one of the other commenters here? Sorry, I'm confused. 😕

workingjubilee · 2024-10-21T22:21:21Z

@ehuss I am saying that the resolution can include ports fixing its target definition to not make Rust code unsound, i.e. by ceasing to apply their patch, rather than it being "fixed" here by making the target unsound for our toolchain as well.

Unless that is what you meant, in which case it was just unclear to me, apologies.

asomers · 2024-10-21T22:50:53Z

A change is underway to reenable SSE on i386 by default: https://reviews.freebsd.org/D47227

ehuss · 2024-10-23T17:53:03Z

@rustbot author

Dylan-DPC · 2024-11-07T17:06:21Z

@asomers any updates on this? thanks

asomers · 2024-11-08T15:07:37Z

@asomers any updates on this? thanks

I expect to merge that change, reenabling SSE2 on i386, by EoD on Saturday.

tgross35 · 2024-12-09T00:02:36Z

Is the SSE note accurate since the push 3 weeks ago?

If not, I think it would be okay to drop that section for now and merge the rest of the docs so we at least have something.

asomers · 2024-12-09T01:05:58Z

Is the SSE note accurate since the push 3 weeks ago?

If not, I think it would be okay to drop that section for now and merge the rest of the docs so we at least have something.

Yes, the SSE note is accurate. I committed that change on 9-Nov. https://reviews.freebsd.org/R11:b039f2e46b15c1ff5cbaf41e642993d982294da3

rustbot · 2024-12-09T01:10:22Z

Some changes occurred in src/doc/rustc/src/platform-support

cc @Noratrieb

tgross35

This needs an entry in SUMMARY.md and a squash, but with freebsd/freebsd-ports@b039f2e I don't think there is anything that this would be waiting on.

bors · 2024-12-14T16:20:47Z

☔ The latest upstream changes (presumably #134296) made this pull request unmergeable. Please resolve the merge conflicts.

tgross35 · 2024-12-22T20:03:55Z

@asomers could you rebase and squash? I'll merge this, if any small changes are needed they can come as a followup.

asomers · 2024-12-22T20:57:46Z

@asomers could you rebase and squash? I'll merge this, if any small changes are needed they can come as a followup.

done

tgross35 · 2024-12-22T21:24:38Z

@bors r+ rollup

bors · 2024-12-22T21:24:41Z

📌 Commit 12b54b1 has been approved by tgross35

It is now in the queue for this repository.

Rollup of 4 pull requests Successful merges: - rust-lang#129220 (Add platform docs for FreeBSD.) - rust-lang#134659 (test-infra: improve compiletest and run-make-support symlink handling) - rust-lang#134668 (Make sure we don't lose default struct value when formatting struct) - rust-lang#134672 (Revert stabilization of the `#[coverage(..)]` attribute) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#129220 - asomers:target-maintainer, r=tgross35 Add platform docs for FreeBSD.

rustbot assigned JohnTitor Aug 17, 2024

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 17, 2024

This comment has been minimized.

Sign in to view

ehuss mentioned this pull request Aug 18, 2024

Add FreeBSD support information #128546

Closed

rustbot assigned ehuss and unassigned JohnTitor Aug 18, 2024

workingjubilee requested changes Aug 18, 2024

View reviewed changes

This comment has been minimized.

Sign in to view

ChrisDenton mentioned this pull request Sep 2, 2024

Complete tier 3 target information #126451

Open

emaste reviewed Oct 20, 2024

View reviewed changes

src/doc/rustc/src/platform-support/freebsd.md Outdated Show resolved Hide resolved

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 23, 2024

beetrees mentioned this pull request Oct 25, 2024

ci update freebsd version proposal, freebsd 12 being eol #120869

Merged

beetrees mentioned this pull request Oct 25, 2024

Fix powerpc64 big-endian FreeBSD ABI #132150

Merged

This was referenced Nov 19, 2024

Drop support for FreeBSD 10 and 11 from std #89058

Open

Raise libc's FreeBSD ABI to 12 rust-lang/libc#2406

Merged

asomers force-pushed the target-maintainer branch from 079fe19 to 03c6091 Compare November 21, 2024 02:25

asomers force-pushed the target-maintainer branch from ac162d6 to fe6356f Compare December 9, 2024 01:10

asomers marked this pull request as ready for review December 9, 2024 01:10

This comment has been minimized.

Sign in to view

tgross35 approved these changes Dec 12, 2024

View reviewed changes

asomers requested a review from workingjubilee December 12, 2024 16:56

Add platform docs for FreeBSD.

12b54b1

asomers force-pushed the target-maintainer branch from 32adb3e to 12b54b1 Compare December 22, 2024 20:57

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 22, 2024

tgross35 mentioned this pull request Dec 23, 2024

Rollup of 4 pull requests #134677

Merged

bors merged commit 3acf9c9 into rust-lang:master Dec 23, 2024
6 checks passed

rustbot added this to the 1.85.0 milestone Dec 23, 2024

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 23, 2024

Unrolled build for rust-lang#129220

06eaad7

Rollup merge of rust-lang#129220 - asomers:target-maintainer, r=tgross35 Add platform docs for FreeBSD.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add platform docs for FreeBSD. #129220

Add platform docs for FreeBSD. #129220

asomers commented Aug 17, 2024

rustbot commented Aug 17, 2024

asomers commented Aug 17, 2024

This comment has been minimized.

ehuss commented Aug 18, 2024

workingjubilee left a comment

beetrees commented Aug 18, 2024

beetrees commented Aug 18, 2024 •

edited

Loading

MikaelUrankar commented Aug 18, 2024

asomers commented Aug 20, 2024

This comment has been minimized.

workingjubilee commented Aug 23, 2024

beetrees commented Aug 23, 2024

beetrees commented Oct 20, 2024

bors commented Oct 21, 2024

ehuss commented Oct 21, 2024

workingjubilee commented Oct 21, 2024

ehuss commented Oct 21, 2024

workingjubilee commented Oct 21, 2024 •

edited

Loading

asomers commented Oct 21, 2024

ehuss commented Oct 23, 2024

Dylan-DPC commented Nov 7, 2024

asomers commented Nov 8, 2024 •

edited

Loading

tgross35 commented Dec 9, 2024

asomers commented Dec 9, 2024

rustbot commented Dec 9, 2024

This comment has been minimized.

tgross35 left a comment

bors commented Dec 14, 2024

tgross35 commented Dec 22, 2024

asomers commented Dec 22, 2024

tgross35 commented Dec 22, 2024

bors commented Dec 22, 2024

Add platform docs for FreeBSD. #129220

Add platform docs for FreeBSD. #129220

Conversation

asomers commented Aug 17, 2024

rustbot commented Aug 17, 2024

asomers commented Aug 17, 2024

This comment has been minimized.

ehuss commented Aug 18, 2024

workingjubilee left a comment

Choose a reason for hiding this comment

beetrees commented Aug 18, 2024

beetrees commented Aug 18, 2024 • edited Loading

MikaelUrankar commented Aug 18, 2024

asomers commented Aug 20, 2024

This comment has been minimized.

workingjubilee commented Aug 23, 2024

beetrees commented Aug 23, 2024

beetrees commented Oct 20, 2024

bors commented Oct 21, 2024

ehuss commented Oct 21, 2024

workingjubilee commented Oct 21, 2024

ehuss commented Oct 21, 2024

workingjubilee commented Oct 21, 2024 • edited Loading

asomers commented Oct 21, 2024

ehuss commented Oct 23, 2024

Dylan-DPC commented Nov 7, 2024

asomers commented Nov 8, 2024 • edited Loading

tgross35 commented Dec 9, 2024

asomers commented Dec 9, 2024

rustbot commented Dec 9, 2024

This comment has been minimized.

tgross35 left a comment

Choose a reason for hiding this comment

bors commented Dec 14, 2024

tgross35 commented Dec 22, 2024

asomers commented Dec 22, 2024

tgross35 commented Dec 22, 2024

bors commented Dec 22, 2024

beetrees commented Aug 18, 2024 •

edited

Loading

workingjubilee commented Oct 21, 2024 •

edited

Loading

asomers commented Nov 8, 2024 •

edited

Loading